From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EE56C77B61 for ; Thu, 13 Apr 2023 16:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IuH8Fvzz6xYXz744QbcJz9vOVRcoTj45VkG2Y7Vg+oM=; b=p3fH2HDWMxsti4 36EoPuczq3VagZHv2fbbiVKC3Ux9hL/hgI5nsl/DUMJeBSnIRCK80RR1H8qIxJD+dYXFwZeIvA8sL Y98rKWs9Rlg/qAG+TJPx7Y3+gXqdPC3GddyP2Fcee1JJqL39OOa2ik1ShzGpnHmJb64Ugawruy8VN D9ziyAAKnADAXhrdOsrnTSk/w5wlZF64xb9mAlwEr386W8FT8vU0hPenIaK4kHdCbYial0UypUe8t ZMyLdKxN+bpKsqxoumfwpviwaGDrgulo5MZLNiCAdrWNuwyjpM8QIYeAj1zcxrRcZR4RNiZBR6T2l XPaUMK4ld3O2X8uTCVDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmzaH-006cGg-2f; Thu, 13 Apr 2023 16:14:05 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmzaE-006cFC-2F for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 16:14:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681402442; x=1712938442; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iAGgqsfkVCgnhVtMdEmX8hcxBQ/3qJLFMKe4cTfgjds=; b=bVNwML890sSvMqHIuji2d4CYBfo0ZFIsM052YqZoLP10M3M6Qqngq2E4 tmw9b2xiYhcmenHNB1b00Xn5rUF+ZghEg2w2R0eZ30SLFp92gDwx1lSg8 ODM0skwg3DXP9HXy4BSXM5LMDm/+w+3kEegUpqWLOwF1u0scQ/EQFaEsQ u4NWbjYB+XRxSejVz4v9lJ3U65cLeQj6q53c3nLDPjSRFGpX3wdPZF7BV 9KOWfgYsjQmhkL2AmrqUa3u31EUpTmAot45fFJ69Mki5zJY3b5L4Pk4Vi uqJY75BWtwXz51AumfYza32nL8gzqKGB+w3iZIlbOiaKD11cqf8tc7YNh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="332966824" X-IronPort-AV: E=Sophos;i="5.99,194,1677571200"; d="scan'208";a="332966824" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2023 09:11:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="813506683" X-IronPort-AV: E=Sophos;i="5.99,194,1677571200"; d="scan'208";a="813506683" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 13 Apr 2023 09:10:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pmzXE-00GcfK-2T; Thu, 13 Apr 2023 19:10:56 +0300 Date: Thu, 13 Apr 2023 19:10:56 +0300 From: Andy Shevchenko To: Ryan Chen Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Andrew Jeffery , Philipp Zabel , Wolfram Sang , linux-i2c@vger.kernel.org, Florian Fainelli , Jean Delvare , William Zhang , Tyrone Ting , Tharun Kumar P , Conor Dooley , Phil Edworthy , openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 2/2 RESEND] i2c: aspeed: support ast2600 i2c new register mode driver Message-ID: References: <20230413075327.1397306-1-ryan_chen@aspeedtech.com> <20230413075327.1397306-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230413075327.1397306-3-ryan_chen@aspeedtech.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_091402_827046_5BFC4E71 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 13, 2023 at 03:53:27PM +0800, Ryan Chen wrote: > Add i2c new register mode driver to support AST2600 i2c > new register mode. AST2600 i2c controller have legacy and > new register mode. The new register mode have global register > support 4 base clock for scl clock selection, and new clock > divider mode. The i2c new register mode have separate register > set to control i2c master and slave. There is already i2c-aspeed.c in the kernel. Can you elaborate what's wrong with the extending existing driver? (It seems to me that so called "legacy" mode is exactly what is being serviced by that driver.) -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel