From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 588FAC77B77 for ; Fri, 14 Apr 2023 11:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GH/804NHT4et5H1t/pVHlG5ozE0XE8KX4squOycZr00=; b=vWt9qM6KSpe6s1 MTYR6zLZ0stYgsDeyWa1A+N6XIdhfFtcAyPoCK4BrmBbrnpC1vxD+d9lz8JqV8uJU07dAIP3kNvGn llE9HKSfPpcc07fZfb/JldbVHr4ML8QrDwmuDGh39ZHR00KLESVkIAIXnuW08ZgU+t/TnpmhYoC0I x/JKp3AaqumDhsz9rDuLXby3EGQrz7cCUhc+wj8WG2MeYBq4nSFndDEmzVIi70Rv4RX8+SWn3FJio +/d2sdiF4/SSIBNIPtVPlDd2o72P/8ibNxSs988c5iNa0QoWPgM+30PSl3FLCwiUFTg4eAVJutJk1 4QZpPwjh+tK8mvP5iV8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnHBC-009HwZ-0f; Fri, 14 Apr 2023 11:01:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnHB8-009Hsq-0Z for linux-arm-kernel@lists.infradead.org; Fri, 14 Apr 2023 11:01:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8DA82F4; Fri, 14 Apr 2023 04:01:56 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.21.222]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD91B3F587; Fri, 14 Apr 2023 04:01:10 -0700 (PDT) Date: Fri, 14 Apr 2023 12:01:07 +0100 From: Mark Rutland To: Johan Hovold , Arnd Bergmann Cc: Lorenzo Pieralisi , Ulf Hansson , Dmitry Baryshkov , Sudeep Holla , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to info level Message-ID: References: <20230414084619.31524-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230414084619.31524-1-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_040118_277891_C44420B2 X-CRM114-Status: GOOD ( 21.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 14, 2023 at 10:46:19AM +0200, Johan Hovold wrote: > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > is now logged at warning level: > > psci: failed to set PC mode: -3 > > As there is nothing users can do about the firmware behaving this way, > demote the warning to info level and clearly mark it as a firmware bug: > > psci: [Firmware Bug]: failed to set PC mode: -3 > > Reviewed-by: Ulf Hansson > Acked-by: Mark Rutland > Acked-by: Sudeep Holla > Signed-off-by: Johan Hovold > --- > > This one fell between the cracks so resending with tags added. > > Mark or Lorenzo, is this something you can pick up? > > Johan Sorry about this. I don't think we have anything else in this area, so Arnd, are you happy to pick this via the soc tree? Thanks, Mark. > > > drivers/firmware/psci/psci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 29619f49873a..d9629ff87861 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > if (err < 0) > - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > + pr_info(FW_BUG "failed to set %s mode: %d\n", > + enable ? "OSI" : "PC", err); > return psci_to_linux_errno(err); > } > > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel