From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Tony Lindgren <tony@atomide.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-arm-kernel@lists.infradead.org,
"Russell King" <linux@armlinux.org.uk>,
"Nick Terrell" <terrelln@fb.com>, "Arnd Bergmann" <arnd@arndb.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Nick Hawkins" <nick.hawkins@hpe.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Xin Li" <xin3.li@intel.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Paul Bolle" <pebolle@tiscali.nl>,
"Bart Van Assche" <bvanassche@acm.org>,
linux-kernel@vger.kernel.org,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH 1/3] ARM: compressed: Pass the actual output length to the decompressor
Date: Sat, 15 Apr 2023 03:52:34 +0200 [thread overview]
Message-ID: <ZDoDYh01GYjdwp63@probook> (raw)
In-Reply-To: <20230413052050.GB9837@atomide.com>
[-- Attachment #1.1: Type: text/plain, Size: 879 bytes --]
On Thu, Apr 13, 2023 at 08:20:50AM +0300, Tony Lindgren wrote:
> * Jonathan Neuschäfer <j.neuschaefer@gmx.net> [230412 21:22]:
> > --- a/arch/arm/boot/compressed/misc.c
> > +++ b/arch/arm/boot/compressed/misc.c
> > +static u32 get_inflated_image_size(void)
> > +{
> > + return get_unaligned_le32(input_data_end - 4);
> > +}
>
> Just something to check.. This patch should not picked for the old stable
> kernels that did not have the uncompressed image size at the end. Maybe
> the patch should have a Depends-on tag to prevent possible issues?
As far as I can see, the appended size has been around for a really long
time (v2.6.28, commit bc22c17e12c130dc929218a95aa347e0f3fd05dc), far
longer than the oldest LTS kernel that's still around.
>
> Other than that looks good to me:
>
> Reviewed-by: Tony Lindgren <tony@atomide.com>
Thanks
Jonathan
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-15 1:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 21:21 [PATCH 0/3] ARM ZSTD boot compression Jonathan Neuschäfer
2023-04-12 21:21 ` [PATCH 1/3] ARM: compressed: Pass the actual output length to the decompressor Jonathan Neuschäfer
2023-04-12 21:42 ` Linus Walleij
2023-04-12 21:48 ` Florian Fainelli
2023-04-13 5:20 ` Tony Lindgren
2023-04-15 1:52 ` Jonathan Neuschäfer [this message]
2023-04-12 21:21 ` [PATCH 2/3] ARM: compressed: Bump MALLOC_SIZE to 128 KiB Jonathan Neuschäfer
2023-04-12 21:43 ` Linus Walleij
2023-04-12 21:48 ` Florian Fainelli
2023-05-02 8:39 ` Russell King (Oracle)
2023-04-12 21:21 ` [PATCH 3/3] ARM: compressed: Enable ZSTD compression Jonathan Neuschäfer
2023-04-12 21:45 ` Linus Walleij
2023-04-12 21:49 ` Florian Fainelli
2023-04-12 21:33 ` [PATCH 0/3] ARM ZSTD boot compression Arnd Bergmann
2023-04-13 11:13 ` Arnd Bergmann
2023-04-15 2:00 ` Jonathan Neuschäfer
2023-10-12 22:33 ` Nick Terrell
2023-10-13 1:27 ` J. Neuschäfer
2023-10-20 18:53 ` Nick Terrell
2023-04-14 22:50 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDoDYh01GYjdwp63@probook \
--to=j.neuschaefer@gmx.net \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=christophe.leroy@csgroup.eu \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ndesaulniers@google.com \
--cc=nick.hawkins@hpe.com \
--cc=pebolle@tiscali.nl \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sebastian.reichel@collabora.com \
--cc=sw0312.kim@samsung.com \
--cc=terrelln@fb.com \
--cc=tony@atomide.com \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).