From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32BCBC7618E for ; Fri, 21 Apr 2023 08:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O39qlz0d0mgquhjne4gGhFynOzDEcwhu7MlqHvMDRcY=; b=eJmmdlGinSJ/YZ jinIH1Cf2MEq9jJvMLzW1PDN3ytiSR1MGroZpCSu176DNkSpcA8AzNjenjM6Ucugt7q16CmcVP9fu wrgp3i4YaM7VftGcvLmge685mOqw6SAffwFDn3UEY2JlQ50IOTO3lyH/YTVjOU+W+T3M2so7Z9pzZ XnCWXp+mdgRkNiRdnb2qQD8b/JTsTaJDaTvMclwd7oOZqu/f4uJ84rcvXQyP/w/atobLdvtcJQDEq jgSS5tbpN2CARpEEqUPVFw7DkUkTK/Js8mEapxu3VkWLiZBBNXqahnpsejG+F+04aevelDiMiT/HU JWPLm2+s4zv05QaM2ozg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppmPS-00A8mF-0B; Fri, 21 Apr 2023 08:46:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppmPM-00A8kl-2J for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2023 08:46:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 643431480; Fri, 21 Apr 2023 01:47:00 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7B0D3F5A1; Fri, 21 Apr 2023 01:46:15 -0700 (PDT) Date: Fri, 21 Apr 2023 09:46:11 +0100 From: Cristian Marussi To: Tejun Heo Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_014620_846124_FC5DD35D X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote: > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > interface and using 0 for @max_active for the default setting. > Hi Tejun, my bad I messed up the params in the call. LGTM. Thanks, Cristian > Signed-off-by: Tejun Heo > --- > drivers/firmware/arm_scmi/raw_mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/firmware/arm_scmi/raw_mode.c > +++ b/drivers/firmware/arm_scmi/raw_mode.c > @@ -1066,7 +1066,7 @@ static int scmi_xfer_raw_worker_init(str > > raw->wait_wq = alloc_workqueue("scmi-raw-wait-wq-%d", > WQ_UNBOUND | WQ_FREEZABLE | > - WQ_HIGHPRI, WQ_SYSFS, raw->id); > + WQ_HIGHPRI | WQ_SYSFS, 0, raw->id); > if (!raw->wait_wq) > return -ENOMEM; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel