From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05480C77B75 for ; Fri, 21 Apr 2023 11:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W9Jh3zsQniE65izl2dDMp4O4N+6VTgsRd3wS6YB8bBk=; b=Plp3SdLz0cO8hG zJGhTpZcGL/XllyV62ovDUfEwymXdO+77NRPOr4GcyH5j/AzJrkFWDQcK5FesFbAp2XmsRv9rw3KJ 3kSKErgHhZZoRereFcUbTTG1T2ElQOMWLDYhqWxG9SRNvRFuewqfE4u5PG364TZo3W6gbFUOEMRqo IkFTWaNvnsdGDGf2yn8e7io2pdAHuxFxRDhkeNDy04UenIbZy+pD7pqDp3Inl81PfU4zuQUbropOg rrw7qLWdaZVmhOGgQ+K14Xu7oJ11z/r+yUX6ZQ4Eul7WUEQcEwJJawMjIExUreNdlFQM6bmjAPNgZ ZkLyWrQfF74sOiIEqnYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppp8J-00AkKn-2l; Fri, 21 Apr 2023 11:40:56 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppp85-00AkFg-1X for linux-arm-kernel@bombadil.infradead.org; Fri, 21 Apr 2023 11:40:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xau41le5G51Q2FJa0E+OtCHdGIJomGv6o0iGgjNIq6s=; b=Q9mMCT0itSchrG4MqJY9t3EPAT NlKzb+3eOMbU72VpXFobQMokUcZrzMtRhuzw6MVEz3vV/vIEW7wFQ7tY2+ioT1ZgcDc84gKULPcbJ cwwdrND6i6Dn8AAecOSfH+nNZNfDsEfyUALD40CjS8OkHI9JfeA2CPNAvyUnxoIPhBVLMdObY5uCG KxAc+6CKbi2d+jKK+G6ciW6+o61QLikalZw6Zxpe4poKsOjUznvVs9/lw7adi4+DZV++5hDNWdYZ3 7pgWW0dzuk3gt+SXe7IACigHAyZrWzYybC1RVGhJp6Y2sHBJN35CJBHdC3a+aiCLK7kQLrNcTdcwq FnpHioBg==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppnEI-005FE5-2S for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2023 09:39:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C95871480; Fri, 21 Apr 2023 02:39:37 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2658C3F5A1; Fri, 21 Apr 2023 02:38:53 -0700 (PDT) Date: Fri, 21 Apr 2023 10:38:49 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Tejun Heo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation Message-ID: References: <20230421092742.jjr4gnkswj22yt76@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230421092742.jjr4gnkswj22yt76@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_103901_184198_BAE5B0EC X-CRM114-Status: GOOD ( 16.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 21, 2023 at 10:27:42AM +0100, Sudeep Holla wrote: > On Fri, Apr 21, 2023 at 09:46:11AM +0100, Cristian Marussi wrote: > > On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote: > > > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active. > > > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs > > > interface and using 0 for @max_active for the default setting. > > > > > Thanks, good catch, very hard to notice. Indeed :< > > > > > Hi Tejun, > > > > my bad I messed up the params in the call. > > > > Hi Cristian, > > I think it deserves the fixes tag, right ? > > Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support") > I though so, but as usual I am not sure what to do when we are fixing something in the middle of a cycle... Raw support went in v6.3-rc1 and we are now in v6.3-rc7, so if you want to pick this up now (as it seems the case) it will fix the above yes, but it is anyway still on an unreleased kernel...so nothing really to have to apply on any early stable kernels...buh..I dont know what is the rule, but the Fix tag seems harmless ... so why not :D Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel