mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Sudip Mukherjee (Codethink)]

Hi All,

The latest mainline kernel branch fails to build xtensa, mips, arm allmodconfig
with the error:

drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_inbuf':
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:33:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
   33 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_outbuf':
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:51:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
   51 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:66:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
   66 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

git bisect pointed to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

I will be happy to test any patch or provide any extra log if needed.


-- 
Regards
Sudip


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Sudip Mukherjee]

On Wed, 26 Apr 2023 at 18:07, Sudip Mukherjee (Codethink)
<sudipm.mukherjee@gmail.com> wrote:
>
> Hi All,
>
> The latest mainline kernel branch fails to build xtensa, mips, arm allmodconfig
> with the error:
>
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_inbuf':
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:33:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
>    33 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_outbuf':
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:51:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
>    51 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:66:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
>    66 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> git bisect pointed to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

Also, riscv allmodconfig with the error:

drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c:328:12: error:
'mxc_isi_pm_resume' defined but not used [-Werror=unused-function]
  328 | static int mxc_isi_pm_resume(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c:314:12: error:
'mxc_isi_pm_suspend' defined but not used [-Werror=unused-function]
  314 | static int mxc_isi_pm_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~


-- 
Regards
Sudip

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Laurent Pinchart]

Hi Sudip,

On Wed, Apr 26, 2023 at 06:07:34PM +0100, Sudip Mukherjee (Codethink) wrote:
> Hi All,
> 
> The latest mainline kernel branch fails to build xtensa, mips, arm allmodconfig
> with the error:
> 
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_inbuf':
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:33:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
>    33 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_outbuf':
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:51:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
>    51 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:66:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
>    66 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> git bisect pointed to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
> 
> I will be happy to test any patch or provide any extra log if needed.

This issue has been fixed already, the fixes are available in the master
branch of git://linuxtv.org/media_stage.git:

e49b1e1958b4 media: nxp: ignore unused suspend operations
9829ed20b019 media: nxp: imx8-isi: fix buiding on 32-bit

Mauro, can you please include those two fixes in your next pull request
for v6.4 ?

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Mauro Carvalho Chehab]

Em Mon, 15 May 2023 09:46:41 +0200
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:

> Hi Krzysztof,
> 
> On Sun, May 14, 2023 at 1:01 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On 10/05/2023 10:05, Mauro Carvalho Chehab wrote:  
> > > And another CI job testing bisect breakages as I receive pull requests,
> > > applying patch per patch and using both allyesconfig and allmodconfig,
> > > also on x86_64 arch with W=1:
> > >
> > >       https://builder.linuxtv.org/job/patchwork/
> > >
> > > The rule is to not merge stuff on media tree if any of those jobs
> > > fail. I also fast-forward merging patches whose subject states that
> > > the build has failed.
> > >
> > > In order to help with that, on normal situation, I usually take one week
> > > to merge stuff from media_stage into media_tree, doing rebases at
> > > media_stage if needed to avoid git bisect build breakages at media_tree
> > > (which is from where I send my update PRs to you).
> > >
> > > Unfortunately, currently we don't have resources to do multiple randconfig  
> >
> > Is you media staging tree included in LKP (kernel test robot)? You would
> > get huge build coverage after every push to your staging repo.  

No idea, as I don't know where LKP settings are stored, nor what frequency
it is doing builds from git://linuxtv.org/media_stage.git, if any. Do you know
where we can check such configuration?

In the end, patches there will end going to linux-next, so at least some
sort of coverage is there, but I'm not sure if LKP will always reply to
linux-media if the patch causing build regressions is there.

While being helpful, one problem with LKP is that it is hard to filter out 
reports per git tree. The only way to check if the report is applicable to
media trees seems to be looking inside the e-mail's body.

> As (multiple[*[) fixes for the build issues were submitted before the
> opening of the merge window, there must have been some build coverage,
> with even some people acting upon it...
> 
> [*] General note, not limited to media: please apply build fixes and
>     regression fixes ASAP, to avoid multiple people running into the
>     same issues, and spending time on bisecting, investigating,
>     fixing, ...
>     Thanks a lot!

Fully agreed. That's why we opted to have a CI instance focused on media:
we should be able to program it to give feedback with the kernel build
parameters we use (Like W=1) and set it up in a way that it we can
customize to our needs (like testing for the architectures where media
drivers are known to be used in practice), and setting up an e-mail subject
that can be easily be filtered by our e-mail filters.

Regards,
Mauro

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Krzysztof Kozlowski]

On 15/05/2023 11:25, Mauro Carvalho Chehab wrote:
> Em Mon, 15 May 2023 09:46:41 +0200
> Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> 
>> Hi Krzysztof,
>>
>> On Sun, May 14, 2023 at 1:01 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> On 10/05/2023 10:05, Mauro Carvalho Chehab wrote:  
>>>> And another CI job testing bisect breakages as I receive pull requests,
>>>> applying patch per patch and using both allyesconfig and allmodconfig,
>>>> also on x86_64 arch with W=1:
>>>>
>>>>       https://builder.linuxtv.org/job/patchwork/
>>>>
>>>> The rule is to not merge stuff on media tree if any of those jobs
>>>> fail. I also fast-forward merging patches whose subject states that
>>>> the build has failed.
>>>>
>>>> In order to help with that, on normal situation, I usually take one week
>>>> to merge stuff from media_stage into media_tree, doing rebases at
>>>> media_stage if needed to avoid git bisect build breakages at media_tree
>>>> (which is from where I send my update PRs to you).
>>>>
>>>> Unfortunately, currently we don't have resources to do multiple randconfig  
>>>
>>> Is you media staging tree included in LKP (kernel test robot)? You would
>>> get huge build coverage after every push to your staging repo.  
> 
> No idea, as I don't know where LKP settings are stored, nor what frequency
> it is doing builds from git://linuxtv.org/media_stage.git, if any. Do you know
> where we can check such configuration?

AFAIR, it checks all kernel.org repos, but anything outside should be
manually added. See:
https://github.com/intel/lkp-tests/pull/271

I actually proposed a talk around this for LPC, so it seems it might be
useful.

> 
> In the end, patches there will end going to linux-next, so at least some
> sort of coverage is there, but I'm not sure if LKP will always reply to
> linux-media if the patch causing build regressions is there.
> 
> While being helpful, one problem with LKP is that it is hard to filter out 
> reports per git tree. The only way to check if the report is applicable to
> media trees seems to be looking inside the e-mail's body.

If you setup specific repo entry in LKP, you will get a quite specific
email, e.g. with subject:

[krzk:for-next] BUILD SUCCESS 5b248db78d1aa679009efa4763794890572e63fb
[krzk-github:n/of-device-id-of-match-ptr-rebase] BUILD SUCCESS ce0964f4

(where krzk/krzk-github are the names of repos in LKP)


Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Thorsten Leemhuis]

On 15.05.23 09:46, Geert Uytterhoeven wrote:
> On Sun, May 14, 2023 at 1:01 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 10/05/2023 10:05, Mauro Carvalho Chehab wrote:
>>> And another CI job testing bisect breakages as I receive pull requests,
>>> applying patch per patch and using both allyesconfig and allmodconfig,
>>> also on x86_64 arch with W=1:
>>>
>>>       https://builder.linuxtv.org/job/patchwork/
>>>
>>> The rule is to not merge stuff on media tree if any of those jobs
>>> fail. I also fast-forward merging patches whose subject states that
>>> the build has failed.
>>>
>>> In order to help with that, on normal situation, I usually take one week
>>> to merge stuff from media_stage into media_tree, doing rebases at
>>> media_stage if needed to avoid git bisect build breakages at media_tree
>>> (which is from where I send my update PRs to you).
>>>
>>> Unfortunately, currently we don't have resources to do multiple randconfig
>>
>> Is you media staging tree included in LKP (kernel test robot)? You would
>> get huge build coverage after every push to your staging repo.
> 
> As (multiple[*[) fixes for the build issues were submitted before the
> opening of the merge window, there must have been some build coverage,
> with even some people acting upon it...
> 
> [*] General note, not limited to media: please apply build fixes and
>     regression fixes ASAP, to avoid multiple people running into the
>     same issues, and spending time on bisecting, investigating,
>     fixing, ...
>     Thanks a lot!

FWIW, I proposed a rewritten section of
Documentation/process/handling-regressions.rst that is closely related
to this. The new text says:

```
+ * Do not consider regressions from the current cycle as something that
can wait
+   till the end of the cycle, as the issue might discourage or prevent
users and
+   CI systems from testing mainline now or generally.
[...]
+ * Aim to mainline a fix within two or three days, if the issue is
severe or
+   bothering many users -- either in general or in prevalent conditions
like a
+   particular hardware environment, distribution, or stable/longterm
series.```

For details and context see
https://lore.kernel.org/linux-doc/6971680941a5b7b9cb0c2839c75b5cc4ddb2d162.1684139586.git.linux@leemhuis.info/

Let me known if you think I should be more explicit; I could simply add
a "this includes, but is not limited to fixes for build errors" to the
second segment mentioned above. But well, that yet again would make the
text longer. :-(

Ciao, Thorsten

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Nicolas Dufresne]

Hi,

Le lundi 08 mai 2023 à 09:27 -0700, Linus Torvalds a écrit :
> End result: you and the media tree is on my shit-list, and I will not
> take any pull requests from you that aren't just fixes.
> 
> Not just this release, but the next one.

I'm expected to be flamed for getting in the way, but whatever. To me this
decision lacks any kind of consideration toward who will be affected. This will
hit those that makes the new features and are working hard to convince their
customers to go mainline first. None of Mauro or Hans will truly be affected by
this. Everyone affected by this decision were completely unaware of the problem
in the first place and could not help it.

Punishment and shame is not something I encourage or think is nice in general.
Its the reflection of a strong frustration and the spontaneous need to hit
somewhere it hurts. It brings no benefit to anyone and likely convince the
skeptical to go away. In the end, it is the leaf contributors (the one that have
the least authority on the project) that takes the hit, having to tell their
customers they'll only get their stuff mainline in 6.7 even though they might
have done everything right to get things on time for the next window. This kind
of methods is purely negative for everyone, there is no win of any sort.

regards,
Nicolas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

[Linus Torvalds]

On Thu, May 18, 2023 at 12:53 PM Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>
> I'm expected to be flamed for getting in the way, but whatever. To me this
> decision lacks any kind of consideration toward who will be affected. This will
> hit those that makes the new features and are working hard to convince their
> customers to go mainline first.

I think the solution may be for those affected people to help Mauro & co.

Clearly the media maintenance doesn't have enough time. I'm not going
to pull from a tree where I know that it then may take six *weeks* and
one whole release for simple bugs to be fixed.

That is literally what happened. And if it had been once, that would
be one thing. But when the same thing starts happening again the very
next release, it's no longer a one-off. It's a pattern.

> Punishment and shame is not something I encourage or think is nice in general.

This is NOT about punishment.,

It's very simple: if I cannot trust the tree to be maintained, I'm not
going to pull it.

That's not punishment, that is simply about kernel maintenance.

If you want to help fix the media maintenance issue, then by all means
help. But as things are now, if I cannot rely on the media tree
getting even simple build fixes in a timely manner, then I'm not
pulling it.

Please realize: to misquote Shakespeare, I have two options: to pull
or not to pull. And in order to pull a tree, I need to know that I can
expect any problems from that pull to be fixed.

Would you expect me to pull known-buggy trees? I sure hope you don't
expect that. Not pulling buggy trees isn't "punishment". It's the only
sane thing to do.

And the exact same thing is true when a tree isn't maintained
properly. Bugs happen. That's inevitable. And sometimes bugs can be
hard to find, or hard to fix. But when the maintainer has been sent a
fix, and that fix doesn't get handled for SIX WEEKS, then that tree is
buggy.

Something is very rotten in the state of media. It needs to get fixed.
Until it is fixed, I don't want to take random new code.

The fix *may* be as simple as more testing, and better automation. But
really, the thing that annoyed me enormously was that these bugs were
all found by automation and testing. And still they were left to rot.

                 Linus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel