From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71A2FC77B61 for ; Fri, 28 Apr 2023 10:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xwUm+3XVjuGrSwxOsMjdFAcd9gHIzGsYGeGMbUPHOYY=; b=xoM0SWezl4B/93 yld89K9T5cKy4OBwAH06MPlmFkt0BeccQZaHfWDND5465g2kIYBeFMiYeuAcW6z4cUcby7nGLIuZD x2xdajEufln96RNi1KrCJX4AILLg7UPsxlxKfG3V9EiRzIgf5c2wY1H51sronZBfseWjxvz6xpGZv Fzv5m3mwWwl2/JiMge+fbamGcGtfvaN79TvGK7f/V2bwCWE2WJMXYohYyI8gsXvr5wyf8VE9EioIl mtG9kIiCEAst+TlETk4SGgOIo9biTuR0ZcVOSkO9YWTMlruEAna8BePKkiHF7DK0vXfDQ65lpLRjS VugIiumWtiI+7Wa/FMNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1psLUw-008plU-0g; Fri, 28 Apr 2023 10:38:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1psLUL-008pH2-0P for linux-arm-kernel@lists.infradead.org; Fri, 28 Apr 2023 10:38:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6F0BC14; Fri, 28 Apr 2023 03:38:40 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.21.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4BE0C3F64C; Fri, 28 Apr 2023 03:37:55 -0700 (PDT) Date: Fri, 28 Apr 2023 11:37:49 +0100 From: Mark Rutland To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Marc Zyngier , Ryan Roberts , Anshuman Khandual , Kees Cook Subject: Re: [PATCH v3 01/60] arm64: kernel: Disable latent_entropy GCC plugin in early C runtime Message-ID: References: <20230307140522.2311461-1-ardb@kernel.org> <20230307140522.2311461-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230307140522.2311461-2-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230428_033805_344121_6EBF8D2F X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 07, 2023 at 03:04:23PM +0100, Ard Biesheuvel wrote: > Avoid build issues in the early C code related to the latent_entropy GCC > plugin, by incorporating the C flags fragment that disables it. > > Signed-off-by: Ard Biesheuvel Just to check, are you seeing issues today? IIUC the plugin only instruments functions which are explicitly marked with __latent_entropy, and if we're seeing that happen unexpectedly (or due to that being applying to __meminit / __init), we might need to do likewise for other noinstr code. Regardless, for this patch: Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/pi/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/pi/Makefile b/arch/arm64/kernel/pi/Makefile > index 4c0ea3cd4ea406b6..c844a0546d7f0e62 100644 > --- a/arch/arm64/kernel/pi/Makefile > +++ b/arch/arm64/kernel/pi/Makefile > @@ -3,6 +3,7 @@ > > KBUILD_CFLAGS := $(subst $(CC_FLAGS_FTRACE),,$(KBUILD_CFLAGS)) -fpie \ > -Os -DDISABLE_BRANCH_PROFILING $(DISABLE_STACKLEAK_PLUGIN) \ > + $(DISABLE_LATENT_ENTROPY_PLUGIN) \ > $(call cc-option,-mbranch-protection=none) \ > -I$(srctree)/scripts/dtc/libfdt -fno-stack-protector \ > -include $(srctree)/include/linux/hidden.h \ > -- > 2.39.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel