From: Catalin Marinas <catalin.marinas@arm.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Justin Forbes <jforbes@fedoraproject.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jmforbes@linuxtx.org,
Andrew Morton <akpm@linux-foundation.org>,
lkp@intel.com
Subject: Re: [PATCH] Revert arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER
Date: Wed, 3 May 2023 11:20:40 +0100 [thread overview]
Message-ID: <ZFI1eK5JmwIdL1eq@arm.com> (raw)
In-Reply-To: <ZFFK/qPTCIpGE2Tu@arm.com>
On Tue, May 02, 2023 at 06:40:14PM +0100, Catalin Marinas wrote:
> On Tue, May 02, 2023 at 07:15:20PM +0300, Mike Rapoport wrote:
> > On Tue, May 02, 2023 at 03:07:41PM +0100, Catalin Marinas wrote:
> > > On Mon, May 01, 2023 at 04:24:38PM -0500, Justin Forbes wrote:
> > >
> > > Regarding EXPERT, we could drop it and do like the other architectures
> > > but we'll have randconfig occasionally hitting weird values that won't
> > > build (like -1). Not sure EXPERT helps here.
> >
> > AFAIU, randconfig does not randomize int values, it's probably random
> > people that do ;-)
>
> https://lore.kernel.org/r/202303232149.Chh6KhiI-lkp@intel.com
>
> with the randconfig here:
>
> https://download.01.org/0day-ci/archive/20230323/202303232149.Chh6KhiI-lkp@intel.com/config
You may be right, I can't get my randconfig to set ARCH_FORCE_MAX_ORDER
to anything other than the default. Maybe the kernel test robot has its
own config randomisation (cc'ing lkp@intel.com).
If we don't care about about this randconfig, I'm fine do drop EXPERT
from current mainline, together with the 4K/16K pages condition. The
condition only made sense if we kept the ranges in since these were
configurable (no range for 64K).
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index b1201d25a8a4..1867aba83ba3 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -1516,7 +1516,7 @@ config XEN
# 16K | 27 | 14 | 13 | 11 |
# 64K | 29 | 16 | 13 | 13 |
config ARCH_FORCE_MAX_ORDER
- int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES)
+ int "Order of maximal physically contiguous allocations"
default "13" if ARM64_64K_PAGES
default "11" if ARM64_16K_PAGES
default "10"
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-03 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 15:36 [PATCH] Revert arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER Justin M. Forbes
2023-04-28 17:01 ` Catalin Marinas
2023-04-29 19:01 ` Mike Rapoport
2023-04-29 22:42 ` Justin Forbes
2023-04-30 3:54 ` Mike Rapoport
2023-05-01 21:24 ` Justin Forbes
2023-05-02 14:07 ` Catalin Marinas
2023-05-02 14:21 ` Marc Zyngier
2023-05-02 16:12 ` Mike Rapoport
2023-05-02 16:15 ` Mike Rapoport
2023-05-02 17:40 ` Catalin Marinas
2023-05-03 10:20 ` Catalin Marinas [this message]
2023-05-03 12:08 ` Philip Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFI1eK5JmwIdL1eq@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=jforbes@fedoraproject.org \
--cc=jmforbes@linuxtx.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rppt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).