From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E785C77B78 for ; Wed, 3 May 2023 10:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Zx3GU5vA5EIoeLbdStPYC1I0o8ph9+Njy67VFjlVAc=; b=04t8K++S5CIMQb pEgS7/R76h21YzNG+xCaGpcWfW6v4g7nxFITB9uCg8LNcwZdQaw+PNJk6aJsTmV750oHiD8rOsJfd kpVHq8E1djqoJAT2WUgthRW6AMpotLf+sNhBM5Yl7v0AHE0L+cF36IyFiiyInFiX6TtWs7Yjfo23a 6qG6mbOOeNQPjahUwrNyHCuSE/EdDzFA43ooTnL/eO7F6oX1dGzJyuyrJhLysr4BbzmuXyYljmDny rA83tOQ7D2GDIjAtGyWXvswagIC1UXPadwSZ/zCiBQ58zqQNTS3q8LoNvrPzGKEAcg5nWFm38rv5t dMZocI58NOTJfOKy21KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pu9bN-0047D3-0z; Wed, 03 May 2023 10:20:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pu9bJ-0047Ba-2h for linux-arm-kernel@lists.infradead.org; Wed, 03 May 2023 10:20:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AA0D62C0C; Wed, 3 May 2023 10:20:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 593B1C4339B; Wed, 3 May 2023 10:20:43 +0000 (UTC) Date: Wed, 3 May 2023 11:20:40 +0100 From: Catalin Marinas To: Mike Rapoport Cc: Justin Forbes , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jmforbes@linuxtx.org, Andrew Morton , lkp@intel.com Subject: Re: [PATCH] Revert arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER Message-ID: References: <20230428153646.823736-1-jforbes@fedoraproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230503_032045_912839_2A98E354 X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 02, 2023 at 06:40:14PM +0100, Catalin Marinas wrote: > On Tue, May 02, 2023 at 07:15:20PM +0300, Mike Rapoport wrote: > > On Tue, May 02, 2023 at 03:07:41PM +0100, Catalin Marinas wrote: > > > On Mon, May 01, 2023 at 04:24:38PM -0500, Justin Forbes wrote: > > > > > > Regarding EXPERT, we could drop it and do like the other architectures > > > but we'll have randconfig occasionally hitting weird values that won't > > > build (like -1). Not sure EXPERT helps here. > > > > AFAIU, randconfig does not randomize int values, it's probably random > > people that do ;-) > > https://lore.kernel.org/r/202303232149.Chh6KhiI-lkp@intel.com > > with the randconfig here: > > https://download.01.org/0day-ci/archive/20230323/202303232149.Chh6KhiI-lkp@intel.com/config You may be right, I can't get my randconfig to set ARCH_FORCE_MAX_ORDER to anything other than the default. Maybe the kernel test robot has its own config randomisation (cc'ing lkp@intel.com). If we don't care about about this randconfig, I'm fine do drop EXPERT from current mainline, together with the 4K/16K pages condition. The condition only made sense if we kept the ranges in since these were configurable (no range for 64K). diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index b1201d25a8a4..1867aba83ba3 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1516,7 +1516,7 @@ config XEN # 16K | 27 | 14 | 13 | 11 | # 64K | 29 | 16 | 13 | 13 | config ARCH_FORCE_MAX_ORDER - int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES) + int "Order of maximal physically contiguous allocations" default "13" if ARM64_64K_PAGES default "11" if ARM64_16K_PAGES default "10" -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel