From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FD73C77B78 for ; Wed, 3 May 2023 14:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FpUpD7DmjXHQDJoLA3OU3tngq/Q6toZFaEsDf2MW/Yk=; b=tFll4UOsRhE0kS AfQqECrqvLaYQQHtqK0XhfQwuW9+CI4O1aE6vhMsdxnlWkLD2o4oTVqLayYvjqn4GXtl+w8hSelbe UBy455nV6ZPaqAHG8XwXF+YFX+tLc/30kXRr/H20EzNi/Wxeo7PBjNddonHh4Ta4BspGvvgxjFuGn oewK9Pkpcyks+S7clk3i4S9gmxf5LNw0XpgAYoAle51gDvMQzCgFhHkbmine3um3Fialhl6wknfMJ 2J5KLubdQjJunl0zCgnGTKDwUDToPGrA8yURExgRZDMVM2hHMe+tp70ZlAGd6l0VPXrDj9Jh0ddAh BPFUmn64G78KojwqNNtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puDwC-004tRh-2o; Wed, 03 May 2023 14:58:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puDwA-004tR2-04 for linux-arm-kernel@lists.infradead.org; Wed, 03 May 2023 14:58:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CE4E60F8F; Wed, 3 May 2023 14:58:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88F91C433EF; Wed, 3 May 2023 14:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683125912; bh=yJTzfht1r0HZQ8f00umAdlpUQ7Qe74hODldmHhfaB/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KIBVLmJjpCnPN6YJugUj4GqmjgjiBt0H5sSooE4iXo5AzrUwmiibu+ZY4dpp3JvO2 xzaz5xbweZiPNluV6KkpPmXZ9U9PUrDqk0SReciFe3LpRgxjDHu2XrnrFNSzxG9fRu kFrki270Cvh4IdaxKg7J0P4McUHrELbB/Hl2QLqJGI2Pac+UO3JR1ZoLz60pGvVXbn pEZvUiT/egXR4xEqVU4zSnVNRZf4fglT7RLRnCc/78jcFpU7Zg1kC3xtvajyVCGS0j qwiJLAjAnmhmPwmdYmpw9U9jOyEEPW253sy4OEkGDiB7Y8XBhY4Tf+24Yu8nmmBsh4 d/3a6wTCQBoqA== Date: Wed, 3 May 2023 17:58:24 +0300 From: Mike Rapoport To: Catalin Marinas Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, "Justin M . Forbes" , Andrew Morton Subject: Re: [PATCH] arm64: Make the ARCH_FORCE_MAX_ORDER config input prompt unconditional Message-ID: References: <20230503123342.90538-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230503123342.90538-1-catalin.marinas@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230503_075834_096469_4EB43BF8 X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 03, 2023 at 01:33:42PM +0100, Catalin Marinas wrote: > Commit 34affcd7577a ("arm64: drop ranges in definition of > ARCH_FORCE_MAX_ORDER") dropped the ranges from the config entry and > introduced an EXPERT condition on the input prompt instead. This change > may affect some distro kernels that change ARCH_FORCE_MAX_ORDER but do > not want to enable EXPERT. > > Drop EXPERT from the input prompt together with the (ARM64_4K_PAGES || > ARM64_16K_PAGES) condition as the latter no longer makes sense after the > ranges were removed. The latter makes all the page size configurations > consistent w.r.t. ARCH_FORCE_MAX_ORDER. > > Fixes: 34affcd7577a ("arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER") > Signed-off-by: Catalin Marinas > Reported-by: Justin M. Forbes > Cc: Will Deacon > Cc: Mike Rapoport > Cc: Andrew Morton Acked-by: Mike Rapoport (IBM) > --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index b1201d25a8a4..1867aba83ba3 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1516,7 +1516,7 @@ config XEN > # 16K | 27 | 14 | 13 | 11 | > # 64K | 29 | 16 | 13 | 13 | > config ARCH_FORCE_MAX_ORDER > - int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES) > + int "Order of maximal physically contiguous allocations" > default "13" if ARM64_64K_PAGES > default "11" if ARM64_16K_PAGES > default "10" -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel