From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36D0AC77B7D for ; Fri, 5 May 2023 10:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QOkTX6+992cizS6QwWimPAAA1aDsiq5hGWFhscbYEgM=; b=jh2dQYeTwXYerr jZsH7u22eB8x8jJezsES+xmwIiYmx2cxi08Qdaq1eyJrf92+EFLRloF+FHP3ELdiBiqhFqvzShw9c q4HybaiFjXSuCRDpwD2y/9EpHY20xSB1U1OD+6Ka5UfONU5Ln3nmZMnG3wq5nRyyz2/Edv5wMaUfk YjRLmBW5C24swGqvj2mv7G2lq8iMprlcPFnejf+T7ks3slo3m1nXlbuyITJPUszPnm0vjebPzon30 v4WunWfoo3mN92SsKRuXXB8IE6TYRjplQUnMusO4t0dg7KbuanTCpMLOo8DqOnTARaHTh8SaQZlVZ bCgxs/4OSguJDiRvpRlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pushV-00AIN4-2Q; Fri, 05 May 2023 10:30:09 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pushR-00AIIm-2m for linux-arm-kernel@lists.infradead.org; Fri, 05 May 2023 10:30:08 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-957dbae98b4so241302466b.1 for ; Fri, 05 May 2023 03:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1683282601; x=1685874601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0zEEWPURLzLc29PpkMvuHfunPeqWFI4LDFz37TVYXgU=; b=TaYWMqZ64NSjIM+PaA0/SXNmCwqfyHcIofKucfNO5CeMwj4vhFc1K9qdgN3r7dRor9 or7s134yj186lmBh3mtJkpfPPCK6mRY8xORPV3j0Pd1VPZndsb0TETGxBJ25z4f66AWM sVf8sug73c4OrJT+0VmMoM7SrXuvmUGnglH3S4JGnzyi7HmqC5UBPvesDr/Al5G0VYkv l1Ulwe6bModaCiZsKkUhCKqHv6CYkZzIy0XIGz2i0sKDdfVnpd3zXIW1fpJIQ/H49PRu yuBoaLWT4Qpr1UQarPFYqGeCGSp6GpEiZV87x6ElOFKm0iEQOBmqySX2k+t175ZQtpln Q9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683282601; x=1685874601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0zEEWPURLzLc29PpkMvuHfunPeqWFI4LDFz37TVYXgU=; b=GjybGl3ge8GLe2JOK8k0tWoZdy2oM/LLbQXb0ArSNsV/J4bi6geNIcUJS0926lZb9R 2qQscs5FzdnygQ81gr+TfFDuv1RAdlRRdVH2f9MUI7R6Vq6nCX+fjOPPJn4FBzdd9qAS HA2d881Apz3KNnJtR1D1Irb0enMRfATFKY0iDXMpkGOIDBXmhdV2g9YK+bqahZ83CGq6 36dxe5GfwP6LpqDp9kGT/lvgt6ww+6BeoTwx8Qg5iknCW4V9od87dV4N6dpCldgQIxDC dqykOh5oicoV4ZBuFcg5NBO3lZQQIVSfhJWNGKAmI3BUAMGRQz2GC+5RfCWjODYtKLEc EtKQ== X-Gm-Message-State: AC+VfDyvAdtywYjryDhnfkOzUGy2I9V5nIYTk97yP3QCvC1Mjil8K9z5 xhEKAKMg5MTWdvVAorVgiRwTfw== X-Google-Smtp-Source: ACHHUZ4rVSFml9uF2WLr4fy3Jcja4p2LW0wH4xEM6OmdQqrd1zxMgn0clzkh5apQnyrsTv6dOorCEQ== X-Received: by 2002:a17:907:7b92:b0:94e:edf3:dccd with SMTP id ne18-20020a1709077b9200b0094eedf3dccdmr929797ejc.0.1683282601306; Fri, 05 May 2023 03:30:01 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id hf27-20020a1709072c5b00b00965ddf2e221sm708829ejc.93.2023.05.05.03.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 03:30:00 -0700 (PDT) Date: Fri, 5 May 2023 12:29:59 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Vadim Fedorenko Subject: Re: [RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-2-vadfed@meta.com> <20230504142451.4828bbb5@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230504142451.4828bbb5@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_033006_131094_E74D86BB X-CRM114-Status: UNSURE ( 8.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thu, May 04, 2023 at 11:24:51PM CEST, kuba@kernel.org wrote: >On Thu, 4 May 2023 14:02:30 +0200 Jiri Pirko wrote: [...] > >> >+ name: device >> >+ subset-of: dpll >> >+ attributes: >> >+ - >> >+ name: id >> >+ type: u32 >> >+ value: 2 >> >+ - >> >+ name: dev-name >> >+ type: string >> >+ - >> >+ name: bus-name >> >+ type: string >> >+ - >> >+ name: mode >> >+ type: u8 >> >+ enum: mode >> >+ - >> >+ name: mode-supported >> >+ type: u8 >> >+ enum: mode >> >+ multi-attr: true >> >+ - >> >+ name: lock-status >> >+ type: u8 >> >+ enum: lock-status >> >+ - >> >+ name: temp >> >+ type: s32 >> >+ - >> >+ name: clock-id >> >+ type: u64 >> >+ - >> >+ name: type >> >+ type: u8 >> >+ enum: type >> >+ - >> >+ name: pin-prio >> >+ type: u32 >> >+ value: 19 >> >> Do you still need to pass values for a subset? That is odd. Well, I >> think is is odd to pass anything other than names in subset definition, >> the rest of the info is in the original attribute set definition, >> isn't it? >> Jakub? > >Probably stale code, related bug was fixed in YNL a few months back. >Explicit value should no longer be needed. What about the rest, like type, enum, multi-attr etc. Are they needed for subset? If yes, why? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel