From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDE40C77B7C for ; Fri, 5 May 2023 10:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sIshKOCVnpoktgTeh1Liq+gAKIa/zDtlrLw1SjyItfw=; b=TwJbvfEW5X2MR3 MZ6+cQs+y2L3v0EEalanGJFWKQ572bJ8xO38ZnKhpF3aVrECUmhuaGd9JwUUTGyl8c6OqBe8yLfp4 uyFQ8bjiD9cqQucgYuOiiMV5OY4Sy0miMAVwTZBhCtEgkjqtaoKJw3MwF4HjN15K5DmCK1Ujk9ymk WlYuf+my4LR9wY9usRmJl9ax6GHMRNmLUOdM0KRYZ571HR3NR8kbXPh+dXcMFi0es+wR4HHf+bPJt fwSMGZg1wUZDe7kwMyx4xUSgECCQT1G/ZanYlzVNlZY4riBUDWLgtSVv959H47HXdot7lKprCqjen pGqX4SIs1ZeyHXv8qKdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pusjd-00AJfH-38; Fri, 05 May 2023 10:32:21 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pusjb-00AJbX-0c for linux-arm-kernel@lists.infradead.org; Fri, 05 May 2023 10:32:20 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-50bc4b88998so2722980a12.3 for ; Fri, 05 May 2023 03:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1683282734; x=1685874734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oqFM0dfkiOziqgm+y7EAdXu3SisD+1/na/JyXA0Db3s=; b=NQZWiOt0UJlZjfg3GJnTv8hNzqx+Nl7N072M4bTaZxs0xwR0Yf7ZsNZ4lJOlNfNDT7 tAM3IidgUlachT+I6uvo+sFy/kMTy4CK4kukqyLPIxM+4fNh6qP+GdbKDMu/oZh/a6qx UFwyD9deiM0sw3nx+TM0ukDI3KvNWNazhdaRacEp3YbYfQKLYoOkNL+2c02960OWlZa4 v1wl7PnHnmRMcL/+zpccmr8m9ef2nHaEwHGPx5fMOA2aVjLtWhJyIX+sgEHtfAkADg7z jfXRcxJZYna4QCHkG+bmOZM1W4qv++/IHR1xYL6PO6xpRHk1cBF4ttlvVaugTUBYdLDg zOkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683282734; x=1685874734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oqFM0dfkiOziqgm+y7EAdXu3SisD+1/na/JyXA0Db3s=; b=RVp6Nad/ZTfoxl6yWZ+KzCt/Df0RIeMgj1tfNjAKBBShJSsu/uox9Hg3zN5hMX92sP +kmHPnYlcke2SMhzStogNf3Fg64XhMBHTCSO0605nuayrhSHpqhK6nlxL7hIDjAGjEBp oxPpKEdZ2+Wxksh4QtH8T+yJpXOGTKkiYZ0cdkg6JZKJ8q6DC8cb4F25RFx+080tnzFP lKim9j2VorKij+Of+u0/yfNhNLUnXf3j2XGBhks26DcEBl0pd9C+CCy65CedN5U+e94H QwMd0lepG2m7NIHGPsIMz9k+S1VOrHIO7roikBf1Nyo47QP+ujrDYoTRuY88KlX6BDo4 G/Ew== X-Gm-Message-State: AC+VfDwS/cA/9zXZFXqCd1RkqRz5lMfBLk9u2PKCtcoGH5omLcWeQ7WB rsCAHGi5k70HIdWLdF3ztLSTCA== X-Google-Smtp-Source: ACHHUZ4pZ9j/Mdczi1SYO7f5/FVFXb5vlqeJq2kBdYMCcTQvfFJrB/MTmDxvlObDskpJSZp8Qu6MUQ== X-Received: by 2002:a17:907:7204:b0:94f:2bd0:4780 with SMTP id dr4-20020a170907720400b0094f2bd04780mr725346ejc.58.1683282733904; Fri, 05 May 2023 03:32:13 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id de5-20020a1709069bc500b0094ef96a6564sm772766ejc.75.2023.05.05.03.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 03:32:13 -0700 (PDT) Date: Fri, 5 May 2023 12:32:12 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, Jiri Pirko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v7 7/8] netdev: expose DPLL pin handle for netdevice Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-8-vadfed@meta.com> <20230504133140.06ab37d0@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230504133140.06ab37d0@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_033219_229186_908B6A41 X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thu, May 04, 2023 at 10:31:40PM CEST, kuba@kernel.org wrote: >On Thu, 27 Apr 2023 17:20:08 -0700 Vadim Fedorenko wrote: >> @@ -2411,6 +2412,10 @@ struct net_device { >> struct rtnl_hw_stats64 *offload_xstats_l3; >> >> struct devlink_port *devlink_port; >> + >> +#if IS_ENABLED(CONFIG_DPLL) >> + struct dpll_pin *dpll_pin; >> +#endif > >kdoc is missing. I'm guessing that one pin covers all current user >cases but we should clearly document on what this pin is, so that when >we extend the code to support multiple pins (in/out, per lane, idk) >we know which one this was.. ? Oh, yeah. Will do. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel