From: Jason Gunthorpe <jgg@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: joro@8bytes.org, will@kernel.org, catalin.marinas@arm.com,
jean-philippe@linaro.org, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com,
cohuck@redhat.com, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] iommu/dma: Clean up Kconfig
Date: Fri, 5 May 2023 11:50:00 -0300 [thread overview]
Message-ID: <ZFUXmH9vndGZFuPr@nvidia.com> (raw)
In-Reply-To: <2e33c8bc2b1bb478157b7964bfed976cb7466139.1660668998.git.robin.murphy@arm.com>
On Tue, Aug 16, 2022 at 06:28:03PM +0100, Robin Murphy wrote:
> Although iommu-dma is a per-architecture chonce, that is currently
> implemented in a rather haphazard way. Selecting from the arch Kconfig
> was the original logical approach, but is complicated by having to
> manage dependencies; conversely, selecting from drivers ends up hiding
> the architecture dependency *too* well. Instead, let's just have it
> enable itself automatically when IOMMU API support is enabled for the
> relevant architectures. It can't get much clearer than that.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/Kconfig | 1 -
> drivers/iommu/Kconfig | 3 +--
> drivers/iommu/amd/Kconfig | 1 -
> drivers/iommu/intel/Kconfig | 1 -
> 4 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 571cc234d0b3..59af600445c2 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -209,7 +209,6 @@ config ARM64
> select HAVE_KPROBES
> select HAVE_KRETPROBES
> select HAVE_GENERIC_VDSO
> - select IOMMU_DMA if IOMMU_SUPPORT
> select IRQ_DOMAIN
> select IRQ_FORCED_THREADING
> select KASAN_VMALLOC if KASAN
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index 5c5cb5bee8b6..1d99c2d984fb 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -137,7 +137,7 @@ config OF_IOMMU
>
> # IOMMU-agnostic DMA-mapping layer
> config IOMMU_DMA
> - bool
> + def_bool ARM64 || IA64 || X86
Robin, do you remember why you added IA64 here? What is the Itanimum
IOMMU driver?
Thanks,
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-05 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 17:28 [PATCH 0/3] iommu/dma: Some housekeeping Robin Murphy
2022-08-16 17:28 ` [PATCH 1/3] iommu/dma: Clean up Kconfig Robin Murphy
2022-09-02 18:15 ` Catalin Marinas
2023-05-05 14:50 ` Jason Gunthorpe [this message]
2023-05-05 14:53 ` Robin Murphy
2023-05-05 19:22 ` Jason Gunthorpe
2022-08-16 17:28 ` [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h Robin Murphy
2022-08-17 12:19 ` Marc Zyngier
2022-08-22 11:21 ` Christoph Hellwig
2022-08-22 12:55 ` Robin Murphy
2022-09-02 18:16 ` Catalin Marinas
2022-08-16 17:28 ` [PATCH 3/3] iommu/dma: Make header private Robin Murphy
2022-09-07 12:49 ` [PATCH 0/3] iommu/dma: Some housekeeping Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFUXmH9vndGZFuPr@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=cohuck@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sw0312.kim@samsung.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).