From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B0EC77B7C for ; Sun, 7 May 2023 07:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tJpDZcZWzg9JrX0Ylq9+F812sSFuP+OcYOG6j21qUbs=; b=hoIsR1aJyMHS0U IgfuDAHdN023PWY7U1NmStI7jiz3QCKegm4NdPMeP+mR9hrdHUEWIwIsEucnisz9Qaoo1Fg42qMAM FparMMYVmLLtYQAJ3Qm+7mPWvpJn2p/WX0/s9Xj+wK+eL8EAAB1mt+XmqVqast/T65d8U8DpL+sM4 E5YVNXIUY719hW1HaNIkN2dbQFQo3EDD4EmivEut/x5KrvRNSJevKkDMTuPmpCnCCHjEZgpy0iLyF WN9JRYvFmZKESueTjDs2YnN7PkwFtrGuHZHQs2P201mJ6GSh44yjYpVUPOrA7b+mgDQBtD++/XnTk aOIkM26gEAgK6CXVesmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvZHc-00FUA1-0A; Sun, 07 May 2023 07:58:16 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvZHY-00FU9A-1T for linux-arm-kernel@lists.infradead.org; Sun, 07 May 2023 07:58:15 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f192c23fffso21847765e9.3 for ; Sun, 07 May 2023 00:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1683446289; x=1686038289; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UB+NswfmVrXW5kaqHoy4lL5OJPXOFxZhDY7qp6RLj74=; b=LOcZ6gcb3WmoGZhlUvRdvhkG0HdLBbV+rTpcszpFfmkhh4MaWj0K279YU2/iIBzuh+ NDy10KrohOrMaKcXAvwkR1GkSeGqYqJWV9WBUaZFqNQtjmikC9Ff0xnO2aXyplOxq+Lr iLCofJpW4LsZBgUJ0+BehQlZ6BzKp6x9p3lsZd8S2z8jn5pjbhnP3vb26Ti18uihlT22 ZhgA0hfjv8PB1zVzodcLLFTJWsOQsN45lEMrYIAVs72YF4lIMxZamhS+H7UVkzkEniuf jsThpceT43jzsaBAqk55aqMQ1e19qCGWTbP+iw5u1d9FEMV2zwxnvHnQgTcif4nfeR6+ ATlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683446289; x=1686038289; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UB+NswfmVrXW5kaqHoy4lL5OJPXOFxZhDY7qp6RLj74=; b=IGByORBW/wVJPmcy6p2KG6F83k8hLYhK8vERMtuEpIytDIntPEYPCTIvPQzqbZGY/j zxIdoOp8T6OefrydKitjmRRc9mSoNUWDE18/fLnIfvkcAvBdV0cBWVWebdIjYS3wmH+g 5wB+DOftXL1HUHZj4G470Y0fOiWlYPaN2F+bM7YaOndKni/sOFGi0Qx4Nl7Je5EfA8gU QN5jyJ81K1hI25e9ONEQ+4vBVFBgrPXU3XXAhupPxOZMmHPgrS3GTBLAL7ZfqdFDvLjm i8bocet9LZXXWJtv8G+/mn3Q0SbWIn51hhCf9zQZMHEheLS9FaF7f/yDyzHT4G0GtPWd tFlQ== X-Gm-Message-State: AC+VfDxRAu+ZtX+Zj0cOGjlE6BDqWkctkU8bwvAjiUeVRu9lPpAi7Msd KLxVsIFWi9okIhI/QVtutvRtHA== X-Google-Smtp-Source: ACHHUZ6KPm680po8KAulMQOmJRdB0pu0NBqFPiwv1dL0DL6A0bBWRi6nVuVVPRzgU+WoOdHK72ouzg== X-Received: by 2002:a1c:ed03:0:b0:3ee:6d55:8b73 with SMTP id l3-20020a1ced03000000b003ee6d558b73mr4441022wmh.29.1683446288666; Sun, 07 May 2023 00:58:08 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id x16-20020a05600c21d000b003f318be9442sm13095502wmj.40.2023.05.07.00.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 00:58:07 -0700 (PDT) Date: Sun, 7 May 2023 09:58:06 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , poros , mschmidt , "netdev@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-clk@vger.kernel.org" , "Olech, Milena" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230502083244.19543d26@kernel.org> <20230503191643.12a6e559@kernel.org> <20230504090401.597a7a61@kernel.org> <20230504114421.51415018@kernel.org> <20230505083531.57966958@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230505083531.57966958@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230507_005812_724280_0E8E5DB2 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, May 05, 2023 at 05:35:31PM CEST, kuba@kernel.org wrote: >On Fri, 5 May 2023 12:41:11 +0200 Jiri Pirko wrote: >> >connector label (i.e. front panel label)? Or also applicable to >> >internal pins? It'd be easier to talk details if we had the user >> >facing documentation that ships with these products. >> >> I think is is use case specific. Some of the pins face the user over >> physical port, they it is a front panel label. Others are internal >> names. I have no clue how to define and mainly enforce rules here. > >It should be pretty easy to judge if we see the user-facing >documentation vendors have. Intel, Vadim, do you have such documentation? As I wrote, for mlx5 the label is not really applicable as the link netdev->pin is defining what the pin is. > >> But as an example, if you have 2 pins of the same type, only difference >> is they are connected to front panel connector "A" and "B", this is the >> label you have to pass to the ID query. Do you see any other way? > >Sound perfectly fine, if it's a front panel label, let's call >the attribute DPLL_A_PIN_FRONT_PANEL_LABEL. If the pin is not >brought out to the front panel it will not have this attr. >For other type of labels we should have different attributes. Hmm, that would kind of embed the pin type into attr which feels wrong. We already have the pin type exposed: enum dpll_pin_type { DPLL_PIN_TYPE_UNSPEC, DPLL_PIN_TYPE_MUX, DPLL_PIN_TYPE_EXT, DPLL_PIN_TYPE_SYNCE_ETH_PORT, DPLL_PIN_TYPE_INT_OSCILLATOR, DPLL_PIN_TYPE_GNSS, __DPLL_PIN_TYPE_MAX, DPLL_PIN_TYPE_MAX = (__DPLL_PIN_TYPE_MAX - 1) }; It case of front panel pin label, the type is "EXT" as for external pin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel