From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D13F9C77B7D for ; Mon, 15 May 2023 16:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0BgA3KN8BCvKVJhqSumN1Yj/5Sw1nKwiFVBHLRkK06U=; b=gNyKIzGAWI6DRv 1ib2DiSyrm2HCGUFfXtquzRBLfta12jNtj1cG265ADY+88Oa6fBj36tHthfTc8Y/2zOoZiykW3QaT q4iOAzdaqHFC4DGvzfGxbe2oFEEm0jIpp/8SZvz8lsPTQJVHb753exXIuDNQqtjveU5jeaLnCPIdN Z91N19940xZ1xMztrAW7VUGhunpP2F6QSax3MAQkl8pp3s3cStnU+IQ26CHr0cI6t/WY8V39u7xAf O9x1JW5DJaFUBeR+ejaT2VBvtE1LGlBLu/3AOA0wfk/spAGGKSAjkXBNPisNJSWriVSX9HGIuXSkO HBOu6i7dv3i6sWkhej1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyb6W-002lWU-0D; Mon, 15 May 2023 16:31:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyb6T-002lVG-2W for linux-arm-kernel@lists.infradead.org; Mon, 15 May 2023 16:31:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fxsy5xAAUzv2Oh3VqA6pEv9r2VtHDcvtmHDLXlIrWyA=; b=CeMauip17ebjTwhjUADA9Wxi6H nCCp6iZYYwtXTuYEg/9IbbJZG3L4GwFtCqfHG067VbBqe2JkQc1MhrddeTeOm1vemz93Ydwjb9c+M JCWuWcgtNyZnmxEn1l+utTvYY3l4jjNLkFqNToo/mhsdLzHXCfkbRXjnNYJ8dv8Nm+5C2Qw0rx8Fm 3W2YtIB49Ca0TWKen+DhguPsdQhey80zffiRpBU3OV4MAmYHOuRkuTlJZTf4MqpRLzOFIcrz0eWiW UqJwx46DWdyRAgphqg3qsovlcwxz2pVnNWVnRJdu6JxBJsgimr5G2rGUW4I3EfwGUggIDp3zR3IT5 wDoSeBqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41518) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pyb6I-00045b-Cr; Mon, 15 May 2023 17:31:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pyb6E-0008Ky-DO; Mon, 15 May 2023 17:31:02 +0100 Date: Mon, 15 May 2023 17:31:02 +0100 From: "Russell King (Oracle)" To: Andrew Davis Cc: Baruch Siach , Vladimir Zapolskiy , Kunihiko Hayashi , Masami Hiramatsu , Arnd Bergmann , Geert Uytterhoeven , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] ARM: mach-airoha: Rework support and directory structure Message-ID: References: <20230515160234.289631-1-afd@ti.com> <20230515160234.289631-6-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230515160234.289631-6-afd@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230515_093117_825747_21DFB2C8 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 15, 2023 at 11:02:30AM -0500, Andrew Davis wrote: > Having a platform need a mach-* directory should be seen as a negative, > it means the platform needs special non-standard handling. ARM64 support > does not allow mach-* directories at all. While we may not get to that > given all the non-standard architectures we support, we should still try > to get as close as we can and reduce the number of mach directories. > > The mach-airoha/ directory, and files within, provide just one "feature": > having the kernel print the machine name if the DTB does not also contain > a "model" string (which they always do). To reduce the number of mach-* > directories let's do without that feature and remove this directory. I'm guessing this is copy-n-pasted description. However: > -static const char * const airoha_board_dt_compat[] = { > - "airoha,en7523", > - NULL, > -}; > - > -DT_MACHINE_START(MEDIATEK_DT, "Airoha Cortex-A53 (Device Tree)") > - .dt_compat = airoha_board_dt_compat, > -MACHINE_END If this is actually used, then it will have the effect of providing a "machine" that has both l2c_aux_mask and l2c_aux_val as zero, whereas the default one has l2c_aux_mask set to ~0. This has the effect of _not_ calling l2x0_of_init() - but you don't mention this. You probably should, and you should probably state why that is safe (assuming you've even realised you've made this change!) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel