From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB283C77B7D for ; Mon, 15 May 2023 17:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ItqjUQsBzCJhDQGTP2Hxuo3qyo3gQYjpwc7INx2reGM=; b=LIizYT6PJgboti rimKfJ+gaSSmnUk69xf2jwb7Hnh3h7MauG3JdBp2VLLi4payegyb3kFkHjoTbTzZfaPRZ5OMPJJZK +AwYhFjTZd2JEQ3SML4nZBLlBBgyNCehiRca/iySchuE1EF7AEwGrezxHexWWv06UOLJLANCW658Y zDZhD//BzXY62isIRESh6kB43ZWN4WCAaoV4WkWeCbBuzqdcihElnryFHH9YipAXK8k4Es6gbYE4v bJx5xL3IsYVf28MjJvDjRPftrTn2GvSlNebNKoUQqGr9BEL1MQMDHq3Ni0O7gv+xAphP+yZI9OgCN s4e7ffldC2YEvI2RdTbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pybkV-002t4H-02; Mon, 15 May 2023 17:12:39 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pybkQ-002t3D-2W for linux-arm-kernel@lists.infradead.org; Mon, 15 May 2023 17:12:37 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f41d087bd3so66244375e9.3 for ; Mon, 15 May 2023 10:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1684170753; x=1686762753; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XXyT1LTgUSs+PYs2aHi9g7bS+bsT2Sf8immn5YPZM/I=; b=QXaaryjz7gwC2qtK8Rxrp/sFwaJKI3ptWp5sNVBMBl1umue/sdP+jMKlVLXkOfc4eV kZ3Zjwj8ZFp/OntulHkglOmTXUHDQOyRcKEYmeONsAXlsGIUKCH+Vs+KsmCDZK3Dg7pg 87jGPcnao+37dXgOl5FQkOwFCAjqtUMSqDwSvZulY34RgZXNlT9kIxd4hZ0aO771Or0x 6SdXx0F7WPjOrmbqHJrRTNP9aXCd7CdxR8WfMsBF1xaDBR19p2/FC4pmJYfEUZtu5aOZ 3ahoZ4p6G0195A+jDSrfoprWbUksEKCVnwqTEFBX12B+9nudqTFvSOLVcdq9PkxlPZUl 6u9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684170753; x=1686762753; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XXyT1LTgUSs+PYs2aHi9g7bS+bsT2Sf8immn5YPZM/I=; b=KtoOYFY3Q2u7wLIHYbNvEn6Xq6FLuQsjjClzE1DMVeU5bfRzBsVeqsHIZpc9In4xn6 g1eK3Gl/E8QyQi+qog7RF4Y+7OnxOvU+L83SKRCtaLPLkjmcfqvYcv/W8MlJatsy15eE H7tTLI7lrwdO0r+HDDPNljJmpXtX3h37MhBOMhEYwKHGBR6jnF90jcU0KQO0zr9nBzGt FK8SR0yv79TR6cA2AH5X/KfULhZNHk6HFpSyq+gNiaoidcv3EqHu3DAniEKwMtc/uWSU BRG/Z9KU4mlBFvQpQLDponU1gAR8XRMBdfVEBLYraZ7Y53TD/xpMkmcBuFmfYDulvFph ridg== X-Gm-Message-State: AC+VfDxp0egg+jFyF+zPb5acrI0d+0QDJ5dHARej4omQV68ZROnGhIba C6zGfnrCAR4dP86Ovc8im4ToKQ== X-Google-Smtp-Source: ACHHUZ4eMhIwBT7w1XF/fJHFKfPz/0uLX5aoUDa0kGf78PzmiGLWIUCUXXJ0QmARz8UDaF7I7TctZw== X-Received: by 2002:a7b:c8c6:0:b0:3f4:2220:28d5 with SMTP id f6-20020a7bc8c6000000b003f4222028d5mr19288837wml.29.1684170752657; Mon, 15 May 2023 10:12:32 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id k18-20020a7bc412000000b003f427db0015sm764wmi.38.2023.05.15.10.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 10:12:32 -0700 (PDT) Date: Mon, 15 May 2023 19:12:30 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v7 5/8] ice: implement dpll interface to control cgu Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-6-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230428002009.2948020-6-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230515_101235_038158_47E823C6 X-CRM114-Status: UNSURE ( 7.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Apr 28, 2023 at 02:20:06AM CEST, vadfed@meta.com wrote: [...] >+static const enum dpll_lock_status >+ice_dpll_status[__DPLL_LOCK_STATUS_MAX] = { >+ [ICE_CGU_STATE_INVALID] = DPLL_LOCK_STATUS_UNSPEC, >+ [ICE_CGU_STATE_FREERUN] = DPLL_LOCK_STATUS_UNLOCKED, >+ [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_CALIBRATING, This is a bit confusing to me. You are locked, yet you report calibrating? Wouldn't it be better to have: DPLL_LOCK_STATUS_LOCKED DPLL_LOCK_STATUS_LOCKED_HO_ACQ ? >+ [ICE_CGU_STATE_LOCKED_HO_ACQ] = DPLL_LOCK_STATUS_LOCKED, >+ [ICE_CGU_STATE_HOLDOVER] = DPLL_LOCK_STATUS_HOLDOVER, >+}; [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel