From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 183E0C77B75 for ; Tue, 16 May 2023 11:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ObppjRSqJ9S7HoNagwhSXMvkP27ZA+vIDA3g5BwKcc=; b=ynUnfgSSX7Pb5o RzUCiXyQ7wQxd7nM4vu0/OefqNdkiftNJZOc7NrKhh9iI/Qu8Qk0PIKOeMuVvzyrgPjswaqhnauVC QZm4y4CZyZJ/SxmUGbe/WH4XvJVpv5WTZbRgzGy5ppz0ZwPAcOIyev/oB24JVs0N6LU3EtB/M5jYg 6iSPV+kDP3UKMCIxHXJlnMuIPsUFIZNAM/Qlj5zcJKt6HAT2K40lbEARNM8qVqsvY+8CSVGYjQFnT seL2+fx2yLG6kTIK/s292DlnCHPxwtCht9xOoIkMOrtrh9ja5A1hvFeECBeyQIqLBkXrazPFS0s6S uV+pdnWqMKinduyfT6jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyt8o-005cxi-15; Tue, 16 May 2023 11:46:54 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyt8g-005cqM-16 for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 11:46:49 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-965ab8ed1fcso2592531566b.2 for ; Tue, 16 May 2023 04:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1684237601; x=1686829601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=93Yzq0NQPKDWbsmyn4CBhtU/WekigFVvB0zAMgN57XI=; b=SUIAwvI++5kAvyMBRhzQ8MviZaRm5/h1Y2uQSZusDH1AIVw9ICmGwylsvUeczZiPZR bNaGsvQCvTmWmIyaCN/Rdv08q23K/aF8O1MIle6o8HrqjSsXrAv+rbXKsVDk+CMu2vlA tkvSYGP8SY4X+4MZuWafcslj/1QsI4q9Q3qzgkwLH3u+eonbhz5tbQxv2ePF1Ldc28CK rK4/j/VsoJrElP+ZbpVWibqAaM50B1PHxWEoVQ+ZtH1FjnAYK0YZDxM7Y1nF+rYb1bbB Xr15ZesjVZock5QuYL7A3P5QQfnJwTajoUjJKBEd9Tt8SbIwVb+JnutoK7UjCX1TkBZa Nk5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684237601; x=1686829601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=93Yzq0NQPKDWbsmyn4CBhtU/WekigFVvB0zAMgN57XI=; b=eXxG8jJKnU9RZVsEFyyJ7vttuZF4WkhhYnY1CPI/8HKW1XlvHIoTYO2p2PwvmZPC5y tmyq8NHiAc9JqDA9xWZHAqAiWiEISSkQU41QuxSapAS0L82Vy0upyMNdSqB6YR8UWjh4 nLpwuW63Joy+qPW9UcGHDLr7hSOvWLclN7qQX/ILp+Jj2iAbkBng7m+La/6G+azVUCrE q3zw2S3ASjyCFdBDEWfhe93rUG0e9y10Ha0WrA+SLjaVkYIGKFfRXfKPeyLmpiGJwa57 8qV5z+KyLaHgWR3+l9gYzPPUF6iJne7sauvzQYlykibHNXg97xveZ61khoSL9bLrA9PP C1ig== X-Gm-Message-State: AC+VfDxEo3ueJ4NjvSXUsTnnwt/XeWb6O/lRsqn8TLiLnsDQvftrCcNK aO60SOydnGfx5FwWT7FU5jzGSw== X-Google-Smtp-Source: ACHHUZ6Le8AKBQWreteycC6kDR3GS8geixujQ/iDzkE/vuc3eDWlUxCWIkF3haHQxfAKxtuwY4i1qA== X-Received: by 2002:a17:906:58d5:b0:969:9fd0:7cee with SMTP id e21-20020a17090658d500b009699fd07ceemr26824898ejs.10.1684237601227; Tue, 16 May 2023 04:46:41 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id qh20-20020a170906ecb400b009655eb8be26sm10862429ejb.73.2023.05.16.04.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 04:46:40 -0700 (PDT) Date: Tue, 16 May 2023 13:46:39 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: Vadim Fedorenko , Jakub Kicinski , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v7 5/8] ice: implement dpll interface to control cgu Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-6-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_044646_603256_7E5A29D9 X-CRM114-Status: UNSURE ( 9.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tue, May 16, 2023 at 11:22:37AM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Monday, May 15, 2023 7:13 PM >> >>Fri, Apr 28, 2023 at 02:20:06AM CEST, vadfed@meta.com wrote: >> >>[...] >> >>>+static const enum dpll_lock_status >>>+ice_dpll_status[__DPLL_LOCK_STATUS_MAX] = { >>>+ [ICE_CGU_STATE_INVALID] = DPLL_LOCK_STATUS_UNSPEC, >>>+ [ICE_CGU_STATE_FREERUN] = DPLL_LOCK_STATUS_UNLOCKED, >>>+ [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_CALIBRATING, >> >>This is a bit confusing to me. You are locked, yet you report >>calibrating? Wouldn't it be better to have: >>DPLL_LOCK_STATUS_LOCKED >>DPLL_LOCK_STATUS_LOCKED_HO_ACQ >> >>? >> > >Sure makes sense, will add this state. Do you need "calibrating" then? I mean, the docs says: ``LOCK_STATUS_CALIBRATING`` dpll device calibrates to lock to the source pin signal Yet you do: [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_CALIBRATING Seems like you should have: [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_LOCKED [ICE_CGU_STATE_LOCKED_HO_ACQ] = DPLL_LOCK_STATUS_LOCKED_HO_ACQ, and remove DPLL_LOCK_STATUS_CALIBRATING as it would be unused? Also, as a sidenote, could you use the whole names of enum value names in documentation? Simple reason, greppability. Thanks! > >> >>>+ [ICE_CGU_STATE_LOCKED_HO_ACQ] = DPLL_LOCK_STATUS_LOCKED, >>>+ [ICE_CGU_STATE_HOLDOVER] = DPLL_LOCK_STATUS_HOLDOVER, >>>+}; >> >>[...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel