From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2547FC77B7F for ; Tue, 16 May 2023 16:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vMbE6HwDOLlKcmgP0Y6sWCW6i/DuLzPmRu7/PKZwUXo=; b=akjxmVCWI84Ipx PDWMD15ngtnlDHO/Z+dpdY9E0QmdmIkcZ6ZqGpmcY9ytcpo+bj28pxVRYmZOeHD+EAkJ4MhxwKmp4 hZdSewjRMC/x5AWvruqgN0jTvTGCZeHhUStakz3s6jgaysULvmcvsw2BoO+KBqov8puN+0d5Qpddr VuHMYAVQq9dRxF0CeewsTs66BuGkP7BC1cGtIEiBxbm3tsSY5nyHgK9vio7wSc4R6Ek59O9MSeVh1 EZorADGq34fO4NFqYHBt7Nvv65oZxxYQAuT5rSalBn3shxULkAUomHvAWipgSh0v63uUYN01+sajU ZjFst3BdGKUUhAD9Nwag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyxbJ-006Tfc-2K; Tue, 16 May 2023 16:32:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyxbH-006Tdh-0C; Tue, 16 May 2023 16:32:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3510860C92; Tue, 16 May 2023 16:32:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B40F7C433EF; Tue, 16 May 2023 16:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684254751; bh=Aks6nwZaqr/erbBLhafFwZ3Ao9Igx6TSOjyOocCTwx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fKNjkRfh2IVi0irTeZRo60pDLVfhgKSKiKNVfF+RjDoxU93FsClkrJbOFfjLbBSSD ygo100c/a33dEf2nLNK71x35ZLvsQtvbKBm60lk9ioQ1TXBhlW+r3Cjcc8KEBRqHdG MJXMeCRksIp3AnANmyHayxIKVOCShrP8Gq/0ov1SMm+9UVsG3SttBSWX0M/ygL+bLS frjkaXmI4j6R+gYrFju+Gej/Osl79LU8qyKIgVkW/Ij7H1yqw0459Iw51oo+MTKluV 4WHzDsNZ1B8X45Z8bqmkaAqIjS2IBovcqn7q8dnQkvmvNm/+pRlbJewCaZVIbtMovn CjImkg1ExKgXA== Date: Tue, 16 May 2023 22:02:27 +0530 From: Vinod Koul To: Sean Anderson Cc: Kishon Vijay Abraham I , linux-phy@lists.infradead.org, Madalin Bucur , linux-arm-kernel@lists.infradead.org, Camelia Alexandra Groza , devicetree@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, Bagas Sanjaya , Krzysztof Kozlowski , Ioana Ciornei , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org Subject: Re: [PATCH v14 06/15] clk: Add Lynx 10G SerDes PLL driver Message-ID: References: <20230413160607.4128315-1-sean.anderson@seco.com> <20230413160607.4128315-7-sean.anderson@seco.com> <1012f955-180e-0013-cc13-1da10991b5f5@seco.com> <7ad1089f-106d-e355-5558-f06f8b428f34@seco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ad1089f-106d-e355-5558-f06f8b428f34@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_093235_182438_AC00C49B X-CRM114-Status: GOOD ( 30.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16-05-23, 11:11, Sean Anderson wrote: > On 5/16/23 09:22, Vinod Koul wrote: > > On 09-05-23, 11:26, Sean Anderson wrote: > >> On 5/9/23 09:00, Vinod Koul wrote: > >> > On 08-05-23, 11:31, Sean Anderson wrote: > >> >> On 5/8/23 05:15, Vinod Koul wrote: > >> > > >> >> >> +int lynx_clks_init(struct device *dev, struct regmap *regmap, > >> >> >> + struct clk *plls[2], struct clk *ex_dlys[2], bool compat); > >> >> > > >> >> > so you have an exported symbol for clk driver init in phy driver header? > >> >> > can you please explain why..? > >> >> > >> >> So that it can be called at the appropriate time during the phy's probe function. > >> >> > >> >> This is really an integral part of the phy driver, but I was directed to split it > >> >> off and put it in another subsystem's directory. > >> > > >> > That is right clock should be belong to clk driver. IIUC the hardware is > >> > phy along with clocks and you are doing the clk init. I think that may > >> > not be correct model, you should really have a device tree node to > >> > represent the clock and the phy node > >> > > >> > > >> > What stops this from being modelled as it is in the hardware? > >> > >> It *is* modeled as it is in hardware. With just the serdes compatible, > >> we have all the information we need to create the clocks. So we do so. > >> There's no need for a separate device just to create four clocks. > >> > >> These clocks cannot be used by any other device (except possibly by > >> putting a lane into test mode). So there is no benefit from making them > >> a separate device, except an increase in complexity due to ordering and > >> dynamic lookup. By doing things this way we know that either there was > >> an error or the clocks all exist, and the lifetime of the clocks matches > >> the serdes. > > > > Okay that does makes sense. > > > > In that case why should this not be in the phy driver itself. There are > > already few examples og phy drivers having inbuild clk where is makes > > sense. You register the clk_ops as part of phy driver > > You told me to do it this way I agree that was not the right recommendation back then and your view was right -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel