From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFBE8C77B7A for ; Tue, 16 May 2023 19:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=D1GPozbOVAA5I+/9l0MPtGiJOTpJlGiKaLVjUTFLjpU=; b=W4qb3+Lo6xtJ5z CM82EuPdjma+skSOhkN0Mg/gQXIhm79RWiy6g0J41hw/ZYAH8aeB0P3eueUJGRKExXPiiHYeVVYPe vkEMrRFwNJt8hYkN0+lHXFBnE1NXA2NuIbOgBosPjNSB2HoiAbPFDwwonasqY1I4JGCgLkOKEkHo5 12x/A/dQnj9HDY1dD/d3UzanNz5BKC5vf59Z+Z6ldJgc3H9JUEV2wWNtKMqqifste19Zid/Gb5jlk cR9m/mkeXm1rCVsaIh5Bvp1483HWMqLSKvDhJTW82CArv/LZ1CcvdiCH00zkjPNA94TGXxQHJf1mg JvaR4KaDgYluWG0GQgag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pz0DI-006tqz-1d; Tue, 16 May 2023 19:20:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pz0DF-006tpv-37 for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 19:19:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7EEDF63E42; Tue, 16 May 2023 19:19:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E817C433D2; Tue, 16 May 2023 19:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684264796; bh=H7hBEmw3Z3LoaI9KQBlQHHYtNoDMB9M+8qVjdKRbuio=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=U/uowP+R8HvoDRhWN0BTTHjsMrX84zavErJ+nQDYb5WuMFFdx1/01SDuAHkd3wL7t DZY5xi8YMVkjIgc0P5XxFfhbAfiz1jskUTDhxLpHhDa3iAvjAlL/sZtmQTq7Wf8TrY LpDYD8HaleZTv8PnLbpmPO1+6O03QIrc2lqhvK7teXFay3M6gcteNGlDO2cHNRj2A8 X1gnUzBEhLpc7UZ1xxG4/htMeZvk1v10OSf4y1fqtayKfXKu0w2FpCCGmK37gYqDnM OdwweI7apqpeLjLLN7aOKD9xVDCzela8Qt9HMVKmoNHk2uN4veFEH3YrKX825PowL7 ZweX7MQH+sqBw== Date: Tue, 16 May 2023 14:19:55 -0500 From: Bjorn Helgaas To: Shuai Xue Cc: yangyicong@huawei.com, will@kernel.org, Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v4 3/4] drivers/perf: add DesignWare PCIe PMU driver Message-ID: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230516130110.59632-4-xueshuai@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_121958_090613_D6483D44 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 16, 2023 at 09:01:09PM +0800, Shuai Xue wrote: > ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Typically in alpha order. > +#define DWC_PCIE_VSEC_RAS_DES_ID 0x02 > + > +#define DWC_PCIE_EVENT_CNT_CTL 0x8 Add a blank line here. > +/* > + * Event Counter Data Select includes two parts: > +#define DWC_PCIE_EVENT_CNT_DATA 0xC > +#define DWC_PCIE_DURATION_4US 0xff ... Pick upper-case hex or lower-case hex and use consistently. > +#define DWC_PCIE_LANE_EVENT_MAX_PERIOD (GENMASK_ULL(31, 0)) > +#define DWC_PCIE_TIME_BASED_EVENT_MAX_PERIOD (GENMASK_ULL(63, 0)) Unnecessary outer "()". > +struct dwc_pcie_pmu { > + struct pci_dev *pdev; /* Root Port device */ > + u32 ras_des; /* RAS DES capability offset */ u16 is enough to address all of config space. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel