From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Arnd Bergmann <arnd@kernel.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Hugues Fruchet <hugues.fruchet@st.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors
Date: Wed, 17 May 2023 12:12:05 -0700 [thread overview]
Message-ID: <ZGUnBfqBLWkD7ZgD@google.com> (raw)
In-Reply-To: <ZGUbDFssUwXKTiDt@valkosipuli.retiisi.eu>
On Wed, May 17, 2023 at 09:21:00PM +0300, Sakari Ailus wrote:
> Hi Arnd,
>
> On Mon, Jan 30, 2023 at 02:09:47PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The gpio usage in the function is fairly straightforward,
> > but the normal gpiod_get() interface cannot be used here
> > since the gpio is referenced by a child node of the device.
> >
> > Using devm_fwnode_gpiod_get_index() is the best alternative
> > here.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I've picked
> <URL:https://patchwork.linuxtv.org/project/linux-media/patch/20230130131003.668888-1-arnd@kernel.org/>
> instead. I hope that's fine. Also cc Dmitry.
What do you mean "instead"? This is the exact patch that started this
thread, and it is broken (uses wrong name of the GPIO and wrong polarity).
I'd much rather you picked up
https://lore.kernel.org/all/Y92VLGLQJZ%2FUDRx1@google.com/
Thanks.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-17 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:09 [PATCH] media: c8sectpfe: convert to gpio descriptors Arnd Bergmann
2023-01-30 17:18 ` Andy Shevchenko
2023-01-30 18:17 ` Arnd Bergmann
2023-02-03 23:10 ` Dmitry Torokhov
2023-02-01 3:29 ` Dmitry Torokhov
2023-02-01 18:35 ` Andy Shevchenko
2023-05-17 18:21 ` Sakari Ailus
2023-05-17 19:12 ` Dmitry Torokhov [this message]
2023-05-17 19:26 ` Sakari Ailus
2023-05-19 1:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGUnBfqBLWkD7ZgD@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=hugues.fruchet@st.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).