From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51093C77B7D for ; Wed, 17 May 2023 19:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dNIUbYn4dsUspcMGlj+uG8bIFgQlnNKUrUrscygqW8c=; b=mGjrqTykar9SPj bACCXjh0Bi9qhrYG2tugQ2zO3FZiN/MLNPMWsb68hspTwnCMAEXwVFRy8ChuQAC6KTXHUXPxLoaAK xwy2q/J1RWbKjBVs44l72nBT95stfOk60qxIrXjx/peRyQWzZSms1TYRtrWo4FI4tfdsR3cwHnaZR BAUaJSMRyDmpIb8RWvVWXBWcUk0xw1x7dp6V3ac1we7SaoPxTphoENbO7L2FnXbgtfd37q0X/U9As ZtvR2QO4kqhNsQz2RkxJyuIX7G3apn2jrA7qHhi8ig7MEQla1jzgJv/Cey0qIGnB0qWPO3DWOFEmp LbfBMhmfexhiy/5w5Z8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzMZL-00Ap89-2e; Wed, 17 May 2023 19:12:15 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzMZJ-00Ap6h-0X for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 19:12:14 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-24e5d5782edso1241329a91.0 for ; Wed, 17 May 2023 12:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684350729; x=1686942729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=belPChGY/La7XkZuio4MlHHNDT6JFtoyF+AdNUmOvSE=; b=Y6p8Nx4GqfvFrtaGTVMQK/7Dp9vAmEtEXDMpT5L6tZQUjXtmHDgy2cgheNR/vGvIkr UbSZbCuJcF7FVEBDwMv1dXfY258bYy8SVF8J7XqFIEZ2+tMdOn2GX8aLIxurHlZ8npcN TIN1hJKbdBR24rwj8P852JroKawQLl/5yXPhPw5jJ/1Id7woRfFT4y+PX5rkAyXu+cbI Il67x0OVh1C60eIDJ1T1tJcdqyEL7pPoTuZnH6/YQ1CT5aepni237X03kgojUiv5YT/c 6b2vKeoQqLH2UWxQju7I2+MlLGk3Idz5wLFaAst8xS0ydi/nRHk0HXiHg6ugSZl9tK3o wq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684350729; x=1686942729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=belPChGY/La7XkZuio4MlHHNDT6JFtoyF+AdNUmOvSE=; b=hsPgl1CDi5M2LvuOnGR07wzssN3Teh8D++BfSFdCJQDU7Ro4X5lnC0cGb9AlV2f305 vJmoj18R2rIOPdrRmmwGmZxlANM6bUedfXGykqV8AXDGL5oKkvMhGNZuVOwc/d4/hyaS B8jQ0gNGZ93wtTn42lqhaxTct4WsgJq/d8ICy4dGOwAFZquCxfVVYp9OqJVFtAgTrEam IJvOf2IfLdB2dP0jkW9xM23hsZptq3wldfENOQIUsA0UEono3huyk2gnzfmc47SrCirb /zQzB4Mbpt2RVyW3LbJtkEW+kctcMBcNHlWFYohmnoiNGKD+FuLxh7AGXOlAR5NbO+P7 hvNw== X-Gm-Message-State: AC+VfDzSIdItLogZkPyC/fSBBBbXQOhlEFtV4VVeaAaQnZtP+BOqdvLn 3+n0GZiIoQmnLBghFNqjW3s= X-Google-Smtp-Source: ACHHUZ6tMu01Q4ai0Y2K2iB2vTJD+vZhid6eNXamnu078f1AaaN9TgIVFyPhAOxUuwhUAN3cEu/YxA== X-Received: by 2002:a17:90a:2fcf:b0:24e:1f5:2e05 with SMTP id n15-20020a17090a2fcf00b0024e01f52e05mr721049pjm.13.1684350729404; Wed, 17 May 2023 12:12:09 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:6ecb:b01b:2e2e:6c1]) by smtp.gmail.com with ESMTPSA id u13-20020a17090a890d00b0024dee5cbe29sm1975303pjn.27.2023.05.17.12.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 12:12:08 -0700 (PDT) Date: Wed, 17 May 2023 12:12:05 -0700 From: Dmitry Torokhov To: Sakari Ailus Cc: Arnd Bergmann , Patrice Chotard , Mauro Carvalho Chehab , Arnd Bergmann , Andy Shevchenko , Hans Verkuil , Hugues Fruchet , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors Message-ID: References: <20230130131003.668888-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_121213_204286_6B07E03D X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 17, 2023 at 09:21:00PM +0300, Sakari Ailus wrote: > Hi Arnd, > > On Mon, Jan 30, 2023 at 02:09:47PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The gpio usage in the function is fairly straightforward, > > but the normal gpiod_get() interface cannot be used here > > since the gpio is referenced by a child node of the device. > > > > Using devm_fwnode_gpiod_get_index() is the best alternative > > here. > > > > Signed-off-by: Arnd Bergmann > > I've picked > > instead. I hope that's fine. Also cc Dmitry. What do you mean "instead"? This is the exact patch that started this thread, and it is broken (uses wrong name of the GPIO and wrong polarity). I'd much rather you picked up https://lore.kernel.org/all/Y92VLGLQJZ%2FUDRx1@google.com/ Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel