From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C41DC77B7A for ; Thu, 18 May 2023 18:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0b8ZaNxPkzTVquuYvjWXDlVSdk4kky+nu4M/QroNjF0=; b=wumW64x6oHnH9t 0Yetmpl2gzFjE37qvEvvZ8jxdLK73IF4OoqCqbzHyyu3rkyhV2Yz3sH484hLRNiMte5OEERfBTwSl vHGuy8TFOH3Fb8vWG5ZwD52zRNsF8EJfr7UsKBkPG7w5A3KkfNBpJpoBkkUulq6cusNXpQwRL1E6n aB7Zrz+8bZXqwup0HmL9XODhFjUgVT3N9PMgXcrZ8N8M6y+VTQZ1tiYqUDhIeEg7BwHCYIyE0c5ra MLOAljihtMSb+fVprCSe6WTlQfI3NjVloybOzwT0DXA1E7GxxPf8jGEuoK3rdf/BQCxkfpUlSwfIo C/N6M5vcG1dpmvodfRag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pziI4-00Dnbu-1M; Thu, 18 May 2023 18:23:52 +0000 Received: from out-50.mta1.migadu.com ([95.215.58.50]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pziI1-00DnaZ-32 for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 18:23:51 +0000 Date: Thu, 18 May 2023 18:23:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684434225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CnFlALddlgo/f9aI1dtyKN5GyhA2U0e+HVCZ9TESVBk=; b=vCIqvVmrK1voIplVWkWbNgJQidyriRakXGLVhXA1HWqS2viQQKFH0asilGn+W6rWM1PT2c nm76e2+Io3q3oRfYD45YI+t5yuRcGjAtD5q3PbzBchnrxbYuNg5up8A3ovVv+FxHbKgWQB 0Omk3KfSytiGnr4DOdyQlmHqtzgwVZI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Jean-Philippe Brucker Cc: maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH 0/4] KVM: arm64: vgic: Locking fixes Message-ID: References: <20230518100914.2837292-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230518100914.2837292-1-jean-philippe@linaro.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_112350_148007_EBFBD7DC X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 18, 2023 at 11:09:14AM +0100, Jean-Philippe Brucker wrote: > Another fun locking puzzle, between the new config_lock and srcu. > Patch 1 attempts to fix it, and the other patches fix simpler issues. > > I got these lockdep reports while running KVM QEMU on a TCG QEMU, but it > can also be triggered by running the vgic_irq kselftest on TCG QEMU. > Now, with the fix and lockdep enabled, vgic_irq hangs but I believe it's > an unrelated weirdness: if I introduce a separate lockdep warning for > some made up locks, then the test passes again. So I'm sending this out > now for discussion, and will investigate that one later. > > I run the host with: > > qemu-system-aarch64 -M virt,virtualization=true,gic-version=3 -m 2G -smp 8 -cpu max -append 'console=hvc0 root=/dev/vda rw' -kernel Image -nodefaults -chardev stdio,mux=on,id=virtiocon0,signal=off -device virtio-serial-device -device virtconsole,chardev=virtiocon0 -mon chardev=virtiocon0,mode=readline -device virtio-blk-device,drive=hd0 -drive format=raw,if=none,file=virt_root.bin,id=hd0 -nographic > > Jean-Philippe Brucker (4): > KVM: arm64: vgic: Fix a circular locking issue > KVM: arm64: vgic: Wrap vgic_its_create() with config_lock > KVM: arm64: vgic: Fix locking comment > KVM: arm64: vgic: Fix a comment Damn! Thought I had this sorted. Thanks for taking a crack at this. I've looked it over a couple times, and overall looks good. For the series: Reviewed-by: Oliver Upton Once I get some free cycles this afternoon/evening I'll take the patches for a spin. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel