From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 781C3C77B75 for ; Fri, 19 May 2023 06:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cEL2M7z5KIMHzl59VYZYgdGuH5igbgXDn+mre8gx8As=; b=3ipXq7llMR2iIU gKwXuK40wO3qvtu+iIGSRFNtquzujwvTYFLqQ8Mdoxun5SEhJrklR8mH996k3l5NfsOBe2ngT/xik whaXjdC6FoFeg/U/Pt1aZfmgKhfh7ewYCVglYSElLT0Uq4ifjXSJj5vUtxc67SyS12sgJMqApjsPa Ill6hGrpKXGyb+lY/uGtZPaza4GSV3h4sgvyJ/QeWm66quiZk76ebp4RKbwdJ7k4rHp9O2ax43anX C1OPNesT2aY6tA/1PqUwS4z/OmMjfMmmbGGD/kS3hEhlM5mQLMMl5upAAeFA/aWP+MviDHOVxPiDG 0V0YNc0WrWERBTAj0xkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pztOt-00FEfp-1J; Fri, 19 May 2023 06:15:39 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pztOk-00FEdG-15 for linux-arm-kernel@lists.infradead.org; Fri, 19 May 2023 06:15:38 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-307c040797bso1864447f8f.3 for ; Thu, 18 May 2023 23:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1684476921; x=1687068921; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yCYh8uS1PtNXF3LwY9umV8pnonHc4qG+wyV47LgNPyE=; b=luy86l3Q6tr9NE36/PaWY/NMcy3vQDicAQDuobaG/T7kxch7KuZ8BVQ+wVi/vL9S6f kY3dQObPjIhNNCCUF+fzApWI0G6ehTqeAzN3LngL2hwTlbsP8Xj4RkODjGjD4FE84HBk CmhrMa40U75tpP4FC10rrbW8OBQK0xBmQgDhR7bDcO+mBlysOh5+1kZx0YHH3J1vqnvo zyQZaRe12+IkmBfektwQgUAerZJs84gM12s/JYFwVYiK8pjU/AByk0NcrVXzBivUThJD PDjMLFdLsf99KtU/w/gFGj+2a78jv7oCqpsn+31Z4z9OB228QG76QUCn6KD+bhBVKF0Y nbtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684476921; x=1687068921; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yCYh8uS1PtNXF3LwY9umV8pnonHc4qG+wyV47LgNPyE=; b=DYz41wp9h94TaHoSbSVJPJdgAO6kMLL/9KKlXGam8+dkCofB7LVIjcXe5k+MEHhNrZ X5z23HtQq9RTRE7WZ2ILpLTQ6Z2UfM08Xc+EJaX1aJKPYEt0/hJIH11enxajPIHkVpJb 1bdSlLyD9Slm//ZwMxTDbIhitPkivfwlzgqlCyGd+87WuWkT16ek/9fVM9sfiyJfsFaA +nQVL0iK6/SxLhdSxXSkTzDeTOFt8DcnMhJT6w5Ndxkh8ons5nw8Tey06hn5zkzx/2z/ QbXH5J/7+nFEzL7cpQwVSW/cugCRS62hnvJ2wNSN2KZiSJugn6R+F46BpxT5MqgX9pDV lWqA== X-Gm-Message-State: AC+VfDwzcyJYdsIreRP6sBDke5CVTlHgUTMq7b1jDWvpRZHZndFhHt0H Lq0dU3umsD82wuidk8h5AI2oVw== X-Google-Smtp-Source: ACHHUZ4ZwhFo+c6dqH/926xcq+W9gpeBGHfa3x8yDrWM5NcnK/XK6011FVVufCnnN9UCun2EEVMjNw== X-Received: by 2002:adf:e4c5:0:b0:305:e8db:37df with SMTP id v5-20020adfe4c5000000b00305e8db37dfmr762233wrm.22.1684476920736; Thu, 18 May 2023 23:15:20 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id d18-20020adff852000000b002ca864b807csm4334055wrq.0.2023.05.18.23.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 23:15:19 -0700 (PDT) Date: Fri, 19 May 2023 08:15:18 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: Vadim Fedorenko , Jakub Kicinski , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v7 5/8] ice: implement dpll interface to control cgu Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-6-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_231530_597394_D078B9EA X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thu, May 18, 2023 at 06:06:03PM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Tuesday, May 16, 2023 8:26 AM >> >>Tue, May 16, 2023 at 12:07:57AM CEST, arkadiusz.kubalewski@intel.com wrote: >>>>From: Jiri Pirko >>>>Sent: Wednesday, May 3, 2023 2:19 PM >>>> >>>>Fri, Apr 28, 2023 at 02:20:06AM CEST, vadfed@meta.com wrote: >>>>>From: Arkadiusz Kubalewski [...] >>>>>+ pins[i].pin = NULL; >>>>>+ return -ENOMEM; >>>>>+ } >>>>>+ if (cgu) { >>>>>+ ret = dpll_pin_register(pf->dplls.eec.dpll, >>>>>+ pins[i].pin, >>>>>+ ops, pf, NULL); >>>>>+ if (ret) >>>>>+ return ret; >>>>>+ ret = dpll_pin_register(pf->dplls.pps.dpll, >>>>>+ pins[i].pin, >>>>>+ ops, pf, NULL); >>>>>+ if (ret) >>>>>+ return ret; >>>> >>>>You have to call dpll_pin_unregister(pf->dplls.eec.dpll, pins[i].pin, ..) >>>>here. >>>> >>> >>>No, in case of error, the caller releases everything >>ice_dpll_release_all(..). >> >> >>How does ice_dpll_release_all() where you failed? If you need to >>unregister one or both or none? I know that in ice you have odd ways to >>handle error paths in general, but this one clearly seems to be broken. >> > >It doesn't have to, as release all would release all anyway. >Leaving it for now. So you call dpll_pin_unregister() even for the pin that was not registered before? How is that even remotely correct? Fix your error paths, please. I don't understand the resistance here :) [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel