From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49147C77B7F for ; Fri, 19 May 2023 06:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CYz85G3YyarxTTs94Ni9nX/c7Vj6rba1rGoBtRkjUfI=; b=wIQQv7+NLafP26 wXTDTE0J0u9zIrOhGp7w8T620Hclo/sU/e5aOO8dXx32eSqtrW/mrWAYUKa6b30Vs963nuIaAOuxr VLG3oG19k8iwFxxyHgHxEq2YonWkx/M402PaJ2RwSEj80+HOuMn5KHhI5Fz7Xc0cnAU5xOp0V/ZXC +pHhj18uBlM4Vuv8HH/ndrZV+TDNc/qbKhTScfCFyZrfr30WYrC0BtYjyPkXqri9sU/kZJI7eO636 qfF8whau6xALSLB0rJpzs6WG4+XpSg4RaJb87L/w7b7YC0zVyj8Bo4aUEqiIY62tC5CFCU8nVeNIA qSeImwy+eG39pSMg1rNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pztPD-00FEj2-1N; Fri, 19 May 2023 06:15:59 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pztPB-00FEiS-05 for linux-arm-kernel@lists.infradead.org; Fri, 19 May 2023 06:15:58 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3078cc99232so2721241f8f.3 for ; Thu, 18 May 2023 23:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1684476955; x=1687068955; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oU2aaZIcfAL/J7x8hKgNcEmwTba6so0CuVNNIebXyJo=; b=VofQDRVT1jdG/lDa+izEbTfQZSQdPXUA+AlBPDKbeiloOfTHZ8kCdyoR7Df0sXAtix dUoEu4fRTeosTJ3qUfJDz2v2dkvKwPZcroDBm+D909j9XXnIfm7iBbGhPhuNYeOUh7XK pvmm3+eiQe3+Q0eINYgpEnTONkJwumRgzZUPAKMLPK+1ERAPxQBIRqX50WtPNe85Os5P JTPQznB+kf6ckenm/uitdJGARkLZ3PM7WpuBjwH+23Wn+RXLXllj1o2B8iYanABsyf83 EqxshMNzFHtPrdmnX4qTL8+laetM18hIauFvX8qJoQomRfllrIWmGnuDu8XMArTMl9sk P4Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684476955; x=1687068955; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oU2aaZIcfAL/J7x8hKgNcEmwTba6so0CuVNNIebXyJo=; b=MQx8WlzVdvy0CrVOdiQemLFqu5lGrb6RZaqVcBjn4IClPCt8iwd09WRCHPwKpzA6qF ckZWqj+mZiaHM6qz11azpsSnk9JUzKyj4pAsAs5peRPUSNTWnppqMZsxHyk4LzEjeYIe 35XALlLDctReFr27voiIwSmawq1Ibx+GMvmKE2vi4f1GsN0ky+hQxQDZdXzrnsxI62j8 aUS6WdYWy42t+v1rfXgzGOR3vckydU11NwhcZJXxPJPS+CjX+6Sn1bm4ES6fHJIpT1Tg P/Hv+IS4Q3Rd9x6Un58j0JBo1j/22KpWdAV8MggQExm8MiXRk/M54w4shHYuSp6WCXZe Dv6A== X-Gm-Message-State: AC+VfDwUccXw2JZ278wIpYRsBtaXflQYgPNfjvzhaFsKraDcO1h3WcSI dcKbo5Z4T7BkYCxtVTNc8QMW+g== X-Google-Smtp-Source: ACHHUZ5CXRNO+/Y9dUrlLh8l0PKouHwzklNi4pxgozOUKSXhvSQfzpurqtkaDV1PH5HIwXBp/bfUNw== X-Received: by 2002:adf:e912:0:b0:309:3bb5:7968 with SMTP id f18-20020adfe912000000b003093bb57968mr1185087wrm.16.1684476954774; Thu, 18 May 2023 23:15:54 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id l16-20020a5d4bd0000000b0030642f5da27sm4224263wrt.37.2023.05.18.23.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 23:15:54 -0700 (PDT) Date: Fri, 19 May 2023 08:15:53 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: Vadim Fedorenko , Jakub Kicinski , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v7 5/8] ice: implement dpll interface to control cgu Message-ID: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-6-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_231557_063014_F8A61F59 X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thu, May 18, 2023 at 06:07:33PM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Tuesday, May 16, 2023 1:47 PM >> >>Tue, May 16, 2023 at 11:22:37AM CEST, arkadiusz.kubalewski@intel.com wrote: >>>>From: Jiri Pirko >>>>Sent: Monday, May 15, 2023 7:13 PM >>>> >>>>Fri, Apr 28, 2023 at 02:20:06AM CEST, vadfed@meta.com wrote: >>>> >>>>[...] >>>> >>>>>+static const enum dpll_lock_status >>>>>+ice_dpll_status[__DPLL_LOCK_STATUS_MAX] = { >>>>>+ [ICE_CGU_STATE_INVALID] = DPLL_LOCK_STATUS_UNSPEC, >>>>>+ [ICE_CGU_STATE_FREERUN] = DPLL_LOCK_STATUS_UNLOCKED, >>>>>+ [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_CALIBRATING, >>>> >>>>This is a bit confusing to me. You are locked, yet you report >>>>calibrating? Wouldn't it be better to have: >>>>DPLL_LOCK_STATUS_LOCKED >>>>DPLL_LOCK_STATUS_LOCKED_HO_ACQ >>>> >>>>? >>>> >>> >>>Sure makes sense, will add this state. >> >>Do you need "calibrating" then? I mean, the docs says: >> ``LOCK_STATUS_CALIBRATING`` dpll device calibrates to lock to the >> source pin signal >> >>Yet you do: [ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_CALIBRATING >>Seems like you should have: >>[ICE_CGU_STATE_LOCKED] = DPLL_LOCK_STATUS_LOCKED >>[ICE_CGU_STATE_LOCKED_HO_ACQ] = DPLL_LOCK_STATUS_LOCKED_HO_ACQ, >> >>and remove DPLL_LOCK_STATUS_CALIBRATING as it would be unused? >> >>Also, as a sidenote, could you use the whole names of enum value names >>in documentation? Simple reason, greppability. >> > >Yes, removed CALIBRATING. >Fixed the docs. Cool, thanks! > >Thank you! >Arkadiusz > >>Thanks! >> >> >>> >>>> >>>>>+ [ICE_CGU_STATE_LOCKED_HO_ACQ] = DPLL_LOCK_STATUS_LOCKED, >>>>>+ [ICE_CGU_STATE_HOLDOVER] = DPLL_LOCK_STATUS_HOLDOVER, >>>>>+}; >>>> >>>>[...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel