* [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t
@ 2023-05-17 20:19 Arnd Bergmann
2023-05-18 11:29 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2023-05-17 20:19 UTC (permalink / raw)
To: Linus Walleij, Vinod Koul
Cc: Arnd Bergmann, Julia Lawall, linux-arm-kernel, dmaengine,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
wide, causing a warning about the format string:
drivers/dma/ste_dma40.c: In function 'd40_probe':
drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
Change both to the special %pap and %pap helpers for these types.
Fixes: 5a1a3b9c19dd ("dmaengine: ste_dma40: Get LCPA SRAM from SRAM node")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/ste_dma40.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 9ff6dd9e2fa2..dbc988cfc4bf 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3536,8 +3536,8 @@ static int __init d40_probe(struct platform_device *pdev)
}
base->lcpa_size = resource_size(&res_lcpa);
base->phy_lcpa = res_lcpa.start;
- dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
- (u32)base->phy_lcpa, base->lcpa_size);
+ dev_info(dev, "found LCPA SRAM at %pad, size %pa\n",
+ &base->phy_lcpa, &base->lcpa_size);
/* We make use of ESRAM memory for this. */
val = readl(base->virtbase + D40_DREG_LCPA);
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t
2023-05-17 20:19 [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t Arnd Bergmann
@ 2023-05-18 11:29 ` Vinod Koul
2023-05-18 11:59 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2023-05-18 11:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Arnd Bergmann, Julia Lawall, linux-arm-kernel,
dmaengine, linux-kernel
On 17-05-23, 22:19, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
> wide, causing a warning about the format string:
>
> drivers/dma/ste_dma40.c: In function 'd40_probe':
> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
> 3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
>
> Change both to the special %pap and %pap helpers for these types.
Already posted [1] and applied now
[1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@kernel.org
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t
2023-05-18 11:29 ` Vinod Koul
@ 2023-05-18 11:59 ` Arnd Bergmann
2023-05-19 10:46 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2023-05-18 11:59 UTC (permalink / raw)
To: Vinod Koul, Arnd Bergmann
Cc: Linus Walleij, Julia Lawall, linux-arm-kernel, dmaengine,
linux-kernel
On Thu, May 18, 2023, at 13:29, Vinod Koul wrote:
> On 17-05-23, 22:19, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
>> wide, causing a warning about the format string:
>>
>> drivers/dma/ste_dma40.c: In function 'd40_probe':
>> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
>> 3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
>>
>> Change both to the special %pap and %pap helpers for these types.
>
> Already posted [1] and applied now
>
> [1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@kernel.org
I think yours is wrong: you use %pR with a resource_size_t, but it
expects a "struct resource instead".
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t
2023-05-18 11:59 ` Arnd Bergmann
@ 2023-05-19 10:46 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-05-19 10:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arnd Bergmann, Linus Walleij, Julia Lawall, linux-arm-kernel,
dmaengine, linux-kernel
On 18-05-23, 13:59, Arnd Bergmann wrote:
> On Thu, May 18, 2023, at 13:29, Vinod Koul wrote:
> > On 17-05-23, 22:19, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> When LPAE is set, both the dma_addr_t and resource_size_t become 64 bit
> >> wide, causing a warning about the format string:
> >>
> >> drivers/dma/ste_dma40.c: In function 'd40_probe':
> >> drivers/dma/ste_dma40.c:3539:23: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
> >> 3539 | dev_info(dev, "found LCPA SRAM at 0x%08x, size 0x%08x\n",
> >>
> >> Change both to the special %pap and %pap helpers for these types.
> >
> > Already posted [1] and applied now
> >
> > [1]: https://lore.kernel.org/r/20230517064434.141091-1-vkoul@kernel.org
>
> I think yours is wrong: you use %pR with a resource_size_t, but it
> expects a "struct resource instead".
Right, i indeed looked up wrong format
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-19 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 20:19 [PATCH] dmaengine: ste_dma40: use proper format string for resource_size_t Arnd Bergmann
2023-05-18 11:29 ` Vinod Koul
2023-05-18 11:59 ` Arnd Bergmann
2023-05-19 10:46 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).