From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 166D6C7EE26 for ; Tue, 23 May 2023 16:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ax1M9SH9IJ6PoGxxJ7CfVHHBI13UOGxBZbOzQNZaEr0=; b=HuER5DSXYmYYfK Qks3oLejJjrXt/zcPbyadeDgJW7n33BqQjM3eDo9ilMQX/vDk302zYHQ9X5Pc40J7dczClizNNfCg vXIMum+wlHlyJBmYNf9YzzPuVUkxlPyCbsm2pfi92cmGj6UCAoR0otHngiOLR0rrLi+QMOxxvhGHg Jqd8APt8QS9ZMN9cbqe9jt6KbadcVV1ypxT/jR7+sRgTvroYVjka2yrGdxYLf5hFN9rdGiYLlUb14 r7PQZVg30pX6zyaXcoX4NRNVLU8naTEQ47TIzZzJ1bV+7BdGiEE1pu52A1A3xFVgb/3F+YKc8FanB u/+Di6pjWoTuEq71kb/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1UrF-00AnOV-1J; Tue, 23 May 2023 16:27:33 +0000 Received: from fgw22-7.mail.saunalahti.fi ([62.142.5.83]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1UrC-00AnNP-2Z for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 16:27:32 +0000 Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id b2c8a84a-f986-11ed-a9de-005056bdf889; Tue, 23 May 2023 19:27:24 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Tue, 23 May 2023 19:27:23 +0300 To: Ryan.Wanner@microchip.com Subject: Re: [PATCH 1/3] pinctrl: at91-pio4: Enable Push-Pull configuration Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_092731_017516_4F193C37 X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, conor+dt@kernel.org, linux-gpio@vger.kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wed, May 17, 2023 at 01:54:04PM +0200, Ryan.Wanner@microchip.com kirjoitti: > From: Ryan Wanner > > Enable push-pull configuration. Remove integer value argument from > open-drain configuration as it is discarded when pinconf function is > called from gpiolib. Add push-pull do debug and get functions. Right, thank you for fixing this! Other comments below. ... > + case PIN_CONFIG_DRIVE_PUSH_PULL: > + conf &= (~ATMEL_PIO_OPD_MASK); Parentheses are redundant. > break; ... > if (conf & ATMEL_PIO_OPD_MASK) > seq_printf(s, "%s ", "open-drain"); > + if (!(conf & ATMEL_PIO_OPD_MASK)) > + seq_printf(s, "%s ", "push-pull"); As commented already by others, the else would be better. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel