From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63E85C77B73 for ; Tue, 6 Jun 2023 18:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bAb23flQt+9VJEnjbZMjerGklw7eOmUG1J4A7Ea9/cc=; b=a3f9/Kgwhq16Yd ZN/MK2K/sMdqoR228dehmHg0CIO1VP5nWHswfpuzrZc+rFCZxImB9u64ThG+rt9Eo+GMbOs1RUpOo n5Fbni4gGl93D+SCSeppF79FpUpzttWI0MYihNSHneFsPFKphTIYmNZV3TV7H+7d+QcB5/6wmp/yK cIGQ/8iplK1E5gCMOba2IB9fFO++YyL5xIfimWPPQI/QcXpzLX8EIwQV2aT4oEIFKmxpPNfgZ+eIK 1qBZuLHkrVOlx+QfONyqeygtIaNQlgQ7mB0yt/c+TU0pqc9AWE8iBU+Koj2yp7kDkFOvux5ecfMJV USMvRrYCnKB8c2+KOn1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6bkb-002oWu-2U; Tue, 06 Jun 2023 18:49:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6bkZ-002oVq-2C for linux-arm-kernel@bombadil.infradead.org; Tue, 06 Jun 2023 18:49:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=m1UmqrhUHhqWGJc31D53uT40i0sgem/hJFCauaetZvY=; b=hpRYZQ9k1xdt3LBqIjoSZrtJXh m214utKp2wnslpNWEFQ9hrlMuM7t6kK7Oob0gqt4A8F2LR49OmI9dS0BDJz5+zdy1gY9pkBidadpn pcQPKavdCZze/TlqcF4kylsZQ8qj3N3jFjRcJ6eF6DftfwDeMXH6KPddmy0WFpQproJuiwtjV5T+M IFJDOVSR8QJ1ozFP4FsYc2YXf9BoL8SPjTiyqiWf5Z8iCfmD/jkYhmqnj8vluRjvqcWT3IoluPG3V Yj1lpqncXS/84lfOoxtdrTByhQarUONqzP+lZc0zx0GXjfnQLjp9wU+ci0qIo6BHkOOZI+FP9hyCq 5Rcw8eTg==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q6b5i-0049Ox-0f; Tue, 06 Jun 2023 18:07:34 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1059A40692; Tue, 6 Jun 2023 15:07:32 -0300 (-03) Date: Tue, 6 Jun 2023 15:07:32 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , coresight@lists.linaro.org, denik@chromium.org, Suzuki K Poulose , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] perf cs-etm: Track exception level Message-ID: References: <20230524131958.2139331-1-james.clark@arm.com> <20230606004648.GB18315@leoy-huanghe> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230606004648.GB18315@leoy-huanghe> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Jun 06, 2023 at 08:46:48AM +0800, Leo Yan escreveu: > Hi Arnaldo, > > On Mon, Jun 05, 2023 at 04:44:45PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, May 24, 2023 at 02:19:54PM +0100, James Clark escreveu: > > > Some fixes to support an issue reported by Denis Nikitin where decoding > > > trace that contains different EL1 and EL2 kernels can crash or go into > > > an infinite loop because the wrong kernel maps are used for the decode. > > > > > > This still doesn't support distinguishing guest and host userspace, > > > we'd still have to fix the timestamps and do a bit more work to > > > correlate that. And I've removed PERF_RECORD_MISC_HYPERVISOR as a > > > possible outcome of cs_etm__cpu_mode(). As far as I know this could > > > never have been returned anyway because machine__is_host(machine) was > > > always true due to session.machines.host being hard coded. And I'm not > > > sure of the relevance of the difference between PERF_RECORD_MISC_KERNEL > > > and PERF_RECORD_MISC_HYPERVISOR in this scenario. > > > > > > The first commit is a tidy up, second fixes a bug that I found when > > > comparing the exception level and thread of branch records, the third > > > is the main fix, and the last commit is some extra error checking. > > > > > > Applies to acme/perf-tools (4e111f0cf0) > > > > So there seems to be agreement the first two patches can be applied? May > > I go ahead and do that now? > > Could you pick up the first patch in this series? > > I would like ask James to refine a bit for the second patch. Ok, left just the first patch on my local perf-tools-next branch, will go public when tested. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel