* [PATCH] arm64/cpucaps: increase string width to properly format cpucaps.h
@ 2023-05-17 10:04 Prathu Baronia
2023-05-26 9:28 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Prathu Baronia @ 2023-05-17 10:04 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Prathu Baronia, linux-arm-kernel,
linux-kernel
The lengthiest capability is `WORKAROUND_TRBE_OVERWRITE_FILL_MODE` and
its length is 35 characters so increase the width of left justified
strings to 35 and adjust the tab space for `ARM64_NCAPS` accordingly.
Now the generated cpucaps.h is properly formatted.
Signed-off-by: Prathu Baronia <quic_pbaronia@quicinc.com>
---
arch/arm64/tools/gen-cpucaps.awk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/tools/gen-cpucaps.awk b/arch/arm64/tools/gen-cpucaps.awk
index 00c9e72a200a..1e6167be4052 100755
--- a/arch/arm64/tools/gen-cpucaps.awk
+++ b/arch/arm64/tools/gen-cpucaps.awk
@@ -24,12 +24,12 @@ BEGIN {
}
/^[vA-Z0-9_]+$/ {
- printf("#define ARM64_%-30s\t%d\n", $0, cap_num++)
+ printf("#define ARM64_%-35s\t%d\n", $0, cap_num++)
next
}
END {
- printf("#define ARM64_NCAPS\t\t\t\t%d\n", cap_num)
+ printf("#define ARM64_NCAPS\t\t\t\t\t%d\n", cap_num)
print ""
print "#endif /* __ASM_CPUCAPS_H */"
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64/cpucaps: increase string width to properly format cpucaps.h
2023-05-17 10:04 [PATCH] arm64/cpucaps: increase string width to properly format cpucaps.h Prathu Baronia
@ 2023-05-26 9:28 ` Catalin Marinas
2023-05-27 12:27 ` Prathu Baronia
0 siblings, 1 reply; 5+ messages in thread
From: Catalin Marinas @ 2023-05-26 9:28 UTC (permalink / raw)
To: Prathu Baronia; +Cc: Will Deacon, linux-arm-kernel, linux-kernel
On Wed, May 17, 2023 at 03:34:50PM +0530, Prathu Baronia wrote:
> The lengthiest capability is `WORKAROUND_TRBE_OVERWRITE_FILL_MODE` and
> its length is 35 characters so increase the width of left justified
> strings to 35 and adjust the tab space for `ARM64_NCAPS` accordingly.
> Now the generated cpucaps.h is properly formatted.
>
> Signed-off-by: Prathu Baronia <quic_pbaronia@quicinc.com>
Why not make it larger, say 40, just in case.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64/cpucaps: increase string width to properly format cpucaps.h
2023-05-26 9:28 ` Catalin Marinas
@ 2023-05-27 12:27 ` Prathu Baronia
2023-05-27 12:38 ` [PATCH v2] " Prathu Baronia
0 siblings, 1 reply; 5+ messages in thread
From: Prathu Baronia @ 2023-05-27 12:27 UTC (permalink / raw)
To: Catalin Marinas; +Cc: Will Deacon, linux-arm-kernel, linux-kernel
On Fri, May 26, 2023 at 10:28:22AM +0100, Catalin Marinas wrote:
> Why not make it larger, say 40, just in case.
Sure Catalin, will do in v2.
Prathu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] arm64/cpucaps: increase string width to properly format cpucaps.h
2023-05-27 12:27 ` Prathu Baronia
@ 2023-05-27 12:38 ` Prathu Baronia
2023-06-06 17:30 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Prathu Baronia @ 2023-05-27 12:38 UTC (permalink / raw)
To: quic_pbaronia, Catalin Marinas, Will Deacon, linux-arm-kernel,
linux-kernel
The lengthiest capability is `WORKAROUND_TRBE_OVERWRITE_FILL_MODE` and
its length is 35 characters so increase the width of left justified
strings to 40 and adjust the tab space for `ARM64_NCAPS` accordingly.
Now the generated cpucaps.h is properly formatted.
Signed-off-by: Prathu Baronia <quic_pbaronia@quicinc.com>
---
V1 -> V2: increase the width from 35 to 40
arch/arm64/tools/gen-cpucaps.awk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/tools/gen-cpucaps.awk b/arch/arm64/tools/gen-cpucaps.awk
index 00c9e72a200a..8525980379d7 100755
--- a/arch/arm64/tools/gen-cpucaps.awk
+++ b/arch/arm64/tools/gen-cpucaps.awk
@@ -24,12 +24,12 @@ BEGIN {
}
/^[vA-Z0-9_]+$/ {
- printf("#define ARM64_%-30s\t%d\n", $0, cap_num++)
+ printf("#define ARM64_%-40s\t%d\n", $0, cap_num++)
next
}
END {
- printf("#define ARM64_NCAPS\t\t\t\t%d\n", cap_num)
+ printf("#define ARM64_NCAPS\t\t\t\t\t%d\n", cap_num)
print ""
print "#endif /* __ASM_CPUCAPS_H */"
}
base-commit: 9d646009f65d62d32815f376465a3b92d8d9b046
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-06 17:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 10:04 [PATCH] arm64/cpucaps: increase string width to properly format cpucaps.h Prathu Baronia
2023-05-26 9:28 ` Catalin Marinas
2023-05-27 12:27 ` Prathu Baronia
2023-05-27 12:38 ` [PATCH v2] " Prathu Baronia
2023-06-06 17:30 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).