From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E276C77B7A for ; Fri, 26 May 2023 08:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q3LyJqkRT2c0ArRDFLCHECRfWV+PCO7oOc5ObZmX6CA=; b=QgZA7XZ+8nDilT iujWXVt5i2gBT1+3kxt6ZKe122cZfmG1xaCjqO4lK4wBHSl+Jg8ZUNKjphEUPRNmVj3aZi6VwgomL nVpKtHc0hF324G2CAZlFVNyxtbXY4AO+mN2Qq36nCQOibTA7wz2MSoL/pOpNtyDgYRpCDISJe8w/W nhkYiBwbv4QmQDwfvKmThQlz1DDJmy9ir5RRf+lUQXHorZhx4X4Wzc61OeVuiORFo6iHE0C4j2JXY nJmgBm4S/Zxf4oHIlWrX4n11UKKAVkRR06UOtwMZtq5fP8kxQgNS+YN8KGtnRtyUcnu8nqC4tcBlL OqVrsP+Xa1RZjMJkKdYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2Scg-001Zdt-36; Fri, 26 May 2023 08:16:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2Sce-001ZdG-06 for linux-arm-kernel@lists.infradead.org; Fri, 26 May 2023 08:16:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4700A6489A; Fri, 26 May 2023 08:16:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9A00C433EF; Fri, 26 May 2023 08:16:25 +0000 (UTC) Date: Fri, 26 May 2023 09:16:22 +0100 From: Catalin Marinas To: kernel test robot , Robin Murphy Cc: oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [arm64:devel/kmalloc-minalign 13/15] include/linux/scatterlist.h:257:18: error: 'struct scatterlist' has no member named 'dma_flags' Message-ID: References: <202305260427.aA5xG5kM-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202305260427.aA5xG5kM-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_011628_127455_DABF6F60 X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 26, 2023 at 04:23:54AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git devel/kmalloc-minalign > head: d929a28c8da3f1bc095e4aa0d1b811972929351a > commit: f0b92f544e6b440500c3823c7c47b542816cb4cd [13/15] iommu/dma: Force bouncing if the size is not cacheline-aligned > config: x86_64-buildonly-randconfig-r002-20230524 > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?id=f0b92f544e6b440500c3823c7c47b542816cb4cd > git remote add arm64 https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > git fetch --no-tags arm64 devel/kmalloc-minalign > git checkout f0b92f544e6b440500c3823c7c47b542816cb4cd > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 olddefconfig > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/rapidio/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202305260427.aA5xG5kM-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from include/linux/dma-mapping.h:10, > from drivers/rapidio/rio-scan.c:21: > include/linux/scatterlist.h: In function 'sg_is_dma_use_swiotlb': > >> include/linux/scatterlist.h:257:18: error: 'struct scatterlist' has no member named 'dma_flags' > 257 | return sg->dma_flags & SG_DMA_USE_SWIOTLB; > | ^~ I fixed it as: diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index 330a157c5501..3a1fd9e23a83 100644 --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h @@ -251,7 +251,7 @@ static inline void sg_unmark_end(struct scatterlist *sg) #define SG_DMA_BUS_ADDRESS (1 << 0) #define SG_DMA_USE_SWIOTLB (1 << 1) -#ifdef CONFIG_SWIOTLB +#if defined(CONFIG_IOMMU_DMA) && defined(CONFIG_SWIOTLB) static inline bool sg_is_dma_use_swiotlb(struct scatterlist *sg) { return sg->dma_flags & SG_DMA_USE_SWIOTLB; But I wonder whether we could move these functions in the dma-iommu.c code as they get included in lots of unrelated places. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel