From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21AADC77B7A for ; Fri, 26 May 2023 08:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EjqzyRzkH5nVVVkOD0WjbCDBIybyUuLe/13ylqikAK8=; b=kx6cgPdzEebkma DnRU0avWYz3OsSe7iHeN58WSZp6OF2ODLyxBLOtxj/xw2RwbYdHnhiQtY4LBNem8d3/AJkbv44iM/ +3JAOJwrHPjGgep3eb66qb3iNKWlBfA6SJlKcdy4yCxht19eaeFWVlPbfz6UT4O8MIX1EKRohLLEG RHleBFCeES7sY+KTWLXPPV8tpg9xLTnlUnKOvMTnWRODvqL0Q2RZMsFKubc0JNaRStfCbLIaXv8VD 60agKB3zvRndpQGIu/2InDOJ3QFQVm7IoPrrWsum2C1MT2NKKaJYGFF3PRarjnwvRGyITDBNqGJ5u QSQNXOqS8J7oxs4L1LAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2Sv2-001cly-1M; Fri, 26 May 2023 08:35:28 +0000 Received: from out-30.mta0.migadu.com ([2001:41d0:1004:224b::1e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2Suz-001cl7-1X for linux-arm-kernel@lists.infradead.org; Fri, 26 May 2023 08:35:26 +0000 Date: Fri, 26 May 2023 08:35:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685090121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=60ZRjnDpSzrKHJnFhfQJQPcygblaw4mPC1sJAyo86Gs=; b=imS8kWAWRPLrNaHU9Yj/6vqLATAdhqtPr7EcSVQL+mbuIsBTcFcQzHsjQTxw1/PzTZkTf1 U2NnkWDQpZxliJk4IUsvXWG3Wt/09hNIPIw7xWnd75RrmwTWl0TWZjVBnQbp8sjfjwbnrf vs3/Xm89LSnaQAfSck2DxMZhgX8BUbU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Jun Miao Cc: maz@kernel.org, oliver.upton@linux.de, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH] KVM: arm64: fix typo Message-ID: References: <20230526081548.12729-1-jun.miao@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230526081548.12729-1-jun.miao@intel.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_013525_691654_4FD20553 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jun, The shortlog is too vague. While typo fixes don't need to be exhaustively described, 'Fix typo' doesn't give any indication as to where it is. KVM: arm64: Fix comment typo in hyp_back_vmemmap() On Fri, May 26, 2023 at 04:15:48PM +0800, Jun Miao wrote: > Change "begining" to "beginning" > > Fixes: 8e6bcc3a4502 ("KVM: arm64: Back the hypervisor 'struct hyp_page' array for all memory") This is a misuse of the Fixes tag. A typo in a comment is not a bug. > Signed-off-by: Jun Miao > --- > arch/arm64/kvm/hyp/nvhe/mm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/mm.c b/arch/arm64/kvm/hyp/nvhe/mm.c > index 318298eb3d6b..f16d9f38bb48 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mm.c > +++ b/arch/arm64/kvm/hyp/nvhe/mm.c > @@ -145,7 +145,7 @@ int hyp_back_vmemmap(phys_addr_t back) > start = hyp_memory[i].base; > start = ALIGN_DOWN((u64)hyp_phys_to_page(start), PAGE_SIZE); > /* > - * The begining of the hyp_vmemmap region for the current > + * The beginning of the hyp_vmemmap region for the current > * memblock may already be backed by the page backing the end > * the previous region, so avoid mapping it twice. > */ > -- > 2.32.0 > > -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel