From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2AC0C77B7A for ; Fri, 26 May 2023 10:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=490CQon9p0DeY2nkFtmW0+YI6kyvCi94u2qpHO5qDyk=; b=m67xx3z2OQ6Tfj nnOyBZzxe0tjmLz6iyuvIdbWqx+HVhnlIGiCbQiahHyt0hTTT468sqwzsJLycpcUJsf9SnRxuc8Hp fLQeTW6t1GAIuAO8mvaYptVIjFbq35qB8uAeqTDGi+xr+PvqIjlR8k3lYJO4pXwsjjdKCRqmyq/xs mGDTdabS2qWlJh09hii14QfmWRJKYq1883zikpv8/kk2qoWBTA4N0150rg7RTPHf5aTFamV8P8Gd+ oyy2qoVxRL15PVQXNW7LbRAJCVqqPAKz0OmjolgcIjafwtyq3Bsp4kqJ1HrVJgjOCSZG097c3vLTM qfAQWyOD7aSP43Aho/dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2UuZ-0024Wp-1U; Fri, 26 May 2023 10:43:07 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2UuV-0024Vo-2y for linux-arm-kernel@lists.infradead.org; Fri, 26 May 2023 10:43:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=p6gZGYkzEZra90Ov53s4Zo39rKzj5xOBW7Fj0aYklb4=; b=z2SVF97U2nzlAUNoG+MftZHkYL PMhR8msg2OhhdCekSckaC6W7w/6SkvnvTV6f7iJTsmO+AjyOCYQpLqOfT1SqLqZE34AIAOLnttl5d ACLXlDb2uXTtDQOmHjcJL4HVKdVoaPUVYaG71gb5XNtP3BG+JsXvce+g3yU+HXqlpefXMZCAX/MMG 5O/JDZeB3CVN6dFwgFIgbJtb5MD5GomD5byTvFGwRnmGtAjAuSgDb0VqJwv90NnELymwnlU2S1RoS 2zfVNxzXIQGXBSVt3vHaDKiY71T0YSfVXAmYuDn73enIqJ+w6RkSLg10gZp5GSFfmev5ifto0pnRK d+EfC/FQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35688) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q2UuK-0005Sz-S2; Fri, 26 May 2023 11:42:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q2UuI-0003fU-VC; Fri, 26 May 2023 11:42:50 +0100 Date: Fri, 26 May 2023 11:42:50 +0100 From: "Russell King (Oracle)" To: Simon Horman Cc: Maxime Chevallier , Mark Brown , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro Subject: Re: [PATCH net-next v3 2/4] net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx Message-ID: References: <20230526074252.480200-1-maxime.chevallier@bootlin.com> <20230526074252.480200-3-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_034303_962971_B0E9FBD5 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 26, 2023 at 10:05:17AM +0100, Russell King (Oracle) wrote: > On Fri, May 26, 2023 at 10:39:08AM +0200, Simon Horman wrote: > > On Fri, May 26, 2023 at 09:42:50AM +0200, Maxime Chevallier wrote: > > > The newly introduced regmap-based MDIO driver allows for an easy mapping > > > of an mdiodevice onto the memory-mapped TSE PCS, which is actually a > > > Lynx PCS. > > > > > > Convert Altera TSE to use this PCS instead of the pcs-altera-tse, which > > > is nothing more than a memory-mapped Lynx PCS. > > > > > > Signed-off-by: Maxime Chevallier > > > > Hi Maxime, > > > > I have some concerns about the error paths in this patch. > > We've had similar problems with mdio_device_create() vs the XPCS > driver. > > I think it's time that we made this easier for users. Patch series here: https://lore.kernel.org/all/ZHCGZ8IgAAwr8bla@shell.armlinux.org.uk/ -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel