From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 615D7C77B7A for ; Wed, 7 Jun 2023 05:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oR/H6njTvu3h+yetrRwQSNGbS9qUSZRqxsI1fDLLCFo=; b=PBttke32Bx7jjL bk3PyoJu0yL86PfgB6VvermB0U59x49LMtm0HOHlYyNHUqHC483iLvQ8k4jSfE3OAeXeaFrObrFpz 1PeTE8azULHW96t/KM6qmRsLpU6KgcFScdkhoBO6ZIGmaoCdtq1L5cxSc4774Q6tGRR2Pl2MCsLwm my9APIKKYGTeNQDYs/q9AWxZOwAruyqqLtoSF3+e8n7EZZ/DRaDab0CzcTRUkD1uwp7NaoXaTAgD2 crztDXFNPQgyadTtT9oxNiVnVUAxpzu9wtGkATk4WLf9YPsZOGSiaczAFVSVnIhMxw/rkmvq/NWet HL/6qKVs5lBdGyNGGC2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6ldz-004QDk-1S; Wed, 07 Jun 2023 05:23:39 +0000 Received: from out-17.mta0.migadu.com ([2001:41d0:1004:224b::11]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6lds-004QCW-2E for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 05:23:34 +0000 Date: Wed, 7 Jun 2023 05:23:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686115408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+Aj/XbFSOUfLahtXChuiRjMB9iC5cvqz6gn2we+qXTA=; b=KMWHPoG57mhrVuLDKkoTgUuppTYntt2BMk50y4c750zlw9pLka1wI1/5N5x/8fTQYzfnc2 jglD6sF/KmBDb3JM83vAMYBJaAr4s8yCTk6UDmTiyGKGPEb266hdxehpx9QgSQjddmvati 7zoudwJ/7qb/l6ZLXFynvLdqSm4livo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Nathan Chancellor Cc: Jean-Philippe Brucker , maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH 1/4] KVM: arm64: vgic: Fix a circular locking issue Message-ID: References: <20230518100914.2837292-1-jean-philippe@linaro.org> <20230518100914.2837292-2-jean-philippe@linaro.org> <20230606221525.GA2269598@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230606221525.GA2269598@dev-arch.thelio-3990X> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_222333_227138_BEC9B4A4 X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nathan, First and foremost, thanks for testing this. On Tue, Jun 06, 2023 at 03:15:25PM -0700, Nathan Chancellor wrote: > My apologies if this has been addressed or reported somewhere, I did a > search of lore.kernel.org and browsed the kvmarm archives and did not > see anything. This is news to me, but even if it had already been reported there's nothing wrong with bumping the issue. Makes it hard for us to bury our heads in the sand :) > After this change landed in 6.4-rc5 as commit 59112e9c390b > ("KVM: arm64: vgic: Fix a circular locking issue"), my QEMU Fedora VM on > my SolidRun Honeycomb fails to get to GRUB. [...] > I built a kernel with CONFIG_PROVE_LOCKING=y but I do not see any splats > while this is occurring. Additionally, neither my Raspberry Pi 4 or my > Ampere Altra system have any issues, so it is possible this could be a > platform specific problem. I am more than happy to provide any > additional information and test kernels and patches to help get to the > bottom of this. My kernel configuration is attached. I was unable to reproduce the issues you're seeing on 6.4-rc5, but I don't have any different machines from you available atm. Based on your description it sounds like your VM was able to do _something_ since it sounds like a few escape codes got out over serial... I'm wondering if you're getting wedged somewhere on a VGIC MMIO access. We don't have a precise tracepoint for VGIC accesses, but kvm:kvm_mmio should do the trick. So, given that you're the lucky winner at reproducing this bug right now, do you mind collecting a dump from that tracepoint and sharing the access that happens before your VM gets wedged? Curious if Marc has any additional insight, since (unsurprisingly) he has a lot more experience in dealing with the GIC than I. In the meantime I'll stare at the locking flows and see if anything stands out. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel