From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89FB2C7EE29 for ; Wed, 7 Jun 2023 12:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hVUiN/W0glyTrwYryWLd3aTCFCBoPRGzrBvk94OyfDQ=; b=FXJrVTqDc9uyFA tDNfFye/W7WBtMG7Nbso1EURz/Zw/pehAiZomnsi7wYCKuoPwLOeUzh9egoh2HbjDcQRQigvrC0RT dGV68yM37lSV2bvFylLV31ynMCfebC7ZnrBfaS6Pz5zPbvhvDu0nEd/Vg5SSolsYJkq8gSgQS0dNs 05r0qz3pUzl34dCZfHQ263aUCfEIO26d8VTfaFkv1zBQnt17A30mIE8y1krw1CPZSepn3BIjFdtvS FdIw8E5qk6Kw5TD7CtIjwqxHCRwz78CTmFY/UqJ5zco49EtlgP0I9gKtqYKNBeUJUjePBaDUfp4Ml B9htXfeurbaAjuPAw0dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6sGy-005ti7-0X; Wed, 07 Jun 2023 12:28:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6sGu-005tgV-2a for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 12:28:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9hGNfPqy1eUDG1MxjAovTEo2hv9ydEwCjThfFtD62V0=; b=Xymg1OYf0zp1P4oz1XqyngsKjJ pacW7XqodlQqyQ8tP87fOr1L2/hdHP9JZlrNENhg1IsJhbFxO0WbWOGbl9yCx2UWy7mG80/q42N2M 4zqhd9uvRXVk5JoSCRFSUk3O3Hrzuz+D79rvm7/mCun0kuOt7EWokCPHpSiVBAU9btHwPA5GODB9B UPAYN+/FoG7OVcgunGUn5sPV341OSPUsn0J+ctVmO4f19io9+dEhJv23mGQmOWN9NYjXatb+rkbjd Li0ecXIc4EaQdDB4nH5F51V7DvsL0PI1p46ZNxmHdgjqCNSv/FjrUz5IYtnxOXRNF9XkEgaVOAJF3 dWwi3G6A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55016) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q6sGj-0007RD-Rn; Wed, 07 Jun 2023 13:28:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q6sGh-0008DQ-S6; Wed, 07 Jun 2023 13:28:03 +0100 Date: Wed, 7 Jun 2023 13:28:03 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman , Maciej Fijalkowski , Feiyang Chen Subject: Re: [PATCH net-next v4 5/5] net: dwmac_socfpga: initialize local data for mdio regmap configuration Message-ID: References: <20230607135941.407054-1-maxime.chevallier@bootlin.com> <20230607135941.407054-6-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607135941.407054-6-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_052816_837341_39D67132 X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 03:59:41PM +0200, Maxime Chevallier wrote: > @@ -447,19 +446,22 @@ static int socfpga_dwmac_probe(struct platform_device *pdev) > struct mdio_regmap_config mrc; > struct regmap *pcs_regmap; > struct mii_bus *pcs_bus; > ... > + memset(&mrc, 0, sizeof(mrc)); ... > mrc.parent = &pdev->dev; > mrc.valid_addr = 0x0; > + mrc.autoscan = false; Isn't this covered by the memset() ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel