From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60E69C7EE23 for ; Wed, 7 Jun 2023 14:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FR7/f1q21zdQ5NQjhXwKb/zbsTVJK/wuxYbC/wy8gSg=; b=TY2nzmjajMRlhF QpQh3EmA7vgKXSui8agT37Hp0SHm+0urdHNM0ZJ+iV4HNX3m7zvuK9iureaIImj7AA9FFnIDSc1p9 llOYSizIN+flJj8hxBrx8X02angNRRxJjBLfS4NwXpih6qCTlNAsLojuk/GddNYqWLpop258THNZ5 JM6kM780faDX72AygC9ERC4p/ygMhML9pDHffZp5uL2GeaLnqT4TVqUFCmiGwNZ4UpIsCUcxQBhDm oATsfLW4sDTQdUI75Rqu/s/rseTbFOjahj6/wN4mg67WE71MC3EwCqDk/SURYDNdNhJ7ruhcAWPea qfbTRsfwELcmp0gf1arA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6tik-006BQ4-39; Wed, 07 Jun 2023 14:01:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6tie-006BJG-2I for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 14:01:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 198C9AB6; Wed, 7 Jun 2023 07:01:41 -0700 (PDT) Received: from e120325.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDD9B3F587; Wed, 7 Jun 2023 07:00:52 -0700 (PDT) Date: Wed, 7 Jun 2023 15:00:49 +0100 From: Beata Michalska To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, mark.rutland@arm.com, will@kernel.org, rafael@kernel.org, viresh.kumar@linaro.org, ionela.voinescu@arm.com, sumitg@nvidia.com, yang@os.amperecomputing.com Subject: Re: [PATCH] arm64: Provide an AMU-based version of arch_freq_get_on_cpu Message-ID: References: <20230606155754.245998-1-beata.michalska@arm.com> <20230607095856.7nyv7vzuehceudnl@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607095856.7nyv7vzuehceudnl@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_070100_796636_5A7D783F X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 10:58:56AM +0100, Sudeep Holla wrote: > On Tue, Jun 06, 2023 at 04:57:54PM +0100, Beata Michalska wrote: > > With the Frequency Invariance Engine (FIE) being already wired up with > > sched tick and making use of relevant (core counter and constant > > counter) AMU counters, getting the current frequency for a given CPU > > on supported platforms, can be achieved by utilizing the frequency scale > > factor which reflects an average CPU frequency for the last tick period > > length. > > > > With that at hand, arch_freq_get_on_cpu dedicated implementation > > gets enrolled into cpuinfo_cur_freq policy sysfs attribute handler, > > which is expected to represent the current frequency of a given CPU, > > as obtained by the hardware. This is exactly the type of feedback that > > cycle counters provide. > > > > In order to avoid calling arch_freq_get_on_cpu from the scaling_cur_freq > > attribute handler for platforms that do provide cpuinfo_cur_freq, and > > yet keeping things intact for those platform that do not, its use gets > > conditioned on the presence of cpufreq_driver (*get) callback (which also > > seems to be the case for creating cpuinfo_cur_freq attribute). > > > > LGTM, > > Reviewed-by: Sudeep Holla > Thanks for the review. > However I fail to understand if both the changes are dependent ? > Can this be split into 2 patches ? I fail to see the dependency, what > am I missing ? Even if there is some dependency to get arch value > (arch_freq_get_on_cpu() from show_cpuinfo_cur_freq()), you can push > that change first followed by the arm64 change as 2 different change. > I guess I could split the patch into two parts: 1. adding implementation for the arch_freq_get_on_cpu 2. wiring it up with the cpufreq relevant attrib handlers or the other way round (if that's what you have in mind). Will wait a bit for any further comments before pushing new v. --- BR B. > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel