linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "wsa@kernel.org" <wsa@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Robert Hancock <robert.hancock@calian.com>,
	"michal.simek@amd.com" <michal.simek@amd.com>,
	"shubhraj@xilinx.com" <shubhraj@xilinx.com>,
	"marex@denx.de" <marex@denx.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: xiic: Don't try to handle more interrupt events after error
Date: Fri, 9 Jun 2023 17:32:42 +0200	[thread overview]
Message-ID: <ZINGGmRLYEQ+NfkI@shikoro> (raw)
In-Reply-To: <20230606212053.bwpoxyost4fkpati@intel.intel>


[-- Attachment #1.1: Type: text/plain, Size: 570 bytes --]


> I think the patch is correct and I will ack it:
> 
> Acked-by: Andi Shyti <andi.shyti@kernel.org> 
> 
> I think, though, that this needs a proper fix and testing, in
> order to cover all the possible combinations. The scenario you
> highlighted is indeed one, but not only, potential situation that
> could arise.
> 
> Can I just ask you to write a bit more in the comment to 
> highlight the possible failure?

I tend to apply it to for-current because it improves the situation.
Further improvements could be made incrementally? D'accord everyone?


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-09 15:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 18:25 [PATCH] i2c: xiic: Don't try to handle more interrupt events after error Robert Hancock
2023-06-06 19:24 ` Andi Shyti
2023-06-06 19:40   ` Robert Hancock
2023-06-06 21:20     ` Andi Shyti
2023-06-09 15:32       ` wsa [this message]
2023-06-09 21:25         ` Andi Shyti
2023-06-27 16:13           ` Robert Hancock
2023-06-27 21:25             ` wsa
2023-07-06 19:33 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZINGGmRLYEQ+NfkI@shikoro \
    --to=wsa@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=michal.simek@amd.com \
    --cc=robert.hancock@calian.com \
    --cc=shubhraj@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).