From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32EFAC7EE2E for ; Tue, 13 Jun 2023 00:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6ZUh0ylfw04NYki3LHvYew4aO+jwa1XXz95j8rkHqGg=; b=PKmxmR+bm9KoydQjg1fqqqTroY YNL9Ps91hQrt3lomg9CEXSlsJv3IhkMFBIMm64h3g9GSPWmYLk88/yl5o2sfdz2CgKNsgYBHgp/Au SrT98wDh/k9Pl3Y/tdE940HNJb+0pbJMZs6stcuAqCmuNixtXyQM1Pshg+RWFWEA/eDUjv8Vbyyb6 6auppER00Xkkan/FalgYntthPoV/gkY/YycIy10P+CQB0+fwaGUztxpClMPMXbODMpmfvDsnT05vz nOaTXnPJPufdLf+1FOCnir9Ate+N7f6zJPS5er/iPHe96zctRsktu7CCZHgkx/4cLyQT8GYzhfhg1 owpqNySQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8sJT-006Te6-2g; Tue, 13 Jun 2023 00:55:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8sJR-006Tco-1T for linux-arm-kernel@bombadil.infradead.org; Tue, 13 Jun 2023 00:55:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kTZtyuUlXixxMxO/No1lfJ4jfgIlGKSKtZpjkWwouX4=; b=OGB3ti3AyuevVb0t4OOKCvghO3 Au+fCWzoSjjTeNfyrh5p784swQV9QdaNB/1MNPqiMd3sAaDZ1n8McFZg9vp+dfiayZPAEk5qe1z6G ICM2hWgCY/6pH/7Oh83Jp2vzEe0TcHnVcvY848zgKZvs+JYqyx6ChniqQKf3Vkhbrdhf+1lJjf3LK e7cs9x494TBaAU8Wel01I2zgcdJtQh45O1rUMewDPOz8Ond4NmB6NUi63ZBMwTDUhXEkGJQWw9mfi Qh3TXJ5miRKKsYlTlTJ4xhzmRbUhgM3VxnpTUwY3yp0JrXX1PK+vs/tGFV9Ai0vho4pyaLefWNZiX 51u4fR3g==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8pq3-0092d7-1f for linux-arm-kernel@lists.infradead.org; Mon, 12 Jun 2023 22:16:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686608195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kTZtyuUlXixxMxO/No1lfJ4jfgIlGKSKtZpjkWwouX4=; b=DtHxAP0e9o9nTKYopjuWtKGSDiTfqclAtwU7NdRj8mcFWrfquNGIQRYJlOGvhj4WRSQwFc prLjvK0C/0cURZHvZws9jwNf28ZG4FvUDmfQZ7l3J4xhJzLOTCxa4qDKN9RVv+yzFo5qbD ZkHaYqsGrwlhH1Bb6yn7KCxOeIOfWpU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686608196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kTZtyuUlXixxMxO/No1lfJ4jfgIlGKSKtZpjkWwouX4=; b=fTitREHVa0sm2PUqBdir/Du2Q7z7IDoirokxfuqf/3kXTAbJnAfIb3FrTiq1EwaKOJOI7i UXTcmaIbDUJfso2eOw+navGM9TEeSOHh3EgMs7B07Ct5mRlreY1NomQv8KT3mntIXxRYtP 9/AiUwSICWvyzCgwByzV+nDTM7p6C2E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-U4usXITDPe2Jp1TgNQ8iNQ-1; Mon, 12 Jun 2023 18:16:34 -0400 X-MC-Unique: U4usXITDPe2Jp1TgNQ8iNQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30e6153f0eeso1825812f8f.0 for ; Mon, 12 Jun 2023 15:16:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686608193; x=1689200193; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kTZtyuUlXixxMxO/No1lfJ4jfgIlGKSKtZpjkWwouX4=; b=VGFdcAQEfJeLNldmqLI7sXVGfSalJwFa7WhqN5d5OgCy3J4gqBkQQS1cjeqsyK+K5g xIxk45BDAfA0+HEf/stoXimAoad0ZgybAhYhYNbMi6g3TmWQvA3LN/ou4Yie/K96V/he kCODVXlpmMV/6UQK5xPBL2CYTPPEwZ3gRSnegROyC+WLsK1YChr4ONjqGymOMtfOBCxf Q6P0t4V4TCevTmgtr5qjKJ1tU7nvV70YgWyfOfulIiY6CffyWio9W+SxlxnnX53ryoWS n83tVn43lj9Au0hZ2BXA77IWpNp+30DOQGYlMZN3HxQisWQLGhnNVpUtTm8tjFVLqGIB dy2w== X-Gm-Message-State: AC+VfDwJ49wHY+UhVAAxrhOTiwiI7aNUpfIRoMrN42dB04AD0jd0LFqj 9ZqAa1oLWi6tOe2qpILL6hpmQGmRzoyYX122iI95jnQ8O/2rj4hDCaJ6oc7c9g0sCzQrEFrZt07 JBWIZfRVsedVsTuia/BxABhNVGMqSKnEZmdA= X-Received: by 2002:a5d:4c88:0:b0:30f:bb0c:a2c0 with SMTP id z8-20020a5d4c88000000b0030fbb0ca2c0mr3763722wrs.5.1686608193383; Mon, 12 Jun 2023 15:16:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6vhzxAZAyN5mFmZdbyQbsrTmXIEJTazMrYY97aHI+UWILU1SiUfJAeHgaq8ps1Vzz+ZOsSqw== X-Received: by 2002:a5d:4c88:0:b0:30f:bb0c:a2c0 with SMTP id z8-20020a5d4c88000000b0030fbb0ca2c0mr3763713wrs.5.1686608193039; Mon, 12 Jun 2023 15:16:33 -0700 (PDT) Received: from localhost (net-130-25-106-149.cust.vodafonedsl.it. [130.25.106.149]) by smtp.gmail.com with ESMTPSA id e4-20020adfdbc4000000b0030ada01ca78sm13512230wrj.10.2023.06.12.15.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 15:16:32 -0700 (PDT) Date: Tue, 13 Jun 2023 00:16:30 +0200 From: Lorenzo Bianconi To: "Russell King (Oracle)" Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, AngeloGioacchino Del Regno , Matthias Brugger , Lorenzo Bianconi , Mark Lee , Sean Wang , John Crispin , Felix Fietkau , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Sam Shih Subject: Re: [PATCH net-next 5/8] net: ethernet: mtk_eth_soc: add MTK_NETSYS_V3 capability bit Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_231639_842150_A917943E X-CRM114-Status: GOOD ( 25.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3681346160790237526==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3681346160790237526== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MZEWyw36ZZKq14wi" Content-Disposition: inline --MZEWyw36ZZKq14wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Sun, Jun 11, 2023 at 01:38:23AM +0100, Daniel Golle wrote: > > @@ -1333,8 +1354,13 @@ static int mtk_tx_map(struct sk_buff *skb, struc= t net_device *dev, > > mtk_tx_set_dma_desc(dev, itxd, &txd_info); > > =20 > > itx_buf->flags |=3D MTK_TX_FLAGS_SINGLE0; > > - itx_buf->flags |=3D (!mac->id) ? MTK_TX_FLAGS_FPORT0 : > > - MTK_TX_FLAGS_FPORT1; > > + if (mac->id =3D=3D MTK_GMAC1_ID) > > + itx_buf->flags |=3D MTK_TX_FLAGS_FPORT0; > > + else if (mac->id =3D=3D MTK_GMAC2_ID) > > + itx_buf->flags |=3D MTK_TX_FLAGS_FPORT1; > > + else > > + itx_buf->flags |=3D MTK_TX_FLAGS_FPORT2; >=20 > There appears to be two places that this code structure appears, and > this is in the path for packet transmission. I wonder if it would be > more efficient to instead do: >=20 > itx_buf->flags |=3D MTK_TX_FLAGS_SINGLE0 | mac->tx_flags; >=20 > with mac->tx_flags appropriately initialised? >=20 > > @@ -2170,7 +2214,9 @@ static int mtk_poll_tx_qdma(struct mtk_eth *eth, = int budget, > > tx_buf =3D mtk_desc_to_tx_buf(ring, desc, > > eth->soc->txrx.txd_size); > > if (tx_buf->flags & MTK_TX_FLAGS_FPORT1) > > - mac =3D 1; > > + mac =3D MTK_GMAC2_ID; > > + else if (tx_buf->flags & MTK_TX_FLAGS_FPORT2) > > + mac =3D MTK_GMAC3_ID; >=20 > This has me wondering whether the flags are used for hardware or just > for the driver's purposes. If it's the latter, can we instead store the > MAC index in tx_buf, rather than having to decode a bitfield? >=20 > I suspect these are just for the driver given that the addition of > MTK_TX_FLAGS_FPORT2 changes all subsequent bit numbers in this struct > member. ack, I agree. I will rework it. Regards, Lorenzo >=20 > > =20 > > if (!tx_buf->data) > > break; > > @@ -3783,7 +3829,26 @@ static int mtk_hw_init(struct mtk_eth *eth, bool= reset) > > mtk_w32(eth, eth->soc->txrx.rx_irq_done_mask, reg_map->qdma.int_grp += 4); > > mtk_w32(eth, 0x21021000, MTK_FE_INT_GRP); > > =20 > > - if (MTK_HAS_CAPS(eth->soc->caps, MTK_NETSYS_V2)) { > > + if (MTK_HAS_CAPS(eth->soc->caps, MTK_NETSYS_V3)) { > > + /* PSE should not drop port1, port8 and port9 packets */ > > + mtk_w32(eth, 0x00000302, PSE_DROP_CFG); > > + > > + /* GDM and CDM Threshold */ > > + mtk_w32(eth, 0x00000707, MTK_CDMW0_THRES); > > + mtk_w32(eth, 0x00000077, MTK_CDMW1_THRES); > > + > > + /* Disable GDM1 RX CRC stripping */ > > + val =3D mtk_r32(eth, MTK_GDMA_FWD_CFG(0)); > > + val &=3D ~MTK_GDMA_STRP_CRC; > > + mtk_w32(eth, val, MTK_GDMA_FWD_CFG(0)); >=20 > mtk_m32() ? >=20 > Thanks! >=20 > --=20 > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! >=20 --MZEWyw36ZZKq14wi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZIeZPgAKCRA6cBh0uS2t rOWZAP93LCOL1i0nkHkj6wrpRzOraRpEoqEK3GPo84WYL1nFzQEAs2hJgVY3XzfF KF3PwyoYttShSk1kgjn4c0xzXmKqKgU= =Fpo3 -----END PGP SIGNATURE----- --MZEWyw36ZZKq14wi-- --===============3681346160790237526== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3681346160790237526==--