From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF55AEB64D9 for ; Wed, 14 Jun 2023 12:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5ugaZOYCrBDP6TjnnQ6JwYIdWvslnQyaJVzYdnQLqtI=; b=hxjT5eqdN+KqA9 zC4VCOZYAdELe50buYmt5zhS9NZYt+ieKFCg2/LKr4l1S4YetKV/k/dRA4WaKUXfr4TykyTNH+l3k xwbZnesMlohjgJEjN2M0KuC/D9SwALOhkdTLr/O/aN1QMPUpzZg7sRBN84DIDtavK2ZGTLkInQ7Tb GGQIB6+jQb4ziGRZyGt0cWj5ozoWHxClBk7BQI2wzLIedpBNYLkL0T8hbjfSSwWOopnCfS3r+iTxk sF4bY/GGaOz0MLoKeRHI+0p2hmMZM/mrQEe/uU4B1O6eVmrT19ID7YSBiwgBpErNkas7VLZPP+k9Y KTuy4TGWOX3ghTGmPcEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9Pp7-00BeKh-0Y; Wed, 14 Jun 2023 12:42:05 +0000 Received: from out-54.mta1.migadu.com ([95.215.58.54]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9Pp4-00BeKA-1e for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 12:42:04 +0000 Date: Wed, 14 Jun 2023 12:41:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686746518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vVgohHr+8y/naKxQ8awxRJilZdLTVuzyEw7fAcdG64A=; b=vXtoWCWGoWUj4X5qVEdoEmWU3Lyx+lZaNsCO4a9ZC729SBpKTdzHAGvXWIq1eE6BaF+f5C I3pxRCZKlinyC6IeKMy0sqHImLvoZTu17N/DA0fxQBR4wOWyX1CWIFKgz0mI3m8GDtNr7l D7Q2U/q5bDPVLB5U2ddsJl1pTPLiTaI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Reiji Watanabe Cc: Marc Zyngier , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Zenghui Yu , Suzuki K Poulose , Jing Zhang , Raghavendra Rao Anata Subject: Re: [PATCH 1/1] KVM: arm64: PMU: Avoid inappropriate use of host's PMUVer Message-ID: References: <20230610194510.4146549-1-reijiw@google.com> <20230611045430.evkcp4py4yuw5qgr@google.com> <20230611160105.orvjohigsaevkcrf@google.com> <20230613002633.gdttlmn5bnkr4l5i@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230613002633.gdttlmn5bnkr4l5i@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_054202_988855_7253C3C9 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 05:26:33PM -0700, Reiji Watanabe wrote: > On Mon, Jun 12, 2023 at 09:36:38PM +0200, Oliver Upton wrote: > > I'd rather we start exposing the feature when we provide all the > > necessary detail. > > To confirm, are you suggesting to stop exposing the event even on hosts > w/o PMMIR_EL1 until KVM gets ready to support PMMIR_EL1 ? > (guests on those hosts won't get PMMIR_EL1 in any case though?) > Could you please explain why ? > > Perhaps I think I would rather keep the code as it is? > (since I'm simply not sure what would be the benefits of that) I'd rather not keep confusing code hanging around. The fact that KVM does not support the STALL_SLOTS event is invariant of both the hardware PMU implementation and the userspace value for the ID register field. Let's make sure the implementation exactly matches this position. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel