From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EA84EB64D9 for ; Wed, 14 Jun 2023 12:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4bjrb08IzkYLI9QeEWYkRN7YxdN1m2ud4AcWrA6QlEA=; b=GCwmbC60DsZIUw cfTr1uWR+KhL+M9SJk3bDryRM0gbjsNH682U51qvTxYfxfSsFtLXrTtuUA5S0YT+OMTT1mDLYFtjl Pj51l12OClCawCt6xd56DxU/A+V0WPe3jDC/C0lS3XvB/uA0KjW06ilfXdjlAfQt4LIad5pWn2Gru NQjdcnXXr5Wsh5AXZZoikVJxjHHz+odBqo9+BZuEuyA6XVe9yTNLOR9Nyu4m0TCGjGjYy9V7ndgrU 4Qr1RlKRulTfBIOHiu5sKT5b3scFohmzrdsoCMfLZ9KQj1MGBvO3c6upwyqq5Ilq714Vjot9KSrb9 yp4zO731s1NXtZka5/ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9PXN-00Bc5V-0H; Wed, 14 Jun 2023 12:23:45 +0000 Received: from out-11.mta0.migadu.com ([91.218.175.11]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9PXJ-00Bc3P-2B for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 12:23:43 +0000 Date: Wed, 14 Jun 2023 12:23:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686745418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wQb4z5JVMfEidGknQD3xscf32z72ie53CeaTZ4MqnRo=; b=VDJHBwbnWvVpVV2I5wdZ1dSmkV4OW6DcXGB7WkRvbQbH6ER5gTv95Aul+DGOp3MA8pjOAX 0zLmfb5AUIxalCYMg97MGheRtghN8tPVWj5eSM3htLfyZm7zxBgdLPibhTnINAzEYZORpr wAQ4FhHqgISs2x21TFI+MTTB8WH2WY8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sean Christopherson Cc: Wei Wang , pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH RESEND v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check Message-ID: References: <20230315101606.10636-1-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_052341_860104_4C462D89 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 13, 2023 at 02:16:16PM -0700, Sean Christopherson wrote: > + > > Please use scripts/get_maintainer.pl to generate the To/Cc lists. This may be > trivial, but it still needs eyeballs from the relevant maintainers. +1000. I'd buy someone a beer if they made a bot that just ran get_maintainer on patches that hit the list :) > On Wed, Mar 15, 2023, Wei Wang wrote: > > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device > > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move > > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons: > > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO). > > For example, userspace VFIO implementation may needs to create > > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it > > checked at the generic code than at each arch's code. > > 2) KVM_CREATE_DEVICE has been added to the generic code. > > > > Link: https://lore.kernel.org/all/20221215115207.14784-1-wei.w.wang@intel.com > > Signed-off-by: Wei Wang > > Reviewed-by: Sean Christopherson > > --- > > arch/arm64/kvm/arm.c | 1 - > > arch/powerpc/kvm/powerpc.c | 1 - > > arch/riscv/kvm/vm.c | 1 - > > arch/s390/kvm/kvm-s390.c | 1 - > > virt/kvm/kvm_main.c | 1 + > > 5 files changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index 3bd732eaf087..96329e675771 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -202,7 +202,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > > r = vgic_present; > > break; > > case KVM_CAP_IOEVENTFD: > > - case KVM_CAP_DEVICE_CTRL: > > case KVM_CAP_USER_MEMORY: > > case KVM_CAP_SYNC_MMU: > > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS: for arm64: Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel