From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5FC2EB64D8 for ; Wed, 14 Jun 2023 23:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=52eaHoblwIZ5BPap8V42Ng4995h58yzTeTa/LRzMDHo=; b=ErAatdZe/xNeod 4SnrklEOCowArVEebJyqDotvsnO/ERlb8az7FZOil8cU9REFujK/ZSuKN7354moDmMP0XI1+RsPB7 2Od2S4e9WKSEYV9wrN+JgbMFrSjmdkep7lw1u4Zy0YldENEdjS7qq0ufodNFcm44+2YJDRTtskUjD LXAM6a3McnXUY2VIWi2yZLVWyTul4TXSFP29ic8vB2WtE95RT7NofuYDGyRuntq8YGt/Wiuzp1gOx e0pDqXiy46n44MtTzF0pRSwhXS3us1D5aiodOVvTXBdfolA2hwBgnzRz8jwYeCfiPrWBPn/ojHaZk w1da/Ot5n9j6S6WxWMow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9aKp-00D5Td-1b; Wed, 14 Jun 2023 23:55:31 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9aKn-00D5Sw-1V for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 23:55:30 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1b3e3f33e33so83215ad.0 for ; Wed, 14 Jun 2023 16:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686786927; x=1689378927; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cp8A+EkiL0VYJVNToeqPquceOf+WVhmFookr8OmaRSM=; b=Pf4mNAMn9dp36uBXyHz5uNXAjSQ4WYXHKBb2JMlBKTTRzb2BLWNto0F8B2d2/+tVBB IISvciJ6L2DBe+qRhbWFmtkLfrflUm/aUmxcEfxGIwEUPNPUb2rfS9cnniqVH3GNjo5u JELvww7og3gzZyrQzIJfpYaMKrhKTNlk7n/q9e5KAxJAklyLW8Kiyed8IiqRv4thceR3 Ale9dLKP8uUuLq/J8kt95IcPg1U+DE0y+l0FjjcShQZ/aErLILik0i5/r+nytzfRPAgd 4Y9+M6DlE4l/z/Ty3v6/aY48Ov8bOB2pMIngjCGP5oGtmY5bpI2jbrEDOzqPLWRFyXZC tTQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686786927; x=1689378927; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cp8A+EkiL0VYJVNToeqPquceOf+WVhmFookr8OmaRSM=; b=LfLbka2FBSjzKfyUY0biau/10o7UOOnuh/xNuOB1d1Ia27BOxbldHc/xvVFNVlWriQ KD66/p9LST0GASqo8BgxyMonsnpBywF98UbHbgP9NHXfrctfzvRSBM7xBT1n9bA+6Qz9 VVNnkCSSX/1MFMrYay2qpEuBy6T0W1Qv6SSejxWNZob2cuHYSylXpR4whDieL5Xs1t6m X8zYAtrZHNceYb+OQziAjTIS2q78C1BRRQfLdD2hT250ays0x5X6+CoLMG5889Mg8YSJ 6tvsqo2hLCniknZDsGEiWkvXpdGJKVIJb701qhGJnAjSXUM9kb28WHVcbTh4XgQDmZdw tgUg== X-Gm-Message-State: AC+VfDzUAz4nifiduA7N6UnGJ/BTIJD8x2Ex1eiSRn0WaIWsUr7PUrzG 6cIS6HhZGimMppZ+Ew/h9di7tA== X-Google-Smtp-Source: ACHHUZ4LZ3tbRG7AocVYuv1WtNna6ocaxw45maUfrbQyz+pehk7SJKYGZchCEC1ssOUIwjWnOtBZrg== X-Received: by 2002:a17:903:5cb:b0:1b0:4687:ba19 with SMTP id kf11-20020a17090305cb00b001b04687ba19mr108329plb.10.1686786927017; Wed, 14 Jun 2023 16:55:27 -0700 (PDT) Received: from google.com ([2620:15c:2d:3:ac7a:bf2e:1950:e94c]) by smtp.gmail.com with ESMTPSA id b17-20020aa78111000000b006542e358721sm10853520pfi.186.2023.06.14.16.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 16:55:26 -0700 (PDT) Date: Wed, 14 Jun 2023 16:55:21 -0700 From: Isaac Manjarres To: Christoph Hellwig Cc: Tomonori Fujita , Petr =?utf-8?B?VGVzYcWZw61r?= , Ard Biesheuvel , Catalin Marinas , Linus Torvalds , Robin Murphy , Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Jonathan Cameron , "linux-mm@kvack.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , FUJITA Tomonori , Konrad Rzeszutek Wilk Subject: Re: [PATCH v6 00/17] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: References: <20230531154836.1366225-1-catalin.marinas@arm.com> <20230609101156.6f17e3c6@meshulam.tesarici.cz> <20230612074755.GA24234@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230612074755.GA24234@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_165529_508885_012FFEF6 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 09:47:55AM +0200, Christoph Hellwig wrote: > On Mon, Jun 12, 2023 at 07:44:46AM +0000, Tomonori Fujita wrote: > > I cannot recall the patch but from quick look, moving trace_swiotlb_bounced() to > > swiotlb_tbl_map_single() makes sense. > > Agreed. There's actually two call-sites for trace_swiotlb_bounced(): swiotlb_map() and xen_swiotlb_map_page(). Both those functions also invoke swiotlb_tbl_map_single(), so moving the call to trace_swiotlb_bounced() to swiotlb_tbl_map_single() means that there will be 2 traces per bounce buffering event. The difference between the two call-sites of trace_swiotlb_bounced() is that the call in swiotlb_map() uses phys_to_dma() for the device address, while xen_swiotlb_map_page() uses xen_phys_to_dma(). Would it make sense to move the trace_swiotlb_bounced() call to swiotlb_tbl_map_single() and then introduce a swiotlb_tbl_map_single_notrace() function which doesn't do the tracing, and xen_swiotlb_map_page() can call this? --Isaac _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel