From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D6FEEB64D9 for ; Thu, 15 Jun 2023 15:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4oWTX+1WBoC6kzt6VF9cXLQcledtjLmYgln3ecnIJI=; b=D0dJCQ+9owRAZ7 I4/6171SuqFAz/NdQSjRkEG4N6IKVG5bopTDcauJ1SvnYRvYWD0LgL6jvHmqitpxaQfKNxP4KG+EH vTAoMVt30o+ALO9lDpqkIMmTqUD2mfZMaHJ5b5HZtHDrfneM+YA0GT/tVBuehslbJpA722gvFbJyx nWnF6KX5mQyqIdwG4LKtiIT9BnE3PNLEZo4qdZYoq8ubVqKsswuV2I8QPjxPUv2p9zqU3loAvH9u3 msy7iyyZo8mQzFSt2oIz87thflUzPmhPhKaIg7O6I6WDD+nxpy8P68YtlXt8BYwlTs/Q2xRgeCZS8 ibnhzunvAIZgU6OTCFWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9ou5-00FIgQ-05; Thu, 15 Jun 2023 15:28:53 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9ou2-00FIfx-1o for linux-arm-kernel@lists.infradead.org; Thu, 15 Jun 2023 15:28:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB56D63D16; Thu, 15 Jun 2023 15:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7075C433C8; Thu, 15 Jun 2023 15:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686842929; bh=3rUJKAAkVI4LiG4fM0PQkGZktYejaRvzK+AL0LZ3Y74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WMK8BkG+KJoxgGBdTk9yp8ZAuScSukNpIc1QMKIcgns2cazl704jin1fe/1UXio5n HJ9ZR7Pg0SF0WXvQBw+oAsOPRmVV/A5Q+xoE7yj0YM3/KYiY9tCWmdiJsryU+UHBB3 ri0LFyoZ9tF4c9V7ir8xb1Fp8oTMuVGnt/AEkCji6IqiCA/bnQAoiCreP9UwAU8ChQ aruy8AOj9e28HAeajwzSGG7a/3ST4fNv9DKiRlMHsZCe+bQLP01+ASsp6LatoHiScd 2pBlbYs0eu0naQmy+3XJsJ93n6/5vsZIrrNY1mZG9mdyEKm3M9U7y8kY/NYBp5Ar3r TlMEq1Y/2+kpg== Date: Thu, 15 Jun 2023 23:17:26 +0800 From: Jisheng Zhang To: Simon Horman Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 0/3] net: stmmac: fix & improve driver statistics Message-ID: References: <20230614161847.4071-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_082850_658343_BE040DF2 X-CRM114-Status: GOOD ( 24.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 14, 2023 at 09:39:17PM +0200, Simon Horman wrote: > On Thu, Jun 15, 2023 at 12:18:44AM +0800, Jisheng Zhang wrote: > > patch1 and patch2 fix two issues in net driver statistics: > > 1. network driver statistics are cleared in .ndo_close() and > > .ndo_open() cycle > > 2. some network driver statistics overflow on 32 bit platforms > > I would encourage you to describe these as enhancements or similar, > but not fixes. Because fix implies a bug, such as a crash. And > bugs for fixes are handled by a slightly different process which > often includes backporting. So it seems I need to fold patch2 and patch3 into one patch. Previously I thought the counters overflow on 32 bit platforms was a bug, thus I split the 64bit stats patch into patch2 and patch3 so that patch2 can be backported to stable tree. I will fold patch2 and patch3 into one patch in v2. Thanks for your review. > > > patch3 use pcpu statistics where necessary to remove frequent > > cacheline ping pongs. > > Assuming these are three enhancements, then they should be > targeted at the net-next tree. And that should be noted in the subject: > > Subject: [PATCH net-next v2] ... > > Unfortunately the series does not seem to apply to net-next > in its current form. So it probably needs to be rebased and reposted. > > If you do post an updated series, please observe a 24h grace > period between postings, to give reviewers time to do their thing. > > Link: https://docs.kernel.org/process/maintainer-netdev.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel