From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3E0DEB64D9 for ; Thu, 15 Jun 2023 23:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rg9RCbK4ZfawSBaJcfqeMPDTplCjR90kBXGEfE38Tf4=; b=T2UHfGeiSuUB9A sUw4OW3Qiy3mLoAgmxPAxxMyt82al1vnbLxA+RCl+FtYHpzAvr7TPI1mS5K2F4VnEaLHyTvjzipnF cajqADtxYuK6Uo5pXQzjss6X6JL/WgwHYobg5XU6yHmU9qsMdtg3PQ4r7ahKLZilWTyiqnl3irrfZ /nHQqEPNnrTgpuEnRUCE0XS+Ezd8KjsnhTEYZi2tIzKhCvu8pCtHEX+DMBYE8grB/5fGuN9FGjbbG GJUpjLGKGUxSZLJtJb2kBfT1Tg0KUlng+3Trg4aUrIE+48HY5TTXEUELLD+TrrZSTHQF5vmN5iUDd jTWdFCavTWbH7haJVGBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9wQp-00GLJ7-1N; Thu, 15 Jun 2023 23:31:11 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9wQm-00GLID-1J; Thu, 15 Jun 2023 23:31:09 +0000 Date: Fri, 16 Jun 2023 07:30:51 +0800 From: Yixun Lan To: Lucas Tanure Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Kevin Hilman , Greg Kroah-Hartman , Nick , Artem , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 5/6] tty: serial: meson: Added T7 SOC compatibility Message-ID: References: <20230615182938.18487-1-tanure@linux.com> <20230615182938.18487-6-tanure@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230615182938.18487-6-tanure@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_163108_462413_5E227C45 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lucas: On 19:29 Thu 15 Jun , Lucas Tanure wrote: > Make UART driver compatible with T7 SOC UART. > > Signed-off-by: Lucas Tanure > --- > drivers/tty/serial/meson_uart.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c > index 2501db5a7aaf..0208f9a6ba7e 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -796,6 +796,10 @@ static const struct of_device_id meson_uart_dt_match[] = { > .compatible = "amlogic,meson-s4-uart", > .data = (void *)&meson_g12a_uart_data, > }, > + { > + .compatible = "amlogic,meson-t7-uart", > + .data = (void *)&meson_g12a_uart_data, I think you are trying to follow previous s4 scheme - to introduce a new compatible string, while I think it's not necessary or even wrong, this will just make the dt_match_list longer but without obvious benefits.. as Conor already raised this question in previous dt-binding patch[4/6], how about just using 'amlogic,meson-g12a-uart' which is the first compatible introduced. if people agree, we could also drop 'amlogic,meson-s4-uart' since it use same compatible data as gl12a, anyway it should be separated into another patch.. > + }, > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, meson_uart_dt_match); > -- > 2.41.0 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel