From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6BDBEB64D9 for ; Thu, 29 Jun 2023 19:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LtiB1YCobbyNFy2QrXYi4ghyp0/o+5xp5ljbPn2NMKY=; b=YqGBiDvUb2Fgsk Csxl7bIVdhSzdmOKgaEczh8isUUjPUVYziEEJLDH+1UL9tcEk5hd86C/hj3QqVUEVzauSCJC55d4S FusULopQK/F/CuApyPqiZxEYaDPCIOoOIRHv4DN+5xjzqd11RE9fUU1Iwr0irUM5C9SXqNwHAzn41 WevsVefro4I67KiHhaZzfCEkx0R6HH6iwz2Xh5wEdvDQSN/SxEjUcicQgmqSn41priIgOfd6dUKrt 3PSDGOQxELCOI4NxEnrFNaxt0wYVTF0X5l106jINZde2iM7QG+9ZBxAggJgYExrUukykmFceITT83 iuFxew+x2h/zUNPgjTTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qExbK-001z55-0a; Thu, 29 Jun 2023 19:46:46 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qExbH-001z4Y-2t for linux-arm-kernel@lists.infradead.org; Thu, 29 Jun 2023 19:46:45 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51d7f350758so1371994a12.3 for ; Thu, 29 Jun 2023 12:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688068002; x=1690660002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=aDx7AxVngOOrZ0U4dQp2Rt5g15Hr1TQohG2BpiJ/qbw=; b=bbPZjDLQiyKRVGzxYHewphWboINd+Dw6Or+fT2O8PrQmylsmt6E6lFEsJox3KS/tU9 Pu00rzr2exNWWGAGLi52vc4gyxvNGrpXMdBDvkAZzj4fOdsFn8H2f8cb61Koj5A+jlHo 4amm0Y//49dVYBsdgAP6x65zuwaXAw+qxWSNO4uG4qBPiXD5OVYOBI5ummjJ9y7M3hsX rQWfkoG9MWLOzKArKHblb13mKR7wkhgU71mMkDxcEbV8Oucr/vVv2D3g0PKT2GBpxmfw ycZ9ZdH47TnhE80hBFwm4LT/JhBLFZL+6SkRdncD4fQoxg17VdPI7qo8jYLEdYxxmqlD pplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688068002; x=1690660002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aDx7AxVngOOrZ0U4dQp2Rt5g15Hr1TQohG2BpiJ/qbw=; b=NxJeiJCaBONlIyH5QMoSXu4iXgew9RvPcQHLQJFx957YKWgyJZP+kEH93CzuY2wq8t raTYyoaYrC8EivKjG0xEc9jmDaHXPG7XtUOw7sCh/H/YoDMfn/Nr3HJGBmQ8OR7q/Thg CG9T2WH0y/OlokF3K2kXZZgrZkT0IcBsPawxgngLnEaQlqoxIMU+z5OmobbfBL/Cv3Uj lBU3LbB57AJtUZ1AHi+JmnxNgV/JMBEB8j6J7gLC/caodV06tbHO4FEziUG3we4D7000 eUTXyGOg+tOZOsbS+JXRHUndJYQQvFBW9IESagVsq8vmIZiFPMIfs2nCc2gZAt3Lmhi3 htQw== X-Gm-Message-State: ABy/qLagMvrUc7o9acl1zyOJKQjyh6WLgdA3hBU9U3XjAo5iwVTLiTYV jmyaSrXNrqFZK3TkuSJR6DQ= X-Google-Smtp-Source: ACHHUZ5fLWyhQGeC/3RJn6WgKNVDva/Zae5ciIGKyzzqKjsM+mYzynTcazRitLLyYP/haf0vvZY95w== X-Received: by 2002:a17:906:b20c:b0:97e:32e:c1e with SMTP id p12-20020a170906b20c00b0097e032e0c1emr326132ejz.55.1688068001914; Thu, 29 Jun 2023 12:46:41 -0700 (PDT) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id jo19-20020a170906f6d300b00992d70f8078sm151634ejb.106.2023.06.29.12.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 12:46:41 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id B3C9227C0054; Thu, 29 Jun 2023 15:46:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 29 Jun 2023 15:46:39 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtdeggddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeeghedvgedttdfhtefhueelgfetfffgvdfhjeduffeitdduhffgieegueej fedtveenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhgihhthhhusghushgvrhgtoh hnthgvnhhtrdgtohhmpdgrrghrtghhieeguhhnkhhnohifnhhnohhnvgdrrhhsnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeeh heehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmh gv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jun 2023 15:46:38 -0400 (EDT) Date: Thu, 29 Jun 2023 12:46:13 -0700 From: Boqun Feng To: Jamie Cunliffe Cc: catalin.marinas@arm.com, lina@asahilina.net, linux-arm-kernel@lists.infradead.org, ojeda@kernel.org, rust-for-linux@vger.kernel.org, steve.capper@arm.com, will@kernel.org Subject: Re: [PATCH v2 1/3] arm64: rust: Enable Rust support for AArch64 Message-ID: References: <20230612152639.1446766-1-Jamie.Cunliffe@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230612152639.1446766-1-Jamie.Cunliffe@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_124643_940270_440A3397 X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 04:26:39PM +0100, Jamie Cunliffe wrote: > > I don't think you need "-fp-armv8" here, because "aarch64-unknown-none" > > target doesn't have the target-feature "fp-arm64": > > > > rustc +1.68.2 --print cfg --target aarch64-unknown-none | grep target_feature > > > > target_feature="neon" > > > > , and having the "-fp-armv8" gave me a warning at compile time: > > > > RUSTC L rust/core.o warning: unknown feature specified for `-Ctarget-feature`: `fp-armv8` > > | > > = note: it is still passed through to the codegen backend > > = help: consider filing a feature request > > Rust removed the fp feature for arm64 and tied it with Neon. However > this initially had a bug that meant it couldn't be disabled. This has > now been fixed in https://github.com/rust-lang/rust/pull/107294 so > once we can update rustc we can fix that warning by removing the > `-fp-armv8`. Until we do that we still need the `-fp-armv8` otherwise > we will get some floating point usage. This can be seen by doing an > objdump of core.o if you build after removing the `-fp-armv8`. > Thanks for the information (and the fix)! That's good to know. Looks like the fix will be in 1.71, then agree, we should keep `-fp-armv8` until we update to 1.71 or later. Regards, Boqun > > You can also see that fp-armv8 is enabled in the aarch64-unknown-none target > here: https://raw.githubusercontent.com/rust-lang/rust/master/compiler/rustc_target/src/spec/aarch64_unknown_none.rs > > > Thanks, > Jamie. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel