From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7837EB64D7 for ; Fri, 30 Jun 2023 10:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=crc4A29+j4kpEx3MR55ajt1qJ8DGuCoQRqzOCPjeR3g=; b=3aa3FbyvaubrQY M7oZoGxaAIhlukERbg6LzV/T/59Bhi3NZH1GC6jUCQLw6neEKnE1PLZ6SCpJTRy4y9UGpxx3Iz9IB 9a/HA/qfrHw4p+QteisoWxkAFWaZ9n9Bo/RvGJ4grAsMyJcJ7oThKURaZ4UD5j6IUrRup6CEaNDWF lfZKVqbDiwydyuCerlbxtMaOFT9VOG/KuwCtHc15mXnozTEBsvl1lR3Nl0FRAy3D4gH9wlkBbi56a WJ+AK4bCELShWh0S8Di/XoRRO5ZNLz6KM8rG9cWzGfR8mm355Y8IV7QIbks47eFn8leDHXeHl1gTF 0/wHaVhic01wik21ZNJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFBWm-003Nkj-2l; Fri, 30 Jun 2023 10:39:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFBWj-003Njm-27 for linux-arm-kernel@lists.infradead.org; Fri, 30 Jun 2023 10:38:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E5C1ED75; Fri, 30 Jun 2023 03:39:34 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD2A03F663; Fri, 30 Jun 2023 03:38:49 -0700 (PDT) Date: Fri, 30 Jun 2023 11:38:47 +0100 From: Cristian Marussi To: Oleksii Moisieiev Cc: "sudeep.holla@arm.com" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH v3 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230630_033857_759108_5249C6C1 X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 06, 2023 at 04:22:26PM +0000, Oleksii Moisieiev wrote: > This Patch series is intended to introduce the potential generic driver for > pin controls over SCMI protocol, provided in the latest beta version of DEN0056 [0]. > > On ARM-based systems, a separate Cortex-M based System Control Processor (SCP) > provides control on pins, as well as with power, clocks, reset controllers. In this case, > kernel should use one of the possible transports, described in [0] to access SCP and > control clocks/power-domains etc. This driver is using SMC transport to communicate with SCP via > SCMI protocol and access to the Pin Control Subsystem. > Hi Oleksii, sorry this review has been a bit delayed, I tested V3 in my setup and found no practical issue. I'll post a few comments/remarks along the series. Beside addressing pending comments, I suppose that the next step will be anyway to address the upcoming changes in the new v3.2 BETA regarding support for multiple type/value set/get operations as requested by Peng. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel