From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F1CDEB64D8 for ; Thu, 22 Jun 2023 08:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xkoTakuC0Dt2Y6Bjeonsd3iSEPWfypeCskM0pdHqbkw=; b=QSb0bGwMelGiG/ 2K9LcCZ8U/sjGY2uSGxBeO74btsoUSCRhqAUXrHvjBesp0yX2Hq9bekk5VctXrGVvpSc8B4hXPJ+9 R1RSvHA+QY3w5i+Tf4H7kGtxAIW4puYXY0pHdIIHaASGnEYbOC+bvwt9r8C4bJDeo/LCrVUgfhf8A 0r+jSo2r5PxS+sVPAt3sAgY2XlDPvo6zmCeAqGgZ/gZ9lK3tYuHeMnwudkKVxJ+avH8aKC9dY0CsZ 4qxKrjrSTxa5ibHNvJWq6hStaPoYDpOYNJFn9VRUs/D18YWIwH5p4/YehuLMBYLnbUNJneB50p5Qk zLzbxxgH9Ilgj522TRlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCFRW-00HNfU-0T; Thu, 22 Jun 2023 08:13:26 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCFRT-00HNeB-0N for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 08:13:24 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fa74b7fa53so2103065e9.0 for ; Thu, 22 Jun 2023 01:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687421600; x=1690013600; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IxLUdJmVd0ETDzeyKPn7SZFc1uqf2kKlnDi3sO0D5bA=; b=m6S/1aChLob1kPwjzOxRWbVw6phKHvBwUuMbKgJXFUUDIVeEMYZwHU0JRSddKN/F9T X0gPncN2Cr00y6wzOB0ZoQ34oYQYjz+3bMSV5rpBfJABPcSCwjCrEl6wvvfjv/65ObHj gonKAPHtf+BWGYyRppoeSQEF2iNhfiiVS/e4tF8CxFx1Yugub1I7Bj3p+S80Chi0S8Zd wgmTZf+AM+pg3bZpsuzSdDdbSbijID5YA6/+ZLkBxQbwrvBO6c7uZP+KyGJzKTqpgFrK WkrWDBUOVpsUJ9gn0QkU1WpWys6Y+OZmIqUYX7aqPtUEhANDwtePae81z5QuG9Tk4nkb MVgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687421600; x=1690013600; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IxLUdJmVd0ETDzeyKPn7SZFc1uqf2kKlnDi3sO0D5bA=; b=GJY+qa7I6qNjHDu0IilvmZ4Fv/EXTEnKN9duTbdfcQwLZBDi2AmhSFSfucUjbGGg/N Iy4yCVaCzp3WS16kp259j6i7GYRFhH9rkQvOmiNNgvFzqgOqot4W7l1huSvKgB91dSXo can8U78teueG/mxtfAGXO8IBZ9j72iQQczbONb3sdvRacpeE4rl6Z2/f9AR+xCZcYsL5 d6PnzAS8ABFumsdnIpft2bDrGoJyynbgHQ4xaOaSITQ7+CNMJDwE/C1Sru1YgjNjPDC9 4LUyFb+aoDCa80lG8YvMRADPnclP3aWVWJwDLkL5TiaN0q8ouYwbWUr0m5U3SWM5KTp5 2wGA== X-Gm-Message-State: AC+VfDzT/oujuUZ2/cDpDTF9zcz/AXgWyrpJkEBkFsM8jh/Cr+zV1lzg 47U94nL21pA8RCPY7G4/iXU4pw== X-Google-Smtp-Source: ACHHUZ5/yVN8oCoK0xe5hZIq6nL4aj3WkftYMpUVpR0rf2ivexC2SAnBmK0FQvOJ5tZxjRcF7e/i4A== X-Received: by 2002:a05:600c:4e92:b0:3fa:7515:902e with SMTP id f18-20020a05600c4e9200b003fa7515902emr625228wmq.16.1687421600301; Thu, 22 Jun 2023 01:13:20 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c231100b003f8ec58995fsm7070435wmo.6.2023.06.22.01.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:13:19 -0700 (PDT) Date: Thu, 22 Jun 2023 10:13:18 +0200 From: Jiri Pirko To: Bartosz Golaszewski Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Junxiao Chang , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH net] net: stmmac: fix double serdes powerdown Message-ID: References: <20230621135537.376649-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230621135537.376649-1-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_011323_158019_40CE22CC X-CRM114-Status: UNSURE ( 8.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wed, Jun 21, 2023 at 03:55:37PM CEST, brgl@bgdev.pl wrote: >From: Bartosz Golaszewski > >Commit 49725ffc15fc ("net: stmmac: power up/down serdes in >stmmac_open/release") correctly added a call to the serdes_powerdown() >callback to stmmac_release() but did not remove the one from >stmmac_remove() which leads to a doubled call to serdes_powerdown(). > >This can lead to all kinds of problems: in the case of the qcom ethqos >driver, it caused an unbalanced regulator disable splat. > >Fixes: 49725ffc15fc ("net: stmmac: power up/down serdes in stmmac_open/release") >Signed-off-by: Bartosz Golaszewski Reviewed-by: Jiri Pirko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel