From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 670BFEB64D8 for ; Thu, 22 Jun 2023 08:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ezrvs+RBP7WnCRnIDrmHBdQyRhgtEjDh4If03iLeOnQ=; b=w5OkzX2GGiQOEO VwajKq2HnXaml//d5Q85QIgc03VgEsCRqTyQgxKwJEYSsRAa8LFU8ExEi3H+3H2fijo2EhK6oas/P kZWT8RSjaBHeDTTq8rU6Ncqj2zEPc7LiHUt7XDy5wIiNEtZo45EEqB3P8OkqUYDyb3wwByW/OEkYZ G6hZGxLWKRQZkykF2LH+WI49EVpLtRSggHUwHAo/xpRiCno9FHWTwIrmsl8fldK+aKORzBDxQHtX8 t5onaIjSFs2TJCg4nTJzncQDXwp7I5NkN4nRAYn789VojQEBYjj7CXHA9zh6YzkqWkH6ie1tUEKoR aa7+NZ95sW4/tadyvSrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCFdT-00HPSl-1Q; Thu, 22 Jun 2023 08:25:47 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCFdQ-00HPRY-2U for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 08:25:46 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-31109cd8d8cso6856762f8f.2 for ; Thu, 22 Jun 2023 01:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687422342; x=1690014342; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tj5C+I7HeG1vpL6n+8jLNCbj2isj+XEX8Di7Bm48+qw=; b=oKdr2pCRPDWXIy1kqKz+GQzoNsep5MGxpbwUXovmfx7o029cboskRdzrXQzPMfSeA2 gx7/SZCfNdlfBudmGdfJ7DYMBHxXzxk1RezMw7RAQYtSViRXJQkHltzIg0e7kNaiU3XQ thR/x9sBIit/GsueiK1NR6+hqZ6gShTC76vtaDqDULqp4rLFT5xRAdh2AGp081IAyROv +d6e69NzMiEa+l++Af+5acj3vDtpbsY+dJcX9Mv7GxhCRkH2zSdLlcoqfNyrDC5lfVDl jddCuoJcbp9QgyS93vgfXanQFiyrpHiaht5lq13lC6/PVMd8rF93uP/4zATEdilZGrcb fZCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687422342; x=1690014342; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tj5C+I7HeG1vpL6n+8jLNCbj2isj+XEX8Di7Bm48+qw=; b=BnwuHbOYm7o6arVeBLWTh+PXdf2GYE8m5CwOZ9mOK/B/99+FDZC/7kXMGln5IC5taQ AGHWHonsPftjlpY/7ndd2XWlM8sSLWfHCBgCRD+6IOLYs30H8ifdp2TWvYJoGVtkIz5p NAohGGoq+9HNLYJKSncpLGv4es/nKBEV/b9O0Mg6rHDGoozlAHDSt7qtL+bjlRHfJ989 N1LTwCCNoVabVZcNIsk/c1L9QpNsaVqMMZvOVrUTxm6vV0XfKLl0BnS8ir5hSr9Ha20X XVwYiy9bum7Xjf5na95FUwHms0LU48DVu0zI6BtANwCIcvQXe6qlmTbk64+92admDcFU sPCw== X-Gm-Message-State: AC+VfDz3frm8L+colLhi4Z3pjSUFlY7SIAy/0Aq3eFiEzUU8q5Rf8F+a o6D69Rdb2KmjN+as6HcRVnOfRA== X-Google-Smtp-Source: ACHHUZ7XFfsYPuPByW/01qxDBsnw6NFSD2C7skL84s9Wdwc3Ow8C/fjvbrY7Uw7P/Gg+U/HeyjusyQ== X-Received: by 2002:a5d:518a:0:b0:30c:5e52:5bad with SMTP id k10-20020a5d518a000000b0030c5e525badmr12585022wrv.18.1687422342565; Thu, 22 Jun 2023 01:25:42 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id z13-20020adff74d000000b0030af15d7e41sm6561594wrp.4.2023.06.22.01.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 01:25:41 -0700 (PDT) Date: Thu, 22 Jun 2023 10:25:41 +0200 From: Jiri Pirko To: Maxim Kochetkov Cc: netdev@vger.kernel.org, Radhey Shyam Pandey , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] net: axienet: Move reset before DMA detection Message-ID: References: <20230621112630.154373-1-fido_max@inbox.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230621112630.154373-1-fido_max@inbox.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_012544_809059_7F18A655 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wed, Jun 21, 2023 at 01:26:30PM CEST, fido_max@inbox.ru wrote: >DMA detection will fail if axinet was started before (by boot loader, >boot ROM, etc). In this state axinet will not start properly. >So move axinet reset before DMA detection. > >Signed-off-by: Maxim Kochetkov You are missing a "Fixes:" tag here pointing out to the patch that introduced the issue. >--- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >index 3e310b55bce2..734822321e0a 100644 >--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >@@ -2042,6 +2042,11 @@ static int axienet_probe(struct platform_device *pdev) > goto cleanup_clk; > } > >+ /* Reset core now that clocks are enabled, prior to accessing MDIO */ >+ ret = __axienet_device_reset(lp); >+ if (ret) >+ goto cleanup_clk; >+ > /* Autodetect the need for 64-bit DMA pointers. > * When the IP is configured for a bus width bigger than 32 bits, > * writing the MSB registers is mandatory, even if they are all 0. >@@ -2096,11 +2101,6 @@ static int axienet_probe(struct platform_device *pdev) > lp->coalesce_count_tx = XAXIDMA_DFT_TX_THRESHOLD; > lp->coalesce_usec_tx = XAXIDMA_DFT_TX_USEC; > >- /* Reset core now that clocks are enabled, prior to accessing MDIO */ >- ret = __axienet_device_reset(lp); >- if (ret) >- goto cleanup_clk; >- > ret = axienet_mdio_setup(lp); > if (ret) > dev_warn(&pdev->dev, >-- >2.40.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel