From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFC92EB64D8 for ; Thu, 22 Jun 2023 09:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ticvPCOwc21tBM+px+VdzYgxqAhp55ExwGMBsUmiITM=; b=z3M6JalrCEIa9t Gi7Mv1XSDIGlUYcCbO+3rLiNnpjdhKXV4SQWHgsSuRjfqECDWlqSYQK/ugK2IR0Xg77BQqtaCtzsO eeOvZCpae9smdY40EEuGPYCzpiYv2mlyTUYn8WM9xA1TMbxozQ/5zPpGdyWQbh4qdJd5hDFMw8eA6 gkvjbaFzbv0cTaD8td/XDyeos06BGrsFpyhw2ms7rp+HKlQzUaFSu1kKHorj2e0XEDmliDKJIoEc9 mufFIsFuoF/YYUl30fnaOjdRGg3BZhFkbqN8Xrj5y664BRwMiiDqF7czHDPQ+6BHkHP+c2P+EPmqM SWJ8KrRIic+dJY02+p8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCGpb-0002dG-0h; Thu, 22 Jun 2023 09:42:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCGpX-0002ce-21; Thu, 22 Jun 2023 09:42:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8EF51042; Thu, 22 Jun 2023 02:43:00 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.25.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B98963F663; Thu, 22 Jun 2023 02:42:14 -0700 (PDT) Date: Thu, 22 Jun 2023 10:42:12 +0100 From: Mark Rutland To: Naresh Kamboju Cc: Linux ARM , open list , linux-rpi-kernel@lists.infradead.org, Netdev , lkft-triage@lists.linaro.org, Arnd Bergmann , Dan Carpenter , Linus Walleij , Catalin Marinas , Will Deacon , Anshuman Khandual , Puranjay Mohan , Song Liu , Alexei Starovoitov Subject: Re: next: Rpi4: Unexpected kernel BRK exception at EL1 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_024219_735134_789BF123 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 21, 2023 at 01:57:21PM +0100, Mark Rutland wrote: > On Wed, Jun 21, 2023 at 06:06:51PM +0530, Naresh Kamboju wrote: > > Following boot warnings and crashes noticed on arm64 Rpi4 device running > > Linux next-20230621 kernel. > > > > Reported-by: Linux Kernel Functional Testing > > > > boot log: > > > > [ 22.331748] Kernel text patching generated an invalid instruction > > at 0xffff8000835d6580! > > [ 22.340579] Unexpected kernel BRK exception at EL1 > > [ 22.346141] Internal error: BRK handler: 00000000f2000100 [#1] PREEMPT SMP > > This indicates execution of AARCH64_BREAK_FAULT. > > That could be from dodgy arguments to aarch64_insn_gen_*(), or elsewhere, and > given this is in the networking code I suspect this'll be related to BPF. > > Looking at next-20230621 I see commit: > > 49703aa2adfaff28 ("bpf, arm64: use bpf_jit_binary_pack_alloc") > > ... which changed the way BPF allocates memory, and has code that pads memory > with a bunch of AARCH64_BREAK_FAULT, so it looks like that *might* be related. For the benefit of those just looknig at this thread, there has been some discussion in the original thread for this commit. Summary and links below. We identified a potential issue with missing cache maintenance: https://lore.kernel.org/linux-arm-kernel/ZJMXqTffB22LSOkd@FVFF77S0Q05N/ Puranjay verified that was causing the problem seen here: https://lore.kernel.org/linux-arm-kernel/CANk7y0h5ucxmMz4K8sGx7qogFyx6PRxYxmFtwTRO7=0Y=B4ugw@mail.gmail.com/ Alexei has dropped this commit for now: https://lore.kernel.org/linux-arm-kernel/CAADnVQJqDOMABEx8JuU6r_Dehyf=SkDfRNChx1oNfqPoo7pSrw@mail.gmail.com/ Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel