From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA6E7EB64D8 for ; Thu, 22 Jun 2023 15:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LydCAi9LB9rEMTzEiOP3CGhGVArLfJdsx4IqoJzGQvY=; b=3q+2Ht+ydtVA0R zKirgku3Dyvy4yTFYOQd/OvfyAAzoHBe/zcqZAKnJsYlEcr3JeNi09fClTAiGfRLZO8vG4bY5EUhO AsIghjSsrV/s53Gc4y0kAfnYSq7jnxeTq8dN2eN/9w73UNCA4UctrhxtfIPDNmiem0xZpKNqmdYhH OfqCGLO/LBLR4Isng1oDkLyrdtte3wWVL9s3h08KP3s0L3arqoO97uDSaWMbfL5XRep8yAsBqk4tx UK7+bHVFeFW934kJXK1chM8MUZzeNxRgq2lahRvxXuHmG/E9H/sGELQongoREpUWJ2ScAHL1ivwEI UKtD8aucEKwBV4RZoRng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCLuU-0015MH-36; Thu, 22 Jun 2023 15:07:46 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCLuS-0015LY-1w for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 15:07:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8TPy4M/IgqT8baUzBBF1Ot9HCGGq63OZ2dRMS9U2qEs=; b=hr+LCn33yjNicFl80hCKAgwrYa 93pDGSYl0/5FwW8xGbJb8Bzwztin6lA17hYELqtlfCGcjrfacnkQeDW1Lnhs4p6Yp9NR9LNSd0rby dueuqWRwCA/tDevppb+kFIH3iP5TedRM6dFD9YtjJX/8Ws4z3nGPQtt/kPtZ3e1NnRrVf76+qMMas 62BEzt/rZsSylnXlBn0qSGDCDDv9NEhrrUizNFGFJRep32eCpFzYECJyP8A5b3s7RW+cRqYqeWdnp VDJTdWx8a7knGFAp2YasyuIJXY4IANgHDg2DsKL018BtVc64glMoFn4kujqH487kklA3eYmyQy7u1 E9hIGVdw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43762) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qCLtO-0004OW-29; Thu, 22 Jun 2023 16:06:38 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qCLtH-0000Wx-N7; Thu, 22 Jun 2023 16:06:31 +0100 Date: Thu, 22 Jun 2023 16:06:31 +0100 From: "Russell King (Oracle)" To: Simon Horman Cc: Choong Yong Liang , Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Jose Abreu , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?iso-8859-1?Q?Beh=FAn?= , Jean Delvare , Guenter Roeck , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Philipp Zabel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wong Vee Khee , Jon Hunter , Jesse Brandeburg , Revanth Kumar Uppala , Shenwei Wang , Andrey Konovalov , Jochen Henneberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, bpf@vger.kernel.org, Voon Wei Feng , "Tan, Tee Min" , Michael Sit Wei Hong , Lai Peter Jun Ann Subject: Re: [PATCH net-next 3/6] net: phy: update in-band AN mode when changing interface by PHY driver Message-ID: References: <20230622041905.629430-1-yong.liang.choong@linux.intel.com> <20230622041905.629430-4-yong.liang.choong@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_080744_656040_EB3C0F25 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 22, 2023 at 04:43:51PM +0200, Simon Horman wrote: > On Thu, Jun 22, 2023 at 12:19:02PM +0800, Choong Yong Liang wrote: > > From: "Tan, Tee Min" > > > > Add cur_link_an_mode into phy_device struct for PHY drivers to > > communicate the in-band AN mode setting with phylink framework. > > > > As there is a mechanism in PHY drivers to switch the PHY interface > > between SGMII and 2500BaseX according to link speed. In this case, > > the in-band AN mode should be switching based on the PHY interface > > as well, if the PHY interface has been changed/updated by PHY driver. > > > > For e.g., disable in-band AN in 2500BaseX mode, or enable in-band AN > > back for SGMII mode (10/100/1000Mbps). > > > > Signed-off-by: Tan, Tee Min > > Signed-off-by: Choong Yong Liang > > ... > > > diff --git a/include/linux/phy.h b/include/linux/phy.h > > index 11c1e91563d4..c685b526e307 100644 > > --- a/include/linux/phy.h > > +++ b/include/linux/phy.h > > @@ -756,6 +756,8 @@ struct phy_device { > > /* MACsec management functions */ > > const struct macsec_ops *macsec_ops; > > #endif > > + /* For communicate the AN mode setting with phylink framework. */ > > + u8 cur_link_an_mode; > > }; > > Hi Choong Yong Liang, > > Please consider adding cur_link_an_mode to the kernel doc > for struct phy_device - which is above the definition of struct phy_device. This looks like it's grabbing something from phylink and stuffing it into phylib. However, I have no idea, because I don't seem to have received the original patches. I'm guessing the reason is: 2023-06-22 05:21:24 1qCBoy-0003ji-G9 H=mga03.intel.com [134.134.136.65]:57703 I=[78.32.30.218]:25 X=TLS1.2:ECDHE_SECP521R1__RSA_SHA512__AES_256_GCM:256 F= rejected after DATA: unqualified address not permitted: failing address in "Cc:" header is: Tan Which I suspect came from: Tan, Tee Min and someone doesn't realise that a "," in the display-name part of an address *must* be quoted, otherwise "," is taken to be a separator in the address list. Consequently, it has now become: Tan@web.codeaurora.org, Tee Min , It should have been: "Tan, Tee Min" with the double-quotes. Please do not review this series further, but instead, please can the author repost it forthwith with correct conformant headers so that a proper review can be undertaken by all? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel