From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AEE5EB64D7 for ; Mon, 26 Jun 2023 20:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZSkfUBHviw8tizi/JPKu2SC4i5JSAxzkk6FsbzKtZ2M=; b=TiifSwu2Wypw1w OZlaGRqahhy6f8OKPQsxk+fI1DXjxBlZF5YnjTOIuAQG9l+9VJ6eWYAuTBaAT/09TJoRIZ9GU3uZ8 vJvDfUZeRxl/GqWFjCPUPmO1zYsc0R8RxSfVtXYFFbYYsJTHDntl3g2ehzVvPbAyNoQOeODEsOLP4 lJQuHF7MIGz8jR6WHTo30EmHGurE5zLbEPbRAfuWZR2whjZgeojRfjPPS4tGUwvF5F4lij2pKRD1R 5wXI2JfksasiKtl/UXpjYx0trLx1VcPeCGOLzzi4/cAPs/C4l80erPlROw9AhGfkbWHqYA1K1wWrQ m7XQbTokvEB4b5X5vkTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qDtCr-00B2Ad-2f; Mon, 26 Jun 2023 20:53:05 +0000 Received: from out-25.mta1.migadu.com ([95.215.58.25]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qDtCo-00B2A0-1d for linux-arm-kernel@lists.infradead.org; Mon, 26 Jun 2023 20:53:03 +0000 Date: Mon, 26 Jun 2023 20:52:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687812772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X1L5ZJ3PrRKoApzZhudFyrD6ET1z6DiDInN2mn2qOoA=; b=av6vlVmWwH6Lmd2qCNew8YvpUoDOiGhnuZg5NYkW0fVMhEJGKEF1ML4mve6cyO4xGHvlEI 4K1bAe1c3yvOeYTlymxOebdimsN1DbmlfWnIT1PdorkycXiZI0JrK7TjI+vUS0PVtquXnd g0nRwzgIZRzd80BTuICSOMXIcQRi/b0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Jing Zhang Cc: KVM , KVMARM , ARMLinux , Marc Zyngier , Oliver Upton , Will Deacon , Paolo Bonzini , James Morse , Alexandru Elisei , Suzuki K Poulose , Fuad Tabba , Reiji Watanabe , Raghavendra Rao Ananta , Suraj Jitindar Singh Subject: Re: [PATCH v4 0/4] Enable writable for idregs DFR0,PFR0, MMFR{0,1,2} Message-ID: References: <20230607194554.87359-1-jingzhangos@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607194554.87359-1-jingzhangos@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230626_135302_691589_C1470758 X-CRM114-Status: GOOD ( 10.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jing, On Wed, Jun 07, 2023 at 07:45:50PM +0000, Jing Zhang wrote: > > This patch series enable userspace writable for below idregs: > ID_AA64DFR0_EL1, ID_DFR0_EL1, ID_AA64PFR0_EL1, ID_AA64MMFR{0, 1, 2}_EL1. > > It is based on below series [2] which add infrastructure for writable idregs. Could you implement some tests for these changes? We really need to see that userspace is only allowed to select a subset of features that're provided by the host, and that the CPU feature set never exceeds what the host can support. Additionally, there are places in the kernel where we use host ID register values for the sake of emulation (DBGDIDR, LORegion). These both should instead be using the _guest_ ID register values. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel