Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit

Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit

[hanyu001]

coccicheck complains about the use of snprintf() in sysfs show 
functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or 
sprintf

Signed-off-by: ztt <1549089851@qq.com>
---
  arch/arm/mm/cache-l2x0-pmu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
index 993fefdc167a..d20626451a2e 100644
--- a/arch/arm/mm/cache-l2x0-pmu.c
+++ b/arch/arm/mm/cache-l2x0-pmu.c
@@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device 
*dev,
      struct l2x0_event_attribute *lattr;

      lattr = container_of(attr, typeof(*lattr), attr);
-    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
+    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
  }

  static umode_t l2x0_pmu_event_attr_is_visible(struct kobject *kobj,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit

[Russell King (Oracle)]

On Thu, Jul 13, 2023 at 06:06:15PM +0800, hanyu001@208suo.com wrote:
> coccicheck complains about the use of snprintf() in sysfs show functions.
> 
> Fix the coccicheck warning:
> WARNING: use scnprintf or sprintf.
> 
> ./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf
> 
> Signed-off-by: ztt <1549089851@qq.com>
> ---
>  arch/arm/mm/cache-l2x0-pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
> index 993fefdc167a..d20626451a2e 100644
> --- a/arch/arm/mm/cache-l2x0-pmu.c
> +++ b/arch/arm/mm/cache-l2x0-pmu.c
> @@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
>      struct l2x0_event_attribute *lattr;
> 
>      lattr = container_of(attr, typeof(*lattr), attr);
> -    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> +    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);

This only serves to shut up a warning. On 32-bit ARM, there is utterly
no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes,
or even 32 bytes!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit

[David Laight]

From: Russell King <linux@armlinux.org.uk>
> Sent: 13 July 2023 11:16
> To: hanyu001@208suo.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit
> 
> On Thu, Jul 13, 2023 at 06:06:15PM +0800, hanyu001@208suo.com wrote:
> > coccicheck complains about the use of snprintf() in sysfs show functions.
> >
> > Fix the coccicheck warning:
> > WARNING: use scnprintf or sprintf.
> >
> > ./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf
> >
> > Signed-off-by: ztt <1549089851@qq.com>
> > ---
> >  arch/arm/mm/cache-l2x0-pmu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mm/cache-l2x0-pmu.c b/arch/arm/mm/cache-l2x0-pmu.c
> > index 993fefdc167a..d20626451a2e 100644
> > --- a/arch/arm/mm/cache-l2x0-pmu.c
> > +++ b/arch/arm/mm/cache-l2x0-pmu.c
> > @@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
> >      struct l2x0_event_attribute *lattr;
> >
> >      lattr = container_of(attr, typeof(*lattr), attr);
> > -    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> > +    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
> 
> This only serves to shut up a warning. On 32-bit ARM, there is utterly
> no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes,
> or even 32 bytes!

The code also doesn't match the commit message.
Did you actually send the correct copy of all these patches?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel