From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41D97EB64DC for ; Tue, 11 Jul 2023 15:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Dqp/I6qahZa5NlR/C9Dc48pNy8iLg62nS9qYyqpXHU=; b=Q/sbnnQYZBZJWmhH18ZuIFs75z sWuUMVNVswEF5cOsXV+E+ujQQ9FLPR+X56Poabc5EDOzq3P9FQtsZkTJEb5qaYMuGirJ5gdKKirxz wwIY4lDiqZynTnsUD4qCXbhsp+cxbNvFtwLi/dJPBJVuZMa1cJbxLYssOolrt++MWSFcPYDFPL2vW +sW0NFxHdrvHU+oBtl8gTJw+Ur7Z9xW3mxDZw3rUz+sNoUlAp3QnMmqoc/FBekU5lMKk4it8Ieqqd T7apPkAb8OogpUbEuolQ5P944qbR9x+6outLhAmJ29wIMIWwn9DfBe8qoV0K5vm4N5FAS3xOLfr+o azHTym1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJFYl-00FIOJ-0r; Tue, 11 Jul 2023 15:45:51 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJFYi-00FIMp-1u for linux-arm-kernel@lists.infradead.org; Tue, 11 Jul 2023 15:45:49 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fbea14706eso60325365e9.2 for ; Tue, 11 Jul 2023 08:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689090343; x=1691682343; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gEnZrLvHdlB3PZ8L85NuzxKsb9GUXwvaPc+7AvopSIs=; b=Ve35qujJ7tMg8SnA6xPQuYXHUiMu7GE3AMJYZK7HK5zf1Logu8Qu6+8webPkguM5CJ zU6QQXqlSkCuZm75x3tMegGpfByijBndA5Y0YvKrratm6judUwMv4rcGSwxfcdNZS8hw 5Bhkvz/BD1yV02DttN2YFw9re4IgL74cfTTEpxWwYj4ewfStF+BwxdAYc0CltmNZW7NZ YpA4/EmUuYpz01gcEoIUJXN8A9ixew6NFEtTBR08NMSSfei5g5vBEb7pVWZpidiC/HOY u8Hntxen/sTpDMLqhbt3lQC1jt5+LuLrTtt90+7ETSwRmqiSBLt9E2OVM8cEuE5Ics8w xhqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689090343; x=1691682343; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gEnZrLvHdlB3PZ8L85NuzxKsb9GUXwvaPc+7AvopSIs=; b=FHT1Wc6vFr+ZjFJL+INDNXpip/rRiqzOp2XWyfKV2RUEeVxNWuwgYD0wFH64AOAVrx hLnNdNEnBQ1zyYmTe3XWk3sj2Q1Ii+NhozfbcIhNwXOzhVpNf2+eYFg4bRLeYei7J6gI tkIvJ3RKfuKre1S5svy9/kKVFVJr0qwuqKq5GlSWHTpRCiBrD+PHtMXCKyfqCOS2g0+c ux9RCtTqLD8ebvaJBY+hBbw9TiszfV0idM+/XYkvfjmvLxkLd+yDJ33NPvum13R2pj0h c004Yzyj25xr9Ho9wi2pQmXv9072M9vn0ShV8boAASgZPOUgNgqUkGbCs9mdQjzsDuXL onyA== X-Gm-Message-State: ABy/qLbEjohTQnJCvHEiMsJkhjSiBLVugE4LoYjFJFkVsETME1HpCYin WsT3bH745XlKtnjRzCdYQkw= X-Google-Smtp-Source: APBJJlHXhHtlNJoX08En4eWf1XbIwtd8s5TeV7etCD1pudCcBw050V+aHMjErPbL6Odb/Ug0wgAW+Q== X-Received: by 2002:a1c:7914:0:b0:3f9:b1e7:8a4b with SMTP id l20-20020a1c7914000000b003f9b1e78a4bmr14521606wme.21.1689090342506; Tue, 11 Jul 2023 08:45:42 -0700 (PDT) Received: from orome (p200300e41f4b7100f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f4b:7100:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id s14-20020adfea8e000000b00301a351a8d6sm2576702wrm.84.2023.07.11.08.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 08:45:42 -0700 (PDT) Date: Tue, 11 Jul 2023 17:45:40 +0200 From: Thierry Reding To: Guiting Shen Subject: Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in bootloader Message-ID: References: <20230710144214.63343-1-aarongt.shen@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.10 (2023-03-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230711_084548_632304_4145A555 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de, claudiu.beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0277613070345323502==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0277613070345323502== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B8pxxDeV9zU7sDZJ" Content-Disposition: inline --B8pxxDeV9zU7sDZJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 11, 2023 at 10:30:54AM +0800, Guiting Shen wrote: > On Mon, Jul 10, 2023 at 23:00:45PM GMT+8, Thierry Reding wrote: > > On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote: > >> The driver would never call clk_eanble() if the pwm channel already > >> enable in bootloader which lead to dump the warning message of "the pwm > >> clk already disabled" when poweroff the pwm channel. > >> > >> Add atmel_pwm_enanle_clk_if_on() in probe function to enable clk if the > >> pwm channel already enabled in bootloader. > >=20 > > You've got multiple spelling errors in the commit message. Also, PWM is > > an abbreviation and so should be all uppercase (except for the subject > > prefix). I also prefer spelling out terms like "clock" in the commit > > message. This is text that is supposed to be readable. It's not code. >=20 > Got it, Thank you. How about this commit message: >=20 > The driver would never call clk_enable() if the PWM channel was already > enabled in bootloader which lead to dump the warning message "the pwm > clock already disabled" when turn off the PWM channel. >=20 > Add atmel_pwm_enable_clk_if_on() in probe function to enable clk if the > PWM channel was already enabled in bootloader. s/clk/clock/ but otherwise looks good. Thierry --B8pxxDeV9zU7sDZJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSteSQACgkQ3SOs138+ s6Ewmw/+Jw6LqxW+nhesVM4WtgxXisrH0NZjNWnHnpN5oBoqgBSAVwdXgCPJKu4S L5GBmquR2ovzDLFCrn7Rkmis9FGeTu+kwFtcQY3ni47JCb6sg+oNM2qHmjC3O/Ad PpQMLLGaTsrCeSKYOiW1kSQXfB/O121aFdpDSuV2T/CZZWLeeFuCpPS6exjv7pCq GesJT7F1ZyeCH6kLrNN+5aciCSa+uOiSmvfjcZPsKbQcwiVxILIGIKCz1m2bKghE /7aA55I/l0G3DOkKk1JbY75tRVcyJDvldB39FMtY/vluqRxA2g/rWJ2EdGd9+IUr obHvnvsKUKD1MvNhgNe3qBmZg8HUrimB/YLBvth4yhEDbr4jgTwiPK/++Yx8lXdK CMbWdafBPsUingZ+N2oPfmYpm0zj91b7YR/dx43nqyQF4dfUi2NMw+eHZ/60jkst dv7hEbNFTd4OTcKkHjHWVC4fSrrT59YjoDt286WkFV04cKmwq7TK6Vev1m4o0Pfb zaMVQbja7A5Z+qQsPgIi8bFh0gzm0a7cZ1WsiDi7mSXkH3XoMcWyWrqlM6D7Z9BR kpiMJ4nH2ZGNIMiU3R0OZdr8GZ+SS0suhefHnosHsGVmxDUXoHqei6PfI3AsYERd QVsDLgy9kUM4ig4NAiZ7gHVB71Eb3DfnCi0A16fvfv/5w7h5kTY= =frzs -----END PGP SIGNATURE----- --B8pxxDeV9zU7sDZJ-- --===============0277613070345323502== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0277613070345323502==--